[ACA-4695] Fix saving screenshots for E2Es, add nx eslint plugin (#3148)

* [ACA-4695] Fix saving screenshots for E2Es, add nx eslint plugin

* [ACA-4695] Improve eslint rules

projects/aca-content/src/lib/components/search/search-libraries-results/search-libraries-results.component.ts

@@ -103,6 +103,7 @@ export class SearchLibrariesResultsComponent extends PageComponent implements On
 
     if (this.route) {
       this.route.params.forEach((params: Params) => {
+        // eslint-disable-next-line no-prototype-builtins
         this.searchedWord = params.hasOwnProperty(this.queryParamName) ? params[this.queryParamName] : null;
         const query = this.formatSearchQuery(this.searchedWord);
 

projects/aca-content/src/lib/components/search/search-results/search-results.component.ts

@@ -85,6 +85,7 @@ export class SearchResultsComponent extends PageComponent implements OnInit {
     combineLatest([this.route.params, this.queryBuilder.configUpdated])
       .pipe(takeUntil(this.onDestroy$))
       .subscribe(([params, searchConfig]) => {
+        // eslint-disable-next-line no-prototype-builtins
         this.searchedWord = params.hasOwnProperty(this.queryParamName) ? params[this.queryParamName] : null;
         const query = this.formatSearchQuery(this.searchedWord, searchConfig['aca:fields']);
         if (query) {
@@ -128,6 +129,7 @@ export class SearchResultsComponent extends PageComponent implements OnInit {
 
     if (this.route) {
       this.route.params.forEach((params: Params) => {
+        // eslint-disable-next-line no-prototype-builtins
         this.searchedWord = params.hasOwnProperty(this.queryParamName) ? params[this.queryParamName] : null;
         if (this.searchedWord) {
           this.queryBuilder.update();

projects/aca-content/src/lib/extensions/core.extensions.module.ts

@@ -29,7 +29,6 @@ import { ExtensionsModule } from '@alfresco/adf-extensions';
 import { AppExtensionService } from '@alfresco/aca-shared';
 import { ContentServiceExtensionService } from '../services/content-service-extension.service';
 
-// eslint-disable-next-line prefer-arrow/prefer-arrow-functions
 export function setupExtensions(service: AppExtensionService): () => void {
   return () => service.load();
 }

projects/aca-folder-rules/src/lib/rule-details/conditions/rule-composite-condition.ui-component.ts

@@ -128,6 +128,7 @@ export class RuleCompositeConditionUiComponent implements ControlValueAccessor,
   }
 
   isFormControlSimpleCondition(control: FormControl): boolean {
+    // eslint-disable-next-line no-prototype-builtins
     return control.value.hasOwnProperty('field');
   }
 

projects/aca-shared/rules/src/app.rules.ts

@@ -95,7 +95,7 @@ export const isContentServiceEnabled = (): boolean => localStorage && localStora
  * JSON ref: `app.isSearchSupported`
  */
 export const isSearchSupported = (context: RuleContext): boolean =>
-  [navigation.isNotSearchResults(context) /*, !hasSelection(context)*/].every(Boolean);
+  [navigation.isNotSearchResults(context) /* , !hasSelection(context)*/].every(Boolean);
 
 /**
  * Checks if upload action is supported for the given context
@@ -617,6 +617,7 @@ export function canOpenWithOffice(context: RuleContext): boolean {
 
   // workaround for Shared files
   if (context.navigation && context.navigation.url && context.navigation.url.startsWith('/shared')) {
+    // eslint-disable-next-line no-prototype-builtins
     if (file.entry.hasOwnProperty('allowableOperationsOnTarget')) {
       return context.permissions.check(file, ['update'], {
         target: 'allowableOperationsOnTarget'

projects/aca-shared/rules/src/navigation.rules.ts

@@ -136,8 +136,8 @@ export const isNotRecentFiles = (context: RuleContext): boolean => !isRecentFile
  * JSON ref: `app.navigation.isSearchResults`
  */
 export function isSearchResults(
-  context: RuleContext /*,
-  ...args: RuleParameter[]*/
+  context: RuleContext
+  // ...args: RuleParameter[]
 ): boolean {
   const { url } = context.navigation;
   return url && url.startsWith('/search');

projects/aca-shared/src/lib/services/content-api.service.ts

@@ -154,9 +154,8 @@ export class ContentApiService {
     };
     const queryOptions = Object.assign(defaults, options || {});
 
-    // @ts-ignore
     return from(
-      new Promise((resolve, reject) => {
+      new Promise<Node>((resolve, reject) => {
         this.nodesApi.getNode(nodeId, queryOptions).then(
           (nodeEntry: NodeEntry) => {
             resolve(nodeEntry.entry);

projects/adf-office-services-ext/src/lib/effects/aos.effects.spec.ts

@@ -64,7 +64,7 @@ describe('AosEffects', () => {
     const action = new AosAction(payload);
     aosActions$ = of(action);
 
-    effects.openOffice$.subscribe();
+    effects.openOffice$.subscribe(() => {});
 
     expect(onActionEditOnlineAosSpy).toHaveBeenCalledWith(payload);
   });