inteligr8/alfresco-content-app
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-content-app.git synced 2025-07-24 17:31:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Sonarcloud issues fixes (#3499)

Browse Source 
* Sonarcloud issues fixes

* Code smell fixes

* Refactoring to remove new code duplications

* Sonarcloud code smell fixes part I

* Sonarcloud code smell fixes part II

* Missing code smell fix

* Add new ESLint rules to cover fixed SonarCloud issues

* Add missing command

* Add missing is existing check
This commit is contained in:
MichalKinas
2023-11-03 11:43:06 +01:00
committed by GitHub
parent 968febffb0
commit 69c00fc403
72 changed files with 327 additions and 530 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
projects/aca-shared/rules/src/app.rules.ts
View File

@@ -178,7 +178,7 @@ export function isShared(context: RuleContext): boolean {
}
if (navigation.isNotTrashcan(context) && !context.selection.isEmpty && context.selection.file) {
return !!(context.selection.file.entry && context.selection.file.entry.properties && context.selection.file.entry.properties['qshare:sharedId']);
return !!context.selection.file.entry?.properties?.['qshare:sharedId'];
}
return false;
@@ -268,14 +268,7 @@ export const canCreateLibrary = (context: AcaRuleContext): boolean =>
* JSON ref: `app.navigation.folder.canUpload`
*/
export function canUpload(context: AcaRuleContext): boolean {
if (isContentServiceEnabled(context) && (navigation.isPersonalFiles(context) || navigation.isLibraryContent(context))) {
const { currentFolder } = context.navigation;
if (currentFolder) {
return context.permissions.check(currentFolder, ['create']);
}
}
return false;
return canCreateFolder(context);
}
/**
@@ -306,8 +299,7 @@ export const hasLibrarySelected = (context: RuleContext): boolean => !!context.s
* JSON ref: `app.selection.isPrivateLibrary`
*/
export function isPrivateLibrary(context: RuleContext): boolean {
const library = context.selection.library;
return library ? !!(library.entry && library.entry.visibility && library.entry.visibility === 'PRIVATE') : false;
return context.selection.library?.entry?.visibility === 'PRIVATE';
}
/**
@@ -316,7 +308,7 @@ export function isPrivateLibrary(context: RuleContext): boolean {
*/
export function hasLibraryRole(context: RuleContext): boolean {
const library = context.selection.library;
return library ? !!(library.entry && library.entry.role) : false;
return library ? !!library.entry?.role : false;
}
/**
@@ -329,7 +321,7 @@ export const hasNoLibraryRole = (context: RuleContext): boolean => !hasLibraryRo
* Checks if user has selected a file.
* JSON ref: `app.selection.file`
*/
export const hasFileSelected = (context: RuleContext): boolean => !!(context && context.selection && context.selection.file);
export const hasFileSelected = (context: RuleContext): boolean => !!context?.selection?.file;
/**
* Checks if user can update the first selected node.
@@ -376,13 +368,13 @@ export function canUpdateSelectedFolder(context: RuleContext): boolean {
* JSON ref: `app.selection.file.isLocked`
*/
export function hasLockedFiles(context: RuleContext): boolean {
if (context && context.selection && context.selection.nodes) {
if (context?.selection?.nodes) {
return context.selection.nodes.some((node) => {
if (!node.entry.isFile) {
return false;
}
return node.entry.isLocked || (node.entry.properties && node.entry.properties['cm:lockType'] === 'READ_ONLY_LOCK');
return node.entry.isLocked || node.entry.properties?.['cm:lockType'] === 'READ_ONLY_LOCK';
});
}
@@ -395,13 +387,8 @@ export function hasLockedFiles(context: RuleContext): boolean {
*/
export const isWriteLocked = (context: RuleContext): boolean =>
!!(
context &&
context.selection &&
context.selection.file &&
context.selection.file.entry &&
context.selection.file.entry.properties &&
(context.selection.file.entry.properties['cm:lockType'] === 'WRITE_LOCK' ||
context.selection.file.entry.properties['cm:lockType'] === 'READ_ONLY_LOCK')
context?.selection?.file?.entry?.properties?.['cm:lockType'] === 'WRITE_LOCK' ||
context?.selection?.file?.entry?.properties?.['cm:lockType'] === 'READ_ONLY_LOCK'
);
/**
@@ -589,17 +576,17 @@ export function canOpenWithOffice(context: AcaRuleContext): boolean {
return false;
}
if (context.navigation && context.navigation.url && context.navigation.url.startsWith('/trashcan')) {
if (context.navigation?.url?.startsWith('/trashcan')) {
return false;
}
if (!context || !context.selection) {
if (!context?.selection) {
return false;
}
const { file } = context.selection;
if (!file || !file.entry) {
if (!file?.entry) {
return false;
}
@@ -626,7 +613,7 @@ export function canOpenWithOffice(context: AcaRuleContext): boolean {
}
// workaround for Shared files
if (context.navigation && context.navigation.url && context.navigation.url.startsWith('/shared')) {
if (context.navigation?.url?.startsWith('/shared')) {
// eslint-disable-next-line no-prototype-builtins
if (file.entry.hasOwnProperty('allowableOperationsOnTarget')) {
return context.permissions.check(file, ['update'], {

24
projects/aca-shared/rules/src/navigation.rules.ts
View File

@@ -39,7 +39,7 @@ export function isPreview(context: RuleContext): boolean {
*/
export function isFavorites(context: RuleContext): boolean {
const { url } = context.navigation;
return url && url.startsWith('/favorites') && !isPreview(context);
return url?.startsWith('/favorites') && !isPreview(context);
}
/**
@@ -54,7 +54,7 @@ export const isNotFavorites = (context: RuleContext): boolean => !isFavorites(co
*/
export function isSharedFiles(context: RuleContext): boolean {
const { url } = context.navigation;
return url && url.startsWith('/shared') && !isPreview(context);
return url?.startsWith('/shared') && !isPreview(context);
}
/**
@@ -69,7 +69,7 @@ export const isNotSharedFiles = (context: RuleContext): boolean => !isSharedFile
*/
export function isTrashcan(context: RuleContext): boolean {
const { url } = context.navigation;
return url && url.startsWith('/trashcan');
return url?.startsWith('/trashcan');
}
/**
@@ -84,7 +84,7 @@ export const isNotTrashcan = (context: RuleContext): boolean => !isTrashcan(cont
*/
export function isPersonalFiles(context: RuleContext): boolean {
const { url } = context.navigation;
return url && url.startsWith('/personal-files');
return url?.startsWith('/personal-files');
}
/**
@@ -93,7 +93,7 @@ export function isPersonalFiles(context: RuleContext): boolean {
*/
export function isLibraryFiles(context: RuleContext): boolean {
const { url } = context.navigation;
return url && url.startsWith('/libraries');
return url?.startsWith('/libraries');
}
/**
@@ -102,12 +102,12 @@ export function isLibraryFiles(context: RuleContext): boolean {
*/
export function isLibraries(context: RuleContext): boolean {
const { url } = context.navigation;
return url && (url.endsWith('/libraries') || url.startsWith('/search-libraries'));
return url?.endsWith('/libraries') || url?.startsWith('/search-libraries');
}
export function isLibraryContent(context: RuleContext): boolean {
const { url } = context.navigation;
return url && (url.endsWith('/libraries') || url.includes('/libraries/') || url.startsWith('/search-libraries'));
return url?.endsWith('/libraries') || url?.includes('/libraries/') || url?.startsWith('/search-libraries');
}
/**
@@ -122,7 +122,7 @@ export const isNotLibraries = (context: RuleContext): boolean => !isLibraries(co
*/
export function isRecentFiles(context: RuleContext): boolean {
const { url } = context.navigation;
return url && url.startsWith('/recent-files');
return url?.startsWith('/recent-files');
}
/**
@@ -140,7 +140,7 @@ export function isSearchResults(
// ...args: RuleParameter[]
): boolean {
const { url } = context.navigation;
return url && url.startsWith('/search');
return url?.startsWith('/search');
}
/**
@@ -155,7 +155,7 @@ export const isNotSearchResults = (context: RuleContext): boolean => !isSearchRe
*/
export function isSharedPreview(context: RuleContext): boolean {
const { url } = context.navigation;
return url && (url.startsWith('/shared/preview/') || (url.startsWith('/shared') && url.includes('viewer:view')));
return url?.startsWith('/shared/preview/') || (url?.startsWith('/shared') && url?.includes('viewer:view'));
}
/**
@@ -164,7 +164,7 @@ export function isSharedPreview(context: RuleContext): boolean {
*/
export function isFavoritesPreview(context: RuleContext): boolean {
const { url } = context.navigation;
return url && (url.startsWith('/favorites/preview/') || (url.startsWith('/favorites') && url.includes('viewer:view')));
return url?.startsWith('/favorites/preview/') || (url?.startsWith('/favorites') && url?.includes('viewer:view'));
}
/**
@@ -173,5 +173,5 @@ export function isFavoritesPreview(context: RuleContext): boolean {
*/
export function isSharedFileViewer(context: RuleContext): boolean {
const { url } = context.navigation;
return url && url.startsWith('/preview/s/');
return url?.startsWith('/preview/s/');
}