inteligr8/alfresco-content-app
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-content-app.git synced 2025-07-31 17:38:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ACA-1529] performance fixes for permission checks (#498)

Browse Source 
* fix recent files

* fix files component

* fix shared files

* don't evaluate permissions for empty selection

* fix info drawer

* fix viewer

* fix tests

* reduce one more check

* track upload errors on app level

* remove console log

* reduce service dependencies
This commit is contained in:
Denys Vuika
2018-07-08 12:25:20 +01:00
committed by GitHub
parent fe683015c5
commit 718a32a907
23 changed files with 171 additions and 151 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/app/components/info-drawer/info-drawer.component.ts
View File

@@ -34,19 +34,11 @@ import { ContentApiService } from '../../services/content-api.service';
})
export class InfoDrawerComponent implements OnChanges {
@Input() nodeId: string;
@Input() node: MinimalNodeEntity;
isLoading = false;
displayNode: MinimalNodeEntryEntity;
canUpdateNode(): boolean {
if (this.displayNode) {
return this.permission.check(this.displayNode, ['update']);
}
return false;
}
canUpdateNode = false;
get isFileSelected(): boolean {
if (this.node && this.node.entry) {
@@ -78,7 +70,7 @@ export class InfoDrawerComponent implements OnChanges {
if (this.isTypeImage(entry) && !this.hasAspectNames(entry)) {
this.loadNodeInfo(this.node.entry.id);
} else {
this.displayNode = this.node.entry;
this.setDisplayNode(this.node.entry);
}
}
}
@@ -101,11 +93,16 @@ export class InfoDrawerComponent implements OnChanges {
this.contentApi.getNodeInfo(nodeId).subscribe(
entity => {
this.displayNode = entity;
this.setDisplayNode(entity);
this.isLoading = false;
},
() => this.isLoading = false
);
}
}
private setDisplayNode(node: MinimalNodeEntryEntity) {
this.displayNode = node;
this.canUpdateNode = node && this.permission.check(node, ['update']);
}
}