inteligr8/alfresco-content-app
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-content-app.git synced 2025-07-24 17:31:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ACA-1529] performance fixes for permission checks (#498)

Browse Source 
* fix recent files

* fix files component

* fix shared files

* don't evaluate permissions for empty selection

* fix info drawer

* fix viewer

* fix tests

* reduce one more check

* track upload errors on app level

* remove console log

* reduce service dependencies
This commit is contained in:
Denys Vuika
2018-07-08 12:25:20 +01:00
committed by GitHub
parent fe683015c5
commit 718a32a907
23 changed files with 171 additions and 151 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/app/components/recent-files/recent-files.component.html
View File

@@ -88,7 +88,7 @@
<button
mat-menu-item
*ngIf="permission.check(selection.nodes, ['delete'])"
*ngIf="canDelete"
[acaMoveNode]="selection.nodes">
<mat-icon>library_books</mat-icon>
<span>{{ 'APP.ACTIONS.MOVE' | translate }}</span>
@@ -96,7 +96,7 @@
<button
mat-menu-item
*ngIf="permission.check(selection.nodes, ['delete'])"
*ngIf="canDelete"
[acaDeleteNode]="selection.nodes">
<mat-icon>delete</mat-icon>
<span>{{ 'APP.ACTIONS.DELETE' | translate }}</span>

14
src/app/components/recent-files/recent-files.component.ts
View File

@@ -25,11 +25,8 @@
import { Component, OnInit } from '@angular/core';
import { MinimalNodeEntity } from 'alfresco-js-api';
import { UploadService } from '@alfresco/adf-core';
import { ContentManagementService } from '../../common/services/content-management.service';
import { PageComponent } from '../page.component';
import { NodePermissionService } from '../../common/services/node-permission.service';
import { Store } from '@ngrx/store';
import { AppStore } from '../../store/states/app.state';
import { ExtensionService } from '../../extensions/extension.service';
@@ -38,14 +35,12 @@ import { ExtensionService } from '../../extensions/extension.service';
templateUrl: './recent-files.component.html'
})
export class RecentFilesComponent extends PageComponent implements OnInit {
constructor(
store: Store<AppStore>,
extensions: ExtensionService,
private uploadService: UploadService,
private content: ContentManagementService,
public permission: NodePermissionService) {
super(store, extensions);
content: ContentManagementService
) {
super(store, extensions, content);
}
ngOnInit() {
@@ -54,8 +49,7 @@ export class RecentFilesComponent extends PageComponent implements OnInit {
this.subscriptions = this.subscriptions.concat([
this.content.nodesDeleted.subscribe(() => this.reload()),
this.content.nodesMoved.subscribe(() => this.reload()),
this.content.nodesRestored.subscribe(() => this.reload()),
this.uploadService.fileUploadError.subscribe((error) => this.onFileUploadedError(error))
this.content.nodesRestored.subscribe(() => this.reload())
]);
}