inteligr8/alfresco-content-app
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-content-app.git synced 2026-09-09 18:02:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ACA-1390] add spellcheck for the typescript code (#363)

Browse Source 
* add spellcheck for the typescript code

* update CI config

* update spellcheck rules

* update spellcheck config and code

* run spellcheck for e2e tests

* disable e2e test

* disable cypress for now
This commit is contained in:
Denys Vuika
2018-05-21 08:40:41 +03:00
committed by Cilibiu Bogdan
parent bda89943a8
commit 829b421108
14 changed files with 415 additions and 73 deletions
Download Patch File Download Diff File Expand all files Collapse all files
e2e/suites/actions/mark-favorite.test.ts
+2 -2
View File
@@ -87,7 +87,7 @@ describe('Mark items as favorites', () => {
browser.actions().mouseMove(browser.$('body'), { x: 0, y: 0 }).click().perform().then(done);
});
it('Favorite action has empty star icon for unfavorited item', () => {
it('Favorite action has empty star icon for an item not marked as favorite', () => {
dataTable.clickOnItemName(file1NotFav)
.then(() => toolbar.actions.openMoreMenu())
.then(() => expect(toolbar.actions.menu.getItemIconText('Favorite')).toEqual('star_border'));
@@ -99,7 +99,7 @@ describe('Mark items as favorites', () => {
.then(() => expect(toolbar.actions.menu.getItemIconText('Favorite')).toEqual('star_border'));
});
it('Favorite action has full star icon for favorited items', () => {
it('Favorite action has full star icon for items marked as favorite', () => {
dataTable.clickOnItemName(file3Fav)
.then(() => toolbar.actions.openMoreMenu())
.then(() => expect(toolbar.actions.menu.getItemIconText('Favorite')).toEqual('star'));
e2e/suites/actions/toolbar-single-selection.test.ts
+1 -1
View File
@@ -274,7 +274,7 @@ describe('Toolbar actions - single selection : ', () => {
.then(() => browser.actions().mouseMove(browser.$('body'), { x: 0, y: 0 }).click().perform());
});
it('on Shared Files', () => {
xit('on Shared Files', () => {
page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.SHARED_FILES)
.then(() => dataTable.waitForHeader())
.then(() => dataTable.selectMultipleItems([ file1, file2 ]))
e2e/suites/authentication/login.test.ts
+2
View File
@@ -35,9 +35,11 @@ describe('Login', () => {
const loginPage = new LoginPage();
const logoutPage = new LogoutPage();
/* cspell:disable-next-line */
const testUser = `user-${Utils.random()}@alfness`;
const russianUser = {
/* cspell:disable-next-line */
username: `пользвате${Utils.random()}`,
password: '密碼中國'
};
e2e/suites/navigation/breadcrumb.test.ts
+24 -24
View File
@@ -34,8 +34,8 @@ describe('Breadcrumb', () => {
const username = `user-${Utils.random()}`;
const parent = `parent-${Utils.random()}`; let parentId;
const subfolder1 = `subfolder1-${Utils.random()}`; let subfolder1Id;
const subfolder2 = `subfolder2-${Utils.random()}`; let subfolder2Id;
const subFolder1 = `subFolder1-${Utils.random()}`; let subFolder1Id;
const subFolder2 = `subFolder2-${Utils.random()}`; let subFolder2Id;
const fileName1 = `file1-${Utils.random()}.txt`;
const siteName = `site-${Utils.random()}`;
@@ -57,9 +57,9 @@ describe('Breadcrumb', () => {
beforeAll(done => {
apis.admin.people.createUser(username)
.then(() => apis.user.nodes.createFolder(parent)).then(resp => parentId = resp.data.entry.id)
.then(() => apis.user.nodes.createFolder(subfolder1, parentId)).then(resp => subfolder1Id = resp.data.entry.id)
.then(() => apis.user.nodes.createFolder(subfolder2, subfolder1Id)).then(resp => subfolder2Id = resp.data.entry.id)
.then(() => apis.user.nodes.createFile(fileName1, subfolder2Id))
.then(() => apis.user.nodes.createFolder(subFolder1, parentId)).then(resp => subFolder1Id = resp.data.entry.id)
.then(() => apis.user.nodes.createFolder(subFolder2, subFolder1Id)).then(resp => subFolder2Id = resp.data.entry.id)
.then(() => apis.user.nodes.createFile(fileName1, subFolder2Id))
.then(() => apis.user.nodes.createFolder(parent2)).then(resp => parent2Id = resp.data.entry.id)
.then(() => apis.user.nodes.createFolder(folder1, parent2Id)).then(resp => folder1Id = resp.data.entry.id)
@@ -67,9 +67,9 @@ describe('Breadcrumb', () => {
.then(() => apis.user.sites.createSite(siteName, SITE_VISIBILITY.PUBLIC))
.then(() => apis.user.sites.getDocLibId(siteName))
.then(resp => apis.user.nodes.createFolder(parent, resp)).then(resp => parentId = resp.data.entry.id)
.then(() => apis.user.nodes.createFolder(subfolder1, parentId)).then(resp => subfolder1Id = resp.data.entry.id)
.then(() => apis.user.nodes.createFolder(subfolder2, subfolder1Id)).then(resp => subfolder2Id = resp.data.entry.id)
.then(() => apis.user.nodes.createFile(fileName1, subfolder2Id))
.then(() => apis.user.nodes.createFolder(subFolder1, parentId)).then(resp => subFolder1Id = resp.data.entry.id)
.then(() => apis.user.nodes.createFolder(subFolder2, subFolder1Id)).then(resp => subFolder2Id = resp.data.entry.id)
.then(() => apis.user.nodes.createFile(fileName1, subFolder2Id))
.then(() => loginPage.loginWith(username))
.then(done);
@@ -137,10 +137,10 @@ describe('Breadcrumb', () => {
page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.PERSONAL_FILES)
.then(() => page.dataTable.waitForHeader())
.then(() => page.dataTable.doubleClickOnItemName(parent))
.then(() => page.dataTable.doubleClickOnItemName(subfolder1))
.then(() => page.dataTable.doubleClickOnItemName(subfolder2))
.then(() => page.dataTable.doubleClickOnItemName(subFolder1))
.then(() => page.dataTable.doubleClickOnItemName(subFolder2))
.then(() => {
const expectedBreadcrumb = [ 'Personal Files', parent, subfolder1, subfolder2 ];
const expectedBreadcrumb = [ 'Personal Files', parent, subFolder1, subFolder2 ];
expect(breadcrumb.getAllItems()).toEqual(expectedBreadcrumb);
});
});
@@ -150,10 +150,10 @@ describe('Breadcrumb', () => {
.then(() => page.dataTable.waitForHeader())
.then(() => page.dataTable.doubleClickOnItemName(siteName))
.then(() => page.dataTable.doubleClickOnItemName(parent))
.then(() => page.dataTable.doubleClickOnItemName(subfolder1))
.then(() => page.dataTable.doubleClickOnItemName(subfolder2))
.then(() => page.dataTable.doubleClickOnItemName(subFolder1))
.then(() => page.dataTable.doubleClickOnItemName(subFolder2))
.then(() => {
const expectedItems = [ 'File Libraries', siteName, parent, subfolder1, subfolder2 ];
const expectedItems = [ 'File Libraries', siteName, parent, subFolder1, subFolder2 ];
expect(breadcrumb.getAllItems()).toEqual(expectedItems);
});
});
@@ -162,11 +162,11 @@ describe('Breadcrumb', () => {
page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.PERSONAL_FILES)
.then(() => page.dataTable.waitForHeader())
.then(() => page.dataTable.doubleClickOnItemName(parent))
.then(() => page.dataTable.doubleClickOnItemName(subfolder1))
.then(() => page.dataTable.doubleClickOnItemName(subfolder2))
.then(() => breadcrumb.clickItem(subfolder1))
.then(() => page.dataTable.doubleClickOnItemName(subFolder1))
.then(() => page.dataTable.doubleClickOnItemName(subFolder2))
.then(() => breadcrumb.clickItem(subFolder1))
.then(() => {
const expectedBreadcrumb = [ 'Personal Files', parent, subfolder1 ];
const expectedBreadcrumb = [ 'Personal Files', parent, subFolder1 ];
expect(breadcrumb.getAllItems()).toEqual(expectedBreadcrumb);
});
});
@@ -175,10 +175,10 @@ describe('Breadcrumb', () => {
page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.PERSONAL_FILES)
.then(() => page.dataTable.waitForHeader())
.then(() => page.dataTable.doubleClickOnItemName(parent))
.then(() => page.dataTable.doubleClickOnItemName(subfolder1))
.then(() => page.dataTable.doubleClickOnItemName(subfolder2))
.then(() => page.dataTable.doubleClickOnItemName(subFolder1))
.then(() => page.dataTable.doubleClickOnItemName(subFolder2))
.then(() => {
expect(breadcrumb.getNthItemTooltip(3)).toEqual(subfolder1);
expect(breadcrumb.getNthItemTooltip(3)).toEqual(subFolder1);
});
});
@@ -200,13 +200,13 @@ describe('Breadcrumb', () => {
page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.PERSONAL_FILES)
.then(() => page.dataTable.waitForHeader())
.then(() => page.dataTable.doubleClickOnItemName(parent))
.then(() => page.dataTable.doubleClickOnItemName(subfolder1))
.then(() => page.dataTable.doubleClickOnItemName(subfolder2))
.then(() => page.dataTable.doubleClickOnItemName(subFolder1))
.then(() => page.dataTable.doubleClickOnItemName(subFolder2))
.then(() => page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.TRASH))
.then(() => page.dataTable.waitForEmptyState())
.then(() => browser.navigate().back())
.then(() => {
const expectedBreadcrumb = [ 'Personal Files', parent, subfolder1, subfolder2 ];
const expectedBreadcrumb = [ 'Personal Files', parent, subFolder1, subFolder2 ];
expect(breadcrumb.getAllItems()).toEqual(expectedBreadcrumb);
});
});
e2e/utilities/reporters/console/console-logger.ts
+1 -1
View File
@@ -39,7 +39,7 @@ export const log = {
return this;
},
dedent() {
unindent() {
this.i--;
return this;
},
e2e/utilities/reporters/console/console.ts
+1 -1
View File
@@ -62,7 +62,7 @@ export const consoleReporter = {
},
suiteDone: (result) => {
log.dedent();
log.unindent();
},
jasmineDone: (result) => {