inteligr8/alfresco-content-app
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-content-app.git synced 2025-07-24 17:31:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ACA-3427] Remove About tab when it's not useful (#1491)

Browse Source 
* [ACA-3427] Remove About tab when it's  not useful

* Add unit tests for isLibraryManager rule

* Fix e2e tests

* Fix e2e tests and add rule to docs

* Fix e2e tests
This commit is contained in:
davidcanonieto
2020-06-18 22:03:26 +01:00
committed by GitHub
parent e2b6ebab9b
commit 85f71f5ae1
7 changed files with 63 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
e2e/suites/actions-available/libraries/test-data-libraries.ts
View File

@@ -38,12 +38,12 @@ const memberToolbarPrimary = ['Leave Library', 'View Details', 'More Actions'];
const favToolbarMore = ['Delete', 'Remove Favorite'];
const notFavToolbarMore = ['Delete', 'Favorite'];
const searchMemberToolbarPrimary = ['Toggle search filter', 'Leave Library', 'View Details', 'More Actions'];
const searchReqJoinToolbarPrimary = ['Toggle search filter', 'Cancel Join Request', 'View Details', 'More Actions'];
const searchNotMemberToolbarPrimary = ['Toggle search filter', 'Join', 'View Details', 'More Actions'];
const reqJoinToolbarMore = ['Cancel Join Request', 'View Details', 'More Actions'];
const searchReqJoinToolbarPrimary = ['Toggle search filter', 'Cancel Join Request', 'More Actions'];
const searchNotMemberToolbarPrimary = ['Toggle search filter', 'Join', 'More Actions'];
const reqJoinToolbarMore = ['Cancel Join Request', 'More Actions'];
const notMemberFavContextMenu = ['Join', 'Delete', 'Remove Favorite'];
const notMemberNotFavContextMenu = ['Join', 'Delete', 'Favorite'];
const notMemberToolbarPrimary = ['Join', 'View Details', 'More Actions'];
const notMemberToolbarPrimary = ['Join', 'More Actions'];
const reqJoinNotFavContextMenu = ['Cancel Join Request', 'Delete', 'Favorite'];
const reqJoinFavContextMenu = ['Cancel Join Request', 'Delete', 'Remove Favorite'];

9
e2e/suites/info-drawer/library-properties.test.ts
View File

@@ -112,7 +112,7 @@ describe('Library properties', () => {
await infoDrawer.waitForInfoDrawerToOpen();
expect(await infoDrawer.getHeaderTitle()).toEqual('Details');
expect(await infoDrawer.isAboutTabDisplayed()).toBe(true, 'About tab is not displayed');
expect(await infoDrawer.isPropertiesTabDisplayed()).toBe(true, 'Properties tab is not displayed');
expect(await aboutTab.isNameDisplayed()).toBe(true, 'Name field not displayed');
expect(await aboutTab.isLibraryIdDisplayed()).toBe(true, 'Library ID field not displayed');
expect(await aboutTab.isVisibilityDisplayed()).toBe(true, 'Visibility field not displayed');
@@ -236,14 +236,11 @@ describe('Library properties', () => {
done();
});
it('[C289337] Edit button is not displayed when user is not the library manager', async () => {
it('[C289337] Info drawer button is not displayed when user is not the library manager', async () => {
await loginPage.loginWith(user2);
await page.clickFileLibrariesAndWait();
await dataTable.selectItem(site.name);
await page.toolbar.viewDetailsButton.click();
await infoDrawer.waitForInfoDrawerToOpen();
expect(await aboutTab.isEditLibraryPropertiesDisplayed()).toBe(false, 'Edit action is displayed');
expect(await page.toolbar.isButtonPresent('View Details')).toBe(false, 'View Details is present');
});
it('[C289344] Error notification', async () => {