[ACS-11417] lint enable angular eslint prefer inject rule default in ng20 for alfresco apps (#5111)

* [ACS-11417] Enable inject prefer eslint rule

* [ACS-11417] Added eslint rule for prefer readonly

* [ACS-11417] Fixed unit tests

* [ACS-11417] Addressed copilot comments
This commit is contained in:
AleksanderSklorz
2026-03-25 08:45:32 +01:00
committed by GitHub
parent 65c814d75b
commit 89a42b3de5
186 changed files with 929 additions and 938 deletions
@@ -24,7 +24,7 @@
/* cspell:disable */
import { AuthenticationService, NotificationService } from '@alfresco/adf-core';
import { Injectable } from '@angular/core';
import { Injectable, inject } from '@angular/core';
import { Node } from '@alfresco/js-api';
import { getFileExtension, supportedExtensions } from '@alfresco/aca-shared/rules';
import { AppSettingsService } from '@alfresco/aca-shared';
@@ -37,11 +37,9 @@ export interface IAosEditOnlineService {
providedIn: 'root'
})
export class AosEditOnlineService implements IAosEditOnlineService {
constructor(
private authenticationService: AuthenticationService,
private appSettings: AppSettingsService,
private notificationService: NotificationService
) {}
private readonly authenticationService = inject(AuthenticationService);
private readonly appSettings = inject(AppSettingsService);
private readonly notificationService = inject(NotificationService);
onActionEditOnlineAos(node: Node): void {
if (node && this.isFile(node) && node.properties) {
@@ -31,8 +31,8 @@ import { AosEditOnlineService } from '../aos-extension.service';
@Injectable()
export class AosEffects {
private actions$ = inject(Actions);
private aosEditOnlineService = inject(AosEditOnlineService);
private readonly actions$ = inject(Actions);
private readonly aosEditOnlineService = inject(AosEditOnlineService);
openOffice$ = createEffect(
() =>