inteligr8/alfresco-content-app
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-content-app.git synced 2025-07-24 17:31:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

[MNT-25175] Display script name for folder rule (#4637)

Browse Source 
* [MNT-25175] Display script name for folder rule

* [MNT-25175] Fixed e2e

* [MNT-25175] Exclude e2e tests

* [MNT-25175] Exclude e2e tests
This commit is contained in:
AleksanderSklorz
2025-07-01 08:01:36 +02:00
committed by GitHub
parent 4fec967ef3
commit 8e243db88d
10 changed files with 42 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
e2e/playwright/folder-rules/src/tests/create-rules.e2e.ts
View File

@@ -195,7 +195,12 @@ test.describe('Folder Rules Actions', () => {
await nodesPage.manageRulesDialog.createRuleButton.waitFor({ state: 'hidden' });
await nodesPage.manageRules.getGroupsList(randomRuleName).click();
await nodesPage.manageRules.checkAspects(['cm:generalclassifiable', 'cm:countable', 'sys:incomplete', 'st:siteContainer']);
await nodesPage.manageRules.checkAspects([
'Classifiable [cm:generalclassifiable]',
'Countable [cm:countable]',
'Incomplete [sys:incomplete]',
'Site Container [st:siteContainer]'
]);
});
test('[XAT-891] Prevent rule creation after clicking on cancel during selecting destination folder', async ({ nodesPage, personalFiles }) => {

5
e2e/playwright/info-drawer/exclude.tests.json
View File

@@ -1,3 +1,6 @@
{
"XAT-5523": "https://hyland.atlassian.net/browse/ACA-4697"
"XAT-5523": "https://hyland.atlassian.net/browse/ACA-4697",
"XAT-17239": "https://hyland.atlassian.net/browse/ACS-9795",
"XAT-5516": "https://hyland.atlassian.net/browse/ACS-9795",
"XAT-5520": "https://hyland.atlassian.net/browse/ACS-9795"
}

3
e2e/playwright/search/exclude.tests.json
View File

@@ -5,5 +5,6 @@
"XAT-5571": "https://hyland.atlassian.net/browse/ACS-9756",
"XAT-17700": "https://hyland.atlassian.net/browse/ACS-9756",
"XAT-17120": "https://hyland.atlassian.net/browse/ACS-9756",
"XAT-5567": "https://hyland.atlassian.net/browse/ACS-9756"
"XAT-5567": "https://hyland.atlassian.net/browse/ACS-9756",
"XAT-17121": "https://hyland.atlassian.net/browse/ACS-9795"
}

4
e2e/playwright/smoke-test/exclude.tests.json
View File

@@ -1 +1,3 @@
{}
{
"XAT-17738": "https://hyland.atlassian.net/browse/ACS-9795"
}

10
e2e/playwright/viewer/exclude.tests.json
View File

@@ -1 +1,9 @@
{}
{
"XAT-5465": "https://hyland.atlassian.net/browse/ACS-9795",
"XAT-17781": "https://hyland.atlassian.net/browse/ACS-9795",
"XAT-17181": "https://hyland.atlassian.net/browse/ACS-9795",
"XAT-17182": "https://hyland.atlassian.net/browse/ACS-9795",
"XAT-17640": "https://hyland.atlassian.net/browse/ACS-9795",
"XAT-17644": "https://hyland.atlassian.net/browse/ACS-9795",
"XAT-5476": "https://hyland.atlassian.net/browse/ACS-9795"
}

2
projects/aca-content/folder-rules/src/rule-details/actions/rule-action-list.ui-component.scss
View File

@@ -2,6 +2,8 @@
/* stylelint-disable selector-class-pattern */
.aca-rule-action-list {
min-width: 0;
.aca-rule-action-list__item .aca-rule-action .mat-mdc-form-field-flex .mat-mdc-form-field-infix {
padding-top: 24px;
}

4
projects/aca-content/folder-rules/src/rule-details/actions/rule-action.ui-component.html
View File

@@ -1,6 +1,6 @@
<form class="aca-rule-action__form" [formGroup]="form">
<mat-form-field class="aca-rule-action-full-width" appearance="fill" subscriptSizing="dynamic">
<mat-form-field class="aca-rule-action-full-width aca-rule-action-form-field" appearance="fill" subscriptSizing="dynamic">
<mat-select
formControlName="actionDefinitionId"
data-automation-id="rule-action-select"
@@ -17,7 +17,7 @@
*ngIf="cardViewItems?.length > 0"
data-automation-id="rule-action-card-view"
[properties]="cardViewItems"
class="aca-rule-action-full-width"
class="aca-rule-action-full-width aca-rule-action-card-view"
[editable]="!readOnly" />
</form>

11
projects/aca-content/folder-rules/src/rule-details/actions/rule-action.ui-component.scss
View File

@@ -1,4 +1,6 @@
.aca-rule-action {
max-width: 100%;
&__form {
display: flex;
flex-direction: row;
@@ -27,5 +29,14 @@
&-full-width {
height: fit-content;
flex: 1;
&.aca-rule-action-form-field {
min-width: unset;
}
&.aca-rule-action-card-view {
overflow: hidden;
margin-top: 11px;
}
}
}

2
projects/aca-content/folder-rules/src/rule-details/actions/rule-action.ui-component.ts
View File

@@ -255,7 +255,7 @@ export class RuleActionUiComponent implements ControlValueAccessor, OnInit, OnCh
}
// falls through
default:
if (constraintsForDropdownBox && !this.readOnly) {
if (constraintsForDropdownBox) {
return new CardViewSelectItemModel({
...cardViewPropertiesModel,
value: (this.parameters[paramDef.name] as string) ?? '',

4
projects/aca-playwright-shared/src/page-objects/components/manageRules/manage-rules.component.ts
View File

@@ -35,7 +35,7 @@ export class ManageRules extends BaseComponent {
public ruleDetailsDeleteButton = this.getChild('#delete-rule-btn');
public ruleDetailsEditButton = this.getChild('#edit-rule-btn');
public ruleDetailsWhenText = this.getChild('[data-automation-id="rule-details-triggers-component"]');
public ruleDetailsPerformActionsDiv = this.getChild('adf-card-view-textitem mat-form-field input');
public ruleDetailsPerformActionsDiv = this.getChild('adf-card-view-selectitem .adf-property-read-only');
public rulesEmptyListTitle = this.getChild('.adf-empty-content__title');
public ruleActions = this.getChild('aca-rule-action');
public ruleConditionsInGroup = this.getChild('aca-rule-composite-condition aca-rule-simple-condition');
@@ -47,7 +47,7 @@ export class ManageRules extends BaseComponent {
async checkAspects(aspects: string[]): Promise<void> {
for (let i = 0; i < aspects.length; i++) {
const aspectsActions = await this.ruleDetailsPerformActionsDiv.nth(i).inputValue();
const aspectsActions = await this.ruleDetailsPerformActionsDiv.nth(i).innerText();
expect(aspects).toContain(aspectsActions);
}
}