From 90ca3707f7d9cc6f15ea54adfd568ed787c99089 Mon Sep 17 00:00:00 2001 From: MichalKinas <113341662+MichalKinas@users.noreply.github.com> Date: Wed, 13 Nov 2024 14:26:24 +0100 Subject: [PATCH] SonarCloud fixes (#4235) --- .../src/rule-details/validators/rule-actions.validator.ts | 3 +-- .../folder-rules/src/services/folder-rule-sets.service.ts | 2 +- .../folder-rules/src/services/folder-rules.service.ts | 2 +- .../common/location-link/location-link.component.ts | 2 +- projects/aca-playwright-shared/src/utils/utils.ts | 4 ++-- .../aca-shared/src/lib/services/node-permission.service.ts | 2 +- scripts/gh/update/latest-version-of.js | 4 ++-- 7 files changed, 9 insertions(+), 10 deletions(-) diff --git a/projects/aca-content/folder-rules/src/rule-details/validators/rule-actions.validator.ts b/projects/aca-content/folder-rules/src/rule-details/validators/rule-actions.validator.ts index 71a08b41d..0e586f764 100644 --- a/projects/aca-content/folder-rules/src/rule-details/validators/rule-actions.validator.ts +++ b/projects/aca-content/folder-rules/src/rule-details/validators/rule-actions.validator.ts @@ -37,8 +37,7 @@ const isRuleActionValid = (value: unknown, actionDefinitions: ActionDefinitionTr : undefined; return ( isRuleAction(value) && - actionDefinition && - actionDefinition.parameterDefinitions.reduce( + actionDefinition?.parameterDefinitions.reduce( (isValid: boolean, paramDef: ActionParameterDefinitionTransformed) => isValid && (!paramDef.mandatory || !!value.params[paramDef.name]), true ) diff --git a/projects/aca-content/folder-rules/src/services/folder-rule-sets.service.ts b/projects/aca-content/folder-rules/src/services/folder-rule-sets.service.ts index 65a51835c..b106446a3 100644 --- a/projects/aca-content/folder-rules/src/services/folder-rule-sets.service.ts +++ b/projects/aca-content/folder-rules/src/services/folder-rule-sets.service.ts @@ -37,7 +37,7 @@ import { Rule } from '../model/rule.model'; providedIn: 'root' }) export class FolderRuleSetsService { - public static MAX_RULE_SETS_PER_GET = 100; + public static readonly MAX_RULE_SETS_PER_GET = 100; static isOwnedRuleSet(ruleSet: RuleSet, nodeId: string): boolean { return ruleSet?.owningFolder?.id === nodeId; diff --git a/projects/aca-content/folder-rules/src/services/folder-rules.service.ts b/projects/aca-content/folder-rules/src/services/folder-rules.service.ts index 9c2464886..5414e9a45 100644 --- a/projects/aca-content/folder-rules/src/services/folder-rules.service.ts +++ b/projects/aca-content/folder-rules/src/services/folder-rules.service.ts @@ -40,7 +40,7 @@ interface GetRulesResult { providedIn: 'root' }) export class FolderRulesService { - public static MAX_RULES_PER_GET = 100; + public static readonly MAX_RULES_PER_GET = 100; public static get emptyCompositeCondition(): RuleCompositeCondition { return { diff --git a/projects/aca-content/src/lib/components/common/location-link/location-link.component.ts b/projects/aca-content/src/lib/components/common/location-link/location-link.component.ts index a48874411..2b1f6c26d 100644 --- a/projects/aca-content/src/lib/components/common/location-link/location-link.component.ts +++ b/projects/aca-content/src/lib/components/common/location-link/location-link.component.ts @@ -83,7 +83,7 @@ export class LocationLinkComponent implements OnInit { ngOnInit() { if (this.context) { const node: NodeEntry = this.context.row.node; - if (node?.entry && node?.entry?.path) { + if (node?.entry?.path) { const path = node.entry.path; if (path?.name && path?.elements) { diff --git a/projects/aca-playwright-shared/src/utils/utils.ts b/projects/aca-playwright-shared/src/utils/utils.ts index d3f47e629..9e653bb87 100644 --- a/projects/aca-playwright-shared/src/utils/utils.ts +++ b/projects/aca-playwright-shared/src/utils/utils.ts @@ -30,8 +30,8 @@ import StreamZip from 'node-stream-zip'; import { NodesApi, SitesApi, TrashcanApi } from '../api'; export class Utils { - static string257Long = 'x'.repeat(257); - static string513Long = 'x'.repeat(513); + static readonly string257Long = 'x'.repeat(257); + static readonly string513Long = 'x'.repeat(513); static random(): string { return crypto.getRandomValues(new Uint32Array(1))[0].toString(36).substring(0, 5).toLowerCase(); diff --git a/projects/aca-shared/src/lib/services/node-permission.service.ts b/projects/aca-shared/src/lib/services/node-permission.service.ts index bf4e8b729..1ab0b670e 100644 --- a/projects/aca-shared/src/lib/services/node-permission.service.ts +++ b/projects/aca-shared/src/lib/services/node-permission.service.ts @@ -37,7 +37,7 @@ export interface PermissionOptions { providedIn: 'root' }) export class NodePermissionService implements NodePermissions { - static DEFAULT_OPERATION = 'OR'; + static readonly DEFAULT_OPERATION = 'OR'; private defaultOptions: PermissionOptions = { operation: NodePermissionService.DEFAULT_OPERATION, diff --git a/scripts/gh/update/latest-version-of.js b/scripts/gh/update/latest-version-of.js index ccbedb5b1..c739cf7bf 100644 --- a/scripts/gh/update/latest-version-of.js +++ b/scripts/gh/update/latest-version-of.js @@ -34,12 +34,12 @@ module.exports = async ({ exec, github, dependencyName, tag }) => { } } - const latestPkgToUpdate = availablePackages.find((package) => package.name === matchedPkgVersion); + const latestPkgToUpdate = availablePackages.find((pkg) => pkg.name === matchedPkgVersion); if (localVersion === latestPkgToUpdate?.name) { return { hasNewVersion: 'false' }; } else { - const findLocalVersionOnRemote = availablePackages.find((package) => package.name === localVersion); + const findLocalVersionOnRemote = availablePackages.find((pkg) => pkg.name === localVersion); let rangeInDays = 'N/A'; if (findLocalVersionOnRemote !== undefined) { const creationLocal = new Date(findLocalVersionOnRemote.created_at);