inteligr8/alfresco-content-app
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-content-app.git synced 2026-09-09 18:02:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ACS-5675] replace breadcrumbs with H1 tags (#3358)

Browse Source 
* rename tabs css class to match the ACA app

* fix incorrect tooltip for close button

* fix close button layout and a11y

* lazy loading for details component

* replace breadcrumbs with H1 tag

* replace breadcrumbs with H1 tag

* cleanup unused playwright pages

* remove breadcrumbs from e2e

* remove line height
This commit is contained in:
Denys Vuika
2023-07-21 10:42:23 +01:00
committed by GitHub
parent e2257bad23
commit 9204194e53
42 changed files with 99 additions and 206 deletions
Download Patch File Download Diff File Expand all files Collapse all files
e2e/playwright/actions/src/tests/create-library.spec.ts
-13
View File
@@ -89,14 +89,12 @@ test.describe('Create Libraries ', () => {
test('[C280025] Create a public library', async ({ myLibrariesPage }) => {
const libraryDialog = myLibrariesPage.libraryDialog;
const libraryTable = myLibrariesPage.dataTable;
const libraryBreadcrumb = myLibrariesPage.breadcrumb;
await myLibrariesPage.selectCreateLibrary();
await libraryDialog.getLabelText(libraryNameLabel).fill(randomLibraryName);
await expect(libraryDialog.getLabelText(libraryNameLabel)).toHaveValue(randomLibraryName);
await expect(libraryDialog.getLabelText(libraryIdLabel)).toHaveValue(randomLibraryName);
await libraryDialog.createButton.click();
await expect(libraryBreadcrumb.getBreadcrumbItem(randomLibraryName)).toBeVisible();
await myLibrariesPage.navigate();
await libraryTable.goThroughPagesLookingForRowWithName(randomLibraryName);
@@ -108,11 +106,9 @@ test.describe('Create Libraries ', () => {
test('[C289880] Create a moderated library', async ({ myLibrariesPage }) => {
const libraryDialog = myLibrariesPage.libraryDialog;
const libraryTable = myLibrariesPage.dataTable;
const libraryBreadcrumb = myLibrariesPage.breadcrumb;
await myLibrariesPage.selectCreateLibrary();
await libraryDialog.createLibraryWithNameAndId(randomLibraryName, randomLibraryId, null, moderatedVisibility);
await expect(libraryBreadcrumb.getBreadcrumbItem(randomLibraryName)).toBeVisible();
await myLibrariesPage.navigate();
await libraryTable.goThroughPagesLookingForRowWithName(randomLibraryName);
@@ -124,11 +120,9 @@ test.describe('Create Libraries ', () => {
test('[C289881] Create a private library', async ({ myLibrariesPage }) => {
const libraryDialog = myLibrariesPage.libraryDialog;
const libraryTable = myLibrariesPage.dataTable;
const libraryBreadcrumb = myLibrariesPage.breadcrumb;
await myLibrariesPage.selectCreateLibrary();
await libraryDialog.createLibraryWithNameAndId(randomLibraryName, randomLibraryId, null, privateVisibility);
await expect(libraryBreadcrumb.getBreadcrumbItem(randomLibraryName)).toBeVisible();
await myLibrariesPage.navigate();
await libraryTable.goThroughPagesLookingForRowWithName(randomLibraryName);
@@ -140,13 +134,11 @@ test.describe('Create Libraries ', () => {
test('[C289882] Create a library with a given ID and description', async ({ myLibrariesPage }) => {
const libraryDialog = myLibrariesPage.libraryDialog;
const libraryTable = myLibrariesPage.dataTable;
const libraryBreadcrumb = myLibrariesPage.breadcrumb;
const libraryViewDetails = myLibrariesPage.acaHeader.viewDetails;
const libraryDetails = myLibrariesPage.libraryDetails;
await myLibrariesPage.selectCreateLibrary();
await libraryDialog.createLibraryWithNameAndId(randomLibraryName, randomLibraryId, randomLibraryDescription);
await expect(libraryBreadcrumb.getBreadcrumbItem(randomLibraryName)).toBeVisible();
await myLibrariesPage.navigate();
await libraryTable.goThroughPagesLookingForRowWithName(randomLibraryName);
@@ -193,7 +185,6 @@ test.describe('Create Libraries ', () => {
test('[C280029] Cancel button', async ({ myLibrariesPage }) => {
const libraryDialog = myLibrariesPage.libraryDialog;
const libraryTable = myLibrariesPage.dataTable;
const libraryBreadcrumb = myLibrariesPage.breadcrumb;
await myLibrariesPage.selectCreateLibrary();
await expect(libraryDialog.getDialogTitle(libraryDialogTitle)).toBeVisible();
@@ -201,7 +192,6 @@ test.describe('Create Libraries ', () => {
await libraryDialog.cancelButton.click();
await expect(libraryDialog.getDialogTitle(libraryDialogTitle)).toBeHidden();
await expect(libraryBreadcrumb.getBreadcrumbItem(randomLibraryName)).toHaveCount(0);
await expect(libraryTable.getRowByName(randomLibraryName)).toHaveCount(0);
});
@@ -243,15 +233,12 @@ test.describe('Create Libraries ', () => {
test('[C280030] Create 2 libraries with same name but different IDs', async ({ myLibrariesPage }) => {
const libraryDialog = myLibrariesPage.libraryDialog;
const libraryTable = myLibrariesPage.dataTable;
const libraryBreadcrumb = myLibrariesPage.breadcrumb;
const libraryName = commonLibraryName + ' (' + commonLibraryId + ')';
const libraryName2 = commonLibraryName + ' (' + randomLibraryId + ')';
await myLibrariesPage.selectCreateLibrary();
await libraryDialog.createLibraryWithNameAndId(commonLibraryName, randomLibraryId);
await expect(libraryBreadcrumb.getBreadcrumbItem(commonLibraryName)).toBeVisible();
await myLibrariesPage.navigate();
await libraryTable.goThroughPagesLookingForRowWithName(libraryName);
await expect(libraryTable.getRowByName(libraryName)).toBeVisible();
e2e/protractor/suites/navigation/breadcrumb.test.ts
-30
View File
@@ -96,36 +96,6 @@ describe('Breadcrumb', () => {
await verifyBreadcrumb(1, 'Personal Files');
});
it('[C260966] My Libraries breadcrumb main node', async () => {
await page.goToMyLibrariesAndWait();
await verifyBreadcrumb(1, 'My Libraries');
});
it('[C289891] Favorite Libraries breadcrumb main node', async () => {
await page.goToFavoriteLibrariesAndWait();
await verifyBreadcrumb(1, 'Favorite Libraries');
});
it('[C260971] Recent Files breadcrumb main node', async () => {
await page.clickRecentFiles();
await verifyBreadcrumb(1, 'Recent Files');
});
it('[C260972] Shared Files breadcrumb main node', async () => {
await page.clickSharedFiles();
await verifyBreadcrumb(1, 'Shared Files');
});
it('[C260973] Favorites breadcrumb main node', async () => {
await page.clickFavorites();
await verifyBreadcrumb(1, 'Favorites');
});
it('[C260974] Trash breadcrumb main node', async () => {
await page.clickTrash();
await verifyBreadcrumb(1, 'Trash');
});
it('[C260965] Personal Files breadcrumb for a folder hierarchy', async () => {
await page.clickPersonalFilesAndWait();
await page.dataTable.doubleClickOnRowByName(parent);