ACA Run the test against the remote env (#1669)

* Run the test against the remote env

* Use remote user

* exclude e2e and raise issue

* Exlude more

* small change to trigger travis

* add api method to get totalItems of various endpoints

* lint fix

* remove tests from excluded to see what fails

* - fix some issues with the screenshot plugin
- add methods to get total items for some endpoints
- fix some waitForApi calls to consider initial total items number
- sortByModified descending in order to find the item needed by the test when having items on multiple pages

* Try to fix screenshots

* a few more fixes

* Upload screenshots

* a few more fixes

* Delete e2e-output-${retry} at the end

* delete unused variable

* some changes

* lint

* try one more fix

* Try to fix retry

* a few more fixes

* Try to fix retry

* some more fixes

* Fix "on Recent Files" suite

* Move "on Search Results" at the beginning of the class in order to avoid waitForApi:catch

* Empty commit

* Empty commit

* Empty commit

* Run e2e with lite-server

* Exclude protractor report folder

* Remove useless config

* change browser size

* no message

* one more try

* Empty commit

* try to maximize

* fix upload Recent files tests

* revert maximizing the browser

* don't "Run e2e with lite-server"

* fix mark-favorite tests

* few more fixes

* fix viewer and share tests

* test the lite server with retry

* Verify suites with lite server

* some final fixes

* Try to use httpserver

* Print the file and use http server

* Use http-server to fix protractor retry

* more fixes

* forgot a space :|

* remove extra job not needed anymore
rename test data into more specific

* play with the screenshots

* try new run

* trigger one more run

* a few more little fixes

* Fix comments

* Remove comment

* Fix lint error

Co-authored-by: Adina Parpalita <Adina.Parpalita@ness.com>
Co-authored-by: Cristina Jalba <cristina.jalba@ness.com>
Co-authored-by: iuliaib <iulia.burca@ness.com>

e2e/suites/list-views/trash.test.ts

@@ -30,27 +30,27 @@ describe('Trash', () => {
 
   const siteName = `site-${Utils.random()}`;
   const fileSite = `file-${Utils.random()}.txt`;
-  let fileSiteId;
+  let fileSiteId: string;
 
   const folderAdmin = `folder-${Utils.random()}`;
-  let folderAdminId;
+  let folderAdminId: string;
   const fileAdmin = `file-${Utils.random()}.txt`;
-  let fileAdminId;
+  let fileAdminId: string;
 
   const folderUser = `folder-${Utils.random()}`;
-  let folderUserId;
+  let folderUserId: string;
   const fileUser = `file-${Utils.random()}.txt`;
-  let fileUserId;
+  let fileUserId: string;
 
   const folderDeleted = `folder-${Utils.random()}`;
-  let folderDeletedId;
+  let folderDeletedId: string;
   const fileDeleted = `file-${Utils.random()}.txt`;
-  let fileDeletedId;
+  let fileDeletedId: string;
 
   const folderNotDeleted = `folder-${Utils.random()}`;
   let folderNotDeletedId: string;
   const fileInFolder = `file-${Utils.random()}.txt`;
-  let fileInFolderId;
+  let fileInFolderId: string;
 
   const apis = {
     admin: new RepoClient(),
@@ -61,7 +61,7 @@ describe('Trash', () => {
   const page = new BrowsingPage();
   const { dataTable, breadcrumb } = page;
 
-  beforeAll(async (done) => {
+  beforeAll(async () => {
     await apis.admin.people.createUser({ username });
     fileAdminId = (await apis.admin.nodes.createFiles([fileAdmin])).entry.id;
     folderAdminId = (await apis.admin.nodes.createFolders([folderAdmin])).entry.id;
@@ -80,12 +80,16 @@ describe('Trash', () => {
     await apis.user.nodes.deleteNodesById([fileSiteId, fileUserId, folderUserId, fileInFolderId], false);
     await apis.user.nodes.deleteNodeById(fileDeletedId, false);
     await apis.user.nodes.deleteNodeById(folderDeletedId, false);
-
-    done();
   });
 
   afterAll(async (done) => {
-    await Promise.all([apis.admin.sites.deleteSite(siteName), apis.user.nodes.deleteNodeById(folderNotDeletedId), apis.admin.trashcan.emptyTrash()]);
+    await Promise.all([
+      apis.admin.sites.deleteSite(siteName),
+      apis.admin.trashcan.permanentlyDelete(fileAdminId),
+      apis.admin.trashcan.permanentlyDelete(folderAdminId),
+      apis.user.nodes.deleteNodeById(folderNotDeletedId),
+      apis.user.trashcan.emptyTrash()
+    ]);
     done();
   });
 
@@ -108,8 +112,6 @@ describe('Trash', () => {
     });
 
     it('[C280493] displays the files and folders deleted by everyone', async () => {
-      expect(await dataTable.getRowsCount()).toEqual(8, 'Incorrect number of deleted items displayed');
-
       expect(await dataTable.isItemPresent(fileAdmin)).toBe(true, `${fileAdmin} not displayed`);
       expect(await dataTable.isItemPresent(folderAdmin)).toBe(true, `${folderAdmin} not displayed`);
       expect(await dataTable.isItemPresent(fileUser)).toBe(true, `${fileUser} not displayed`);