From 9ca398ddcfb96ac1f5e2421d6dec70855e84ccfc Mon Sep 17 00:00:00 2001
From: MichalKinas <113341662+MichalKinas@users.noreply.github.com>
Date: Wed, 4 Sep 2024 19:39:15 +0200
Subject: [PATCH] Another fixes for aca-playwright-shared (#4100)

* Another fixes for aca-playwright-shared

* Add aca-playwright-shared to the build

* Small fix
---
 .github/actions/publish-libs/action.yml                  | 2 +-
 .github/actions/publish-libs/npm-publish.sh              | 2 +-
 .../update-library-versions/update-lib-versions.sh       | 2 +-
 .github/workflows/pull-request.yml                       | 1 +
 projects/aca-playwright-shared/ng-package.json           | 1 +
 projects/aca-playwright-shared/tsconfig.lib.json         | 9 ++++-----
 projects/aca-shared/ng-package.json                      | 1 +
 7 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/.github/actions/publish-libs/action.yml b/.github/actions/publish-libs/action.yml
index 27a8be195..22897776d 100644
--- a/.github/actions/publish-libs/action.yml
+++ b/.github/actions/publish-libs/action.yml
@@ -34,7 +34,7 @@ runs:
 
     - name: Build Libraries
       shell: bash
-      run: npm ci && npm run build
+      run: npm ci && npx nx run-many --target=build
 
     - uses: actions/setup-node@v3
       name: setup GH registry
diff --git a/.github/actions/publish-libs/npm-publish.sh b/.github/actions/publish-libs/npm-publish.sh
index f3c9e666d..d619a3047 100755
--- a/.github/actions/publish-libs/npm-publish.sh
+++ b/.github/actions/publish-libs/npm-publish.sh
@@ -12,7 +12,7 @@ fi
 
 export PROJECTS=(
   'aca-content'
-  'aca-shared',
+  'aca-shared'
   'aca-playwright-shared'
 );
 
diff --git a/.github/actions/update-library-versions/update-lib-versions.sh b/.github/actions/update-library-versions/update-lib-versions.sh
index 4a3dd0748..f9828b392 100755
--- a/.github/actions/update-library-versions/update-lib-versions.sh
+++ b/.github/actions/update-library-versions/update-lib-versions.sh
@@ -11,7 +11,7 @@ fi
 
 export PROJECTS=(
   'aca-content'
-  'aca-shared',
+  'aca-shared'
   'aca-playwright-shared'
 );
 
diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml
index ef3cb905c..a1fcdaea5 100644
--- a/.github/workflows/pull-request.yml
+++ b/.github/workflows/pull-request.yml
@@ -67,6 +67,7 @@ jobs:
           cache: 'npm'
       - uses: ./.github/actions/before-install
       - run: npm ci
+      - run: npx nx build aca-playwright-shared
       - run: npm run build -- $BUILD_OPTS
 
       - name: dist cache
diff --git a/projects/aca-playwright-shared/ng-package.json b/projects/aca-playwright-shared/ng-package.json
index 5f1c388c2..e8b2af3a5 100644
--- a/projects/aca-playwright-shared/ng-package.json
+++ b/projects/aca-playwright-shared/ng-package.json
@@ -1,4 +1,5 @@
 {
+  "$schema": "../../node_modules/ng-packagr/ng-package.schema.json",
   "dest": "../../dist/@alfresco/aca-playwright-shared",
   "lib": {
     "entryFile": "src/public-api.ts"
diff --git a/projects/aca-playwright-shared/tsconfig.lib.json b/projects/aca-playwright-shared/tsconfig.lib.json
index 6db207fbc..e035678f3 100644
--- a/projects/aca-playwright-shared/tsconfig.lib.json
+++ b/projects/aca-playwright-shared/tsconfig.lib.json
@@ -1,9 +1,8 @@
 {
   "extends": "../../tsconfig.json",
   "compilerOptions": {
-    "outDir": "../../out-tsc/aca-playwright-testing",
-    "target": "es2015",
-    "module": "es2015",
+    "outDir": "../../out-tsc/lib",
+    "target": "es2020",
     "moduleResolution": "node",
     "declaration": true,
     "sourceMap": true,
@@ -12,7 +11,7 @@
     "experimentalDecorators": true,
     "importHelpers": true,
     "types": [],
-    "lib": ["dom", "es2018"]
+    "lib": ["dom", "es2020"]
   },
   "angularCompilerOptions": {
     "skipTemplateCodegen": true,
@@ -21,5 +20,5 @@
     "strictInjectionParameters": true,
     "enableResourceInlining": true
   },
-  "exclude": ["node_modules", "src/test.ts", "**/*.spec.ts"]
+  "exclude": ["test.ts", "**/*.spec.ts"]
 }
diff --git a/projects/aca-shared/ng-package.json b/projects/aca-shared/ng-package.json
index 955ea7b88..5df6da019 100644
--- a/projects/aca-shared/ng-package.json
+++ b/projects/aca-shared/ng-package.json
@@ -1,4 +1,5 @@
 {
+  "$schema": "../../node_modules/ng-packagr/ng-package.schema.json",
   "dest": "../../dist/@alfresco/aca-shared",
   "lib": {
     "entryFile": "src/public-api.ts"