inteligr8/alfresco-content-app
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-content-app.git synced 2025-07-24 17:31:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ACA-2643] Upload new version - refactoring (#1138)

Browse Source 
* refactor upload version effect

* subscriber noop fn

* move logic to subscribe

* tests
This commit is contained in:
Cilibiu Bogdan
2019-06-26 10:33:13 +03:00
committed by Adina Parpalita
parent 9b74063032
commit 9e0e50d57d
2 changed files with 185 additions and 113 deletions
Download Patch File Download Diff File Expand all files Collapse all files

235
src/app/store/effects/upload.effects.spec.ts
View File

@@ -34,13 +34,34 @@ import {
FileUploadCompleteEvent,
FileModel
} from '@alfresco/adf-core';
import { UnlockWriteAction } from '@alfresco/aca-shared/store';
import {
UnlockWriteAction,
SnackbarErrorAction
} from '@alfresco/aca-shared/store';
import { ContentManagementService } from '../../services/content-management.service';
import { of, throwError } from 'rxjs';
function createFileList(fileName, type = 'text/plain') {
const data = new Blob([''], { type });
const arrayOfBlob = new Array<Blob>();
arrayOfBlob.push(data);
const file = new File(arrayOfBlob, fileName);
const files = [file];
const reducer = (dataTransfer, currentFile) => {
dataTransfer.items.add(currentFile);
return dataTransfer;
};
return files.reduce(reducer, new DataTransfer()).files;
}
describe('UploadEffects', () => {
let store: Store<any>;
let uploadService: UploadService;
let effects: UploadEffects;
let zone: NgZone;
let contentManagementService: ContentManagementService;
let uploadVersionInput: HTMLInputElement;
beforeEach(() => {
TestBed.configureTestingModule({
@@ -52,121 +73,165 @@ describe('UploadEffects', () => {
return fn();
});
contentManagementService = TestBed.get(ContentManagementService);
store = TestBed.get(Store);
uploadService = TestBed.get(UploadService);
effects = TestBed.get(UploadEffects);
});
it('should work', () => {
expect(store).toBeDefined();
expect(uploadService).toBeDefined();
expect(effects).toBeDefined();
beforeEach(() => {
uploadVersionInput = document.querySelector('#app-upload-file-version');
});
it('should not upload and unlock file if param not provided', () => {
effects.uploadAndUnlock(null);
expect(zone.run).not.toHaveBeenCalled();
afterEach(() => {
uploadVersionInput.remove();
});
it('should upload the file before unlocking', () => {
const file: any = {};
describe('uploadAndUnlock()', () => {
it('should not upload and unlock file if param not provided', () => {
effects.uploadAndUnlock(null);
expect(zone.run).not.toHaveBeenCalled();
});
spyOn(uploadService, 'addToQueue').and.stub();
spyOn(uploadService, 'uploadFilesInTheQueue').and.stub();
it('should upload the file before unlocking', () => {
const file: any = {};
effects.uploadAndUnlock(file);
spyOn(uploadService, 'addToQueue').and.stub();
spyOn(uploadService, 'uploadFilesInTheQueue').and.stub();
expect(uploadService.addToQueue).toHaveBeenCalled();
expect(uploadService.uploadFilesInTheQueue).toHaveBeenCalled();
});
effects.uploadAndUnlock(file);
it('should dispatch the unlock write action for a locked file', () => {
const file: FileModel = new FileModel(
<File>{ name: 'file1.png', size: 10 },
null,
'file1'
);
expect(uploadService.addToQueue).toHaveBeenCalled();
expect(uploadService.uploadFilesInTheQueue).toHaveBeenCalled();
});
file.data = {
entry: {
id: 'file1',
properties: {
'cm:lockType': 'WRITE_LOCK'
it('should dispatch the unlock write action for a locked file', () => {
const file: FileModel = new FileModel(
<File>{ name: 'file1.png', size: 10 },
null,
'file1'
);
file.data = {
entry: {
id: 'file1',
properties: {
'cm:lockType': 'WRITE_LOCK'
}
}
}
};
};
spyOn(uploadService, 'addToQueue').and.stub();
spyOn(uploadService, 'uploadFilesInTheQueue').and.stub();
spyOn(store, 'dispatch').and.stub();
spyOn(uploadService, 'addToQueue').and.stub();
spyOn(uploadService, 'uploadFilesInTheQueue').and.stub();
spyOn(store, 'dispatch').and.stub();
effects.uploadAndUnlock(file);
uploadService.fileUploadComplete.next(
new FileUploadCompleteEvent(file, 100, file.data)
);
effects.uploadAndUnlock(file);
uploadService.fileUploadComplete.next(
new FileUploadCompleteEvent(file, 100, file.data)
);
expect(store.dispatch).toHaveBeenCalledWith(
new UnlockWriteAction(file.data)
);
});
expect(store.dispatch).toHaveBeenCalledWith(
new UnlockWriteAction(file.data)
);
});
it('should dispatch only one unlock action for a locked file', () => {
const file: FileModel = new FileModel(
<File>{ name: 'file1.png', size: 10 },
null,
'file1'
);
it('should dispatch only one unlock action for a locked file', () => {
const file: FileModel = new FileModel(
<File>{ name: 'file1.png', size: 10 },
null,
'file1'
);
file.data = {
entry: {
id: 'file1',
properties: {
'cm:lockType': 'WRITE_LOCK'
file.data = {
entry: {
id: 'file1',
properties: {
'cm:lockType': 'WRITE_LOCK'
}
}
}
};
};
spyOn(uploadService, 'addToQueue').and.stub();
spyOn(uploadService, 'uploadFilesInTheQueue').and.stub();
spyOn(store, 'dispatch').and.stub();
spyOn(uploadService, 'addToQueue').and.stub();
spyOn(uploadService, 'uploadFilesInTheQueue').and.stub();
spyOn(store, 'dispatch').and.stub();
effects.uploadAndUnlock(file);
effects.uploadAndUnlock(file);
const completeEvent = new FileUploadCompleteEvent(file, 100, file.data);
uploadService.fileUploadComplete.next(completeEvent);
uploadService.fileUploadComplete.next(completeEvent);
uploadService.fileUploadComplete.next(completeEvent);
const completeEvent = new FileUploadCompleteEvent(file, 100, file.data);
uploadService.fileUploadComplete.next(completeEvent);
uploadService.fileUploadComplete.next(completeEvent);
uploadService.fileUploadComplete.next(completeEvent);
expect(store.dispatch).toHaveBeenCalledWith(
new UnlockWriteAction(file.data)
);
expect(store.dispatch).toHaveBeenCalledWith(
new UnlockWriteAction(file.data)
);
expect(store.dispatch).toHaveBeenCalledTimes(1);
expect(store.dispatch).toHaveBeenCalledTimes(1);
});
it('should dispatch no actions if file is not locked', () => {
const file: FileModel = new FileModel(
<File>{ name: 'file1.png', size: 10 },
null,
'file1'
);
file.data = {
entry: {
id: 'file1',
properties: {}
}
};
spyOn(uploadService, 'addToQueue').and.stub();
spyOn(uploadService, 'uploadFilesInTheQueue').and.stub();
spyOn(store, 'dispatch').and.stub();
effects.uploadAndUnlock(file);
uploadService.fileUploadComplete.next(
new FileUploadCompleteEvent(file, 100, file.data)
);
expect(store.dispatch).not.toHaveBeenCalled();
});
});
it('should dispatch no actions if file is not locked', () => {
const file: FileModel = new FileModel(
<File>{ name: 'file1.png', size: 10 },
null,
'file1'
);
describe('upload file version', () => {
beforeEach(() => {
const dialog = { afterClosed: () => of({}) };
spyOn(contentManagementService, 'versionUploadDialog').and.returnValue(
dialog
);
spyOn(effects, 'uploadAndUnlock').and.stub();
});
file.data = {
entry: {
id: 'file1',
properties: {}
}
};
it('should upload file', () => {
spyOn(contentManagementService, 'getNodeInfo').and.returnValue(
of({
entry: {
id: 'file1',
properties: {}
}
})
);
spyOn(uploadService, 'addToQueue').and.stub();
spyOn(uploadService, 'uploadFilesInTheQueue').and.stub();
spyOn(store, 'dispatch').and.stub();
uploadVersionInput.files = createFileList('bogus.txt');
uploadVersionInput.dispatchEvent(new CustomEvent('change'));
expect(effects.uploadAndUnlock).toHaveBeenCalled();
});
effects.uploadAndUnlock(file);
uploadService.fileUploadComplete.next(
new FileUploadCompleteEvent(file, 100, file.data)
);
it('should raise error when getNodeInfo fails', () => {
spyOn(store, 'dispatch').and.stub();
spyOn(contentManagementService, 'getNodeInfo').and.returnValue(
throwError('error')
);
expect(store.dispatch).not.toHaveBeenCalled();
uploadVersionInput.files = createFileList('bogus.txt');
uploadVersionInput.dispatchEvent(new CustomEvent('change'));
expect(store.dispatch).toHaveBeenCalledWith(
new SnackbarErrorAction('VERSION.ERROR.GENERIC')
);
expect(effects.uploadAndUnlock).not.toHaveBeenCalled();
});
});
});