stabilise unit tests (#1878)

* cleanup async usage

* cleanup async usage

* fix library favorite tests and code
This commit is contained in:
Denys Vuika
2020-12-11 13:01:31 +00:00
committed by GitHub
parent 72cc4f705f
commit b71e1530d1
10 changed files with 153 additions and 183 deletions

View File

@@ -28,7 +28,6 @@ import { AppTestingModule } from '../../testing/app-testing.module';
import { ContextMenuComponent } from './context-menu.component';
import { ContextMenuModule } from './context-menu.module';
import { ContextMenuOverlayRef } from './context-menu-overlay';
import { TranslateModule, TranslateLoader, TranslateFakeLoader } from '@ngx-translate/core';
import { ContentActionType } from '@alfresco/adf-extensions';
import { of } from 'rxjs';
@@ -52,15 +51,8 @@ describe('ContextMenuComponent', () => {
beforeEach(() => {
TestBed.configureTestingModule({
imports: [
AppTestingModule,
ContextMenuModule,
TranslateModule.forRoot({
loader: { provide: TranslateLoader, useClass: TranslateFakeLoader }
})
],
imports: [ContextMenuModule, AppTestingModule],
providers: [
AppExtensionService,
{
provide: ContextMenuOverlayRef,
useValue: {
@@ -103,11 +95,11 @@ describe('ContextMenuComponent', () => {
expect(contextMenuElements[0].querySelector('span').innerText).toBe(contextItem.title);
}));
it('should run action with provided action id', fakeAsync(() => {
it('should run action with provided action id', () => {
spyOn(extensionsService, 'runActionById');
component.runAction(contextItem.actions.click);
expect(extensionsService.runActionById).toHaveBeenCalledWith(contextItem.actions.click);
}));
});
});