[ACA-1928] e2e improvements - part1 (#883)

* refactor Mark as favourite tests
rename method to be more clear
create separate methods for some checks and actions

* forgot some changes

* refactor delete-undo tests

* some more refactoring

* fix

e2e/pages/browsing-page.ts

@@ -39,6 +39,9 @@ export class BrowsingPage extends Page {
     await this.header.userInfo.signOut();
   }
 
+  async isSnackBarPresent() {
+    return this.snackBar.isPresent();
+  }
 
   // helper methods
 

e2e/pages/page.ts

@@ -108,4 +108,10 @@ export abstract class Page {
     return await this.genericErrorTitle.getText();
   }
 
+
+  async isUndoActionPresent() {
+    const message = await this.snackBar.getAttribute('innerText');
+    return message.includes('Undo');
+  }
+
 }

e2e/pages/search-results-page.ts

@@ -23,9 +23,8 @@
  * along with Alfresco. If not, see <http://www.gnu.org/licenses/>.
  */
 
-import { browser, ElementFinder, by, ExpectedConditions as EC } from 'protractor';
+import { browser, ElementFinder } from 'protractor';
 import { BrowsingPage } from './browsing-page';
-import { BROWSER_WAIT_TIMEOUT } from '../configs';
 
 export class SearchResultsPage extends BrowsingPage {
 
@@ -51,5 +50,8 @@ export class SearchResultsPage extends BrowsingPage {
 
   root: ElementFinder = browser.$(SearchResultsPage.selectors.root);
 
+  waitForResults() {
+    return this.dataTable.waitForBody();
+  }
 
 }