fix perfomance issues and warnings in app (#2487)

app/src/app/components/info-drawer/info.drawer.module.ts

@@ -38,10 +38,6 @@ import { VersionsTabComponent } from './versions-tab/versions-tab.component';
 import { A11yModule } from '@angular/cdk/a11y';
 import { SharedInfoDrawerModule } from '@alfresco/aca-shared';
 
-export function components() {
-  return [MetadataTabComponent, CommentsTabComponent, VersionsTabComponent, LibraryMetadataTabComponent, LibraryMetadataFormComponent];
-}
-
 @NgModule({
   imports: [
     CommonModule,
@@ -55,7 +51,14 @@ export function components() {
     A11yModule,
     SharedInfoDrawerModule
   ],
-  declarations: [...components()],
-  exports: [...components(), SharedInfoDrawerModule]
+  declarations: [MetadataTabComponent, CommentsTabComponent, VersionsTabComponent, LibraryMetadataTabComponent, LibraryMetadataFormComponent],
+  exports: [
+    MetadataTabComponent,
+    CommentsTabComponent,
+    VersionsTabComponent,
+    LibraryMetadataTabComponent,
+    LibraryMetadataFormComponent,
+    SharedInfoDrawerModule
+  ]
 })
 export class AppInfoDrawerModule {}

app/src/app/components/toolbar/toolbar.module.ts

@@ -39,8 +39,9 @@ import { ViewNodeComponent } from './view-node/view-node.component';
 import { AppCommonModule } from '../common/common.module';
 import { SharedToolbarModule } from '@alfresco/aca-shared';
 
-export function components() {
-  return [
+@NgModule({
+  imports: [CommonModule, CoreModule.forChild(), AppCommonModule, ExtensionsModule, SharedToolbarModule, DirectivesModule],
+  declarations: [
     DocumentDisplayModeComponent,
     ToggleFavoriteComponent,
     ToggleInfoDrawerComponent,
@@ -49,12 +50,17 @@ export function components() {
     ToggleFavoriteLibraryComponent,
     ToggleEditOfflineComponent,
     ViewNodeComponent
-  ];
-}
-
-@NgModule({
-  imports: [CommonModule, CoreModule.forChild(), AppCommonModule, ExtensionsModule, SharedToolbarModule, DirectivesModule],
-  declarations: components(),
-  exports: [components(), SharedToolbarModule]
+  ],
+  exports: [
+    DocumentDisplayModeComponent,
+    ToggleFavoriteComponent,
+    ToggleInfoDrawerComponent,
+    ToggleJoinLibraryButtonComponent,
+    ToggleJoinLibraryMenuComponent,
+    ToggleFavoriteLibraryComponent,
+    ToggleEditOfflineComponent,
+    ViewNodeComponent,
+    SharedToolbarModule
+  ]
 })
 export class AppToolbarModule {}

app/src/app/extensions/core.extensions.module.ts

@@ -55,6 +55,7 @@ import { LogoutComponent } from '../components/common/logout/logout.component';
 import { AppExtensionService, ExtensionsDataLoaderGuard } from '@alfresco/aca-shared';
 import { PreviewComponent } from '../components/preview/preview.component';
 
+// eslint-disable-next-line prefer-arrow/prefer-arrow-functions
 export function setupExtensions(service: AppExtensionService): () => void {
   return () => service.load();
 }