cleanup GitHub actions (#3071)

* cleanup GHA

* remove unused parameters

* consolidate actions, improve readability

* remove unused files

* restore fetch depth

.github/workflows/aca-upstream.yml

@@ -24,25 +24,24 @@ jobs:
     name: Trigger ACA Upstream
     runs-on: ubuntu-latest
     steps:
-        - name: Checkout Repository
-          uses: actions/checkout@v3
-          with:
-            fetch-depth: 0
+      - name: Checkout Repository
+        uses: actions/checkout@v3
 
-        - name: Setup Node.js
-          uses: actions/setup-node@v3
-          with:
-            node-version-file: '.nvmrc'
-            cache: 'npm'
+      - name: Setup Node.js
+        uses: actions/setup-node@v3
+        with:
+          node-version-file: '.nvmrc'
+          cache: 'npm'
 
-        - uses: Alfresco/alfresco-build-tools/.github/actions/configure-git-author@v1.35.0
-          with:
-            username: ${{ vars.BOT_GITHUB_USERNAME }}
-            email: ${{ vars.BOT_GITHUB_EMAIL }}
-            global: true
+      - name: Configure Git Author
+        uses: Alfresco/alfresco-build-tools/.github/actions/configure-git-author@v1.35.0
+        with:
+          username: ${{ vars.BOT_GITHUB_USERNAME }}
+          email: ${{ vars.BOT_GITHUB_EMAIL }}
+          global: true
 
-        - name: Trigger Upstream
-          shell: bash
-          run: |
-            npm install github-api
-            ./scripts/gh/update/update-project.sh -p $GH_BUILD_NUMBER -t $GH_TOKEN -v alpha -c $GH_COMMIT -r ${{ inputs.repo_to_update || 'alfresco-applications' }}
+      - name: Trigger Upstream
+        shell: bash
+        run: |
+          npm install github-api
+          ./scripts/gh/update/update-project.sh -p $GH_BUILD_NUMBER -t $GH_TOKEN -v alpha -c $GH_COMMIT -r ${{ inputs.repo_to_update || 'alfresco-applications' }}

.github/workflows/pull-request.yml

@@ -166,11 +166,6 @@ jobs:
         with:
           options: "--suite=${{ matrix.e2e-suites.name }}"
       - uses: ./.github/actions/after-e2e
-        with:
-          id: ${{ matrix.e2e-suites.id }}
-          aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
-          aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
-          aws-region: ${{ env.AWS_REGION }}
 
   e2es-playwright:
     needs: [lint, build, unit-tests]
@@ -205,11 +200,6 @@ jobs:
           options: "e2e/playwright/tests/folder-rules/playwright.config.ts"
           test-runner: playwright
       - uses: ./.github/actions/after-e2e
-        with:
-          id: 15
-          aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
-          aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
-          aws-region: ${{ env.AWS_REGION }}
 
   finalize:
     if: ${{ always() }}
@@ -217,12 +207,6 @@ jobs:
     name: 'Finalize'
     runs-on: ubuntu-latest
     steps:
-      - name: Checkout
-        uses: actions/checkout@v3
-        with:
-          fetch-depth: 2
-      - uses: Alfresco/alfresco-build-tools/.github/actions/get-commit-message@v1.35.0
-
       - name: Check previous jobs status
         if: >-
             ${{
@@ -231,6 +215,14 @@ jobs:
             }}
         run: exit 1
 
+      - name: Checkout
+        uses: actions/checkout@v3
+        with:
+          fetch-depth: 2
+
+      - name: Extract commit message
+        uses: Alfresco/alfresco-build-tools/.github/actions/get-commit-message@v1.35.0
+
       - name: Check ADF link
         shell: bash
         run: |

.github/workflows/rebase.yml

@@ -1,18 +1,21 @@
-on: 
+name: Automatic Rebase
+
+on:
   issue_comment:
     types: [created]
-name: Automatic Rebase
+
 jobs:
   rebase:
     name: Rebase
     if: github.event.issue.pull_request != '' && contains(github.event.comment.body, '/rebase')
     runs-on: ubuntu-latest
     steps:
-    - name: Checkout the latest code
-      uses: actions/checkout@v2
-      with:
-        fetch-depth: 0
-    - name: Automatic Rebase
-      uses: cirrus-actions/rebase@1.3.1
-      env:
-        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      - name: Checkout the latest code
+        uses: actions/checkout@v2
+        with:
+          fetch-depth: 0
+
+      - name: Automatic Rebase
+        uses: cirrus-actions/rebase@1.3.1
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/release.yml

@@ -120,21 +120,15 @@ jobs:
         uses: actions/checkout@v3
         with:
           fetch-depth: 2
+
       - name: Setup node
         uses: actions/setup-node@v3
         with:
           node-version-file: '.nvmrc'
           cache: 'npm'
+
       - uses: ./.github/actions/setup
-      - name: check PR number
-        id: action
-        uses: kamatama41/get-pr-number-action@v0
-        with:
-          github_token: ${{ secrets.GITHUB_TOKEN }}
-      - name: save PR number
-        shell: bash
-        run: |
-          echo "PR_NUMBER=${{ steps.action.outputs.number }}" >> $GITHUB_ENV
+
       - name: publish
         uses: ./.github/actions/publish-libs
         with: