[ACS-8956] Add new ESLint rule for self-closing tags (#4211)

This commit is contained in:
MichalKinas
2024-10-31 09:54:23 +01:00
committed by GitHub
parent d25c08a2c5
commit cacc4149fa
60 changed files with 200 additions and 256 deletions

View File

@@ -1,12 +1,12 @@
<div *ngIf="isLoading">
<mat-progress-bar mode="indeterminate" [attr.aria-label]="'APP.INFO_DRAWER.DATA_LOADING' | translate"></mat-progress-bar>
<mat-progress-bar mode="indeterminate" [attr.aria-label]="'APP.INFO_DRAWER.DATA_LOADING' | translate" />
</div>
<ng-container *ngIf="!isLoading && !!displayNode">
<adf-info-drawer [icon]="icon" [title]="node?.entry?.name || 'APP.INFO_DRAWER.TITLE'" cdkTrapFocusAutoCapture>
<aca-toolbar [items]="actions" info-drawer-buttons></aca-toolbar>
<aca-toolbar [items]="actions" info-drawer-buttons />
<adf-info-drawer-tab *ngFor="let tab of tabs" [icon]="tab.icon" [label]="tab.title">
<adf-dynamic-tab [node]="$any(displayNode)" [id]="tab.component" [attr.data-automation-id]="tab.component"> </adf-dynamic-tab>
<adf-dynamic-tab [node]="$any(displayNode)" [id]="tab.component" [attr.data-automation-id]="tab.component" />
</adf-info-drawer-tab>
</adf-info-drawer>
</ng-container>

View File

@@ -1,19 +1,19 @@
<ng-container [ngSwitch]="actionRef.type">
<div *ngSwitchCase="'default'">
<app-toolbar-button [type]="type" [actionRef]="actionRef" [color]="color"> </app-toolbar-button>
<app-toolbar-button [type]="type" [actionRef]="actionRef" [color]="color" />
</div>
<div *ngSwitchCase="'button'">
<app-toolbar-button [type]="data?.buttonType || type" [actionRef]="actionRef" [color]="color" [data]="actionRef.data"> </app-toolbar-button>
<app-toolbar-button [type]="data?.buttonType || type" [actionRef]="actionRef" [color]="color" [data]="actionRef.data" />
</div>
<div *ngSwitchCase="'separator'" [id]="actionRef.id" class="aca-toolbar-divider"></div>
<ng-container *ngSwitchCase="'menu'">
<app-toolbar-menu [actionRef]="actionRef" [color]="color" [data]="actionRef.data"></app-toolbar-menu>
<app-toolbar-menu [actionRef]="actionRef" [color]="color" [data]="actionRef.data" />
</ng-container>
<div *ngSwitchCase="'custom'">
<adf-dynamic-component [data]="actionRef.data" [id]="actionRef.component"></adf-dynamic-component>
<adf-dynamic-component [data]="actionRef.data" [id]="actionRef.component" />
</div>
</ng-container>

View File

@@ -9,7 +9,7 @@
[disabled]="actionRef.disabled"
(click)="runAction()"
>
<adf-icon [value]="actionRef.icon"></adf-icon>
<adf-icon [value]="actionRef.icon" />
</button>
</ng-container>
@@ -42,6 +42,6 @@
</ng-container>
<ng-container *ngSwitchCase="'menu-item'">
<app-toolbar-menu-item [actionRef]="actionRef"></app-toolbar-menu-item>
<app-toolbar-menu-item [actionRef]="actionRef" />
</ng-container>
</ng-container>

View File

@@ -1,23 +1,23 @@
<ng-container [ngSwitch]="actionRef.type">
<ng-container *ngSwitchCase="'menu'">
<button [id]="actionRef.id" mat-menu-item role="menuitem" tabindex="0" [disabled]="actionRef.disabled" [matMenuTriggerFor]="childMenu">
<adf-icon [value]="actionRef.icon"></adf-icon>
<adf-icon [value]="actionRef.icon" />
<span data-automation-id="menu-item-title">{{ actionRef.title | translate }}</span>
</button>
<mat-menu #childMenu="matMenu" class="app-create-menu__sub-menu">
<ng-container *ngFor="let child of actionRef.children; trackBy: trackByActionId">
<app-toolbar-menu-item [actionRef]="child"></app-toolbar-menu-item>
<app-toolbar-menu-item [actionRef]="child" />
</ng-container>
</mat-menu>
</ng-container>
<ng-container *ngSwitchCase="'separator'">
<mat-divider></mat-divider>
<mat-divider />
</ng-container>
<ng-container *ngSwitchCase="'custom'">
<adf-dynamic-component [id]="actionRef.component"></adf-dynamic-component>
<adf-dynamic-component [id]="actionRef.component" />
</ng-container>
<ng-container *ngSwitchDefault>
@@ -31,7 +31,7 @@
[attr.title]="(actionRef.disabled ? actionRef['description-disabled'] : actionRef.description || actionRef.title) | translate"
(click)="runAction()"
>
<adf-icon [value]="actionRef.icon" class="app-toolbar-menu-item--icon"></adf-icon>
<adf-icon [value]="actionRef.icon" class="app-toolbar-menu-item--icon" />
<span data-automation-id="menu-item-title">{{ actionRef.title | translate }}</span>
</button>
</ng-container>

View File

@@ -55,7 +55,7 @@
[disabled]="actionRef.disabled"
#matTrigger="matMenuTrigger"
>
<adf-icon *ngIf="actionRef.icon" [value]="actionRef.icon"></adf-icon>
<adf-icon *ngIf="actionRef.icon" [value]="actionRef.icon" />
</button>
</ng-container>
</ng-container>
@@ -64,10 +64,10 @@
<ng-container *ngFor="let child of actionRef.children; trackBy: trackByActionId">
<ng-container [ngSwitch]="child.type">
<ng-container *ngSwitchCase="'custom'">
<adf-dynamic-component [id]="child.component" [data]="child.data"></adf-dynamic-component>
<adf-dynamic-component [id]="child.component" [data]="child.data" />
</ng-container>
<ng-container *ngSwitchDefault>
<app-toolbar-menu-item [actionRef]="child" [menuId]="actionRef.id"></app-toolbar-menu-item>
<app-toolbar-menu-item [actionRef]="child" [menuId]="actionRef.id" />
</ng-container>
</ng-container>
</ng-container>

View File

@@ -1,5 +1,5 @@
<mat-toolbar class="aca-toolbar">
<ng-container *ngFor="let item of items; trackBy: trackByActionId">
<aca-toolbar-action [actionRef]="item"></aca-toolbar-action>
<aca-toolbar-action [actionRef]="item" />
</ng-container>
</mat-toolbar>