[ACS-12831] deleted Page from Api files (#5391)

This commit is contained in:
Adam Świderski
2026-09-10 14:02:01 +02:00
committed by GitHub
parent 4369a16c5d
commit cc5df97c37
19 changed files with 56 additions and 56 deletions
@@ -23,12 +23,12 @@
*/
import { expect } from '@playwright/test';
import { ApiClientFactory, Utils, test, TrashcanApi, NodesApi, FavoritesPageApi, SharedLinksApi } from '@alfresco/aca-playwright-shared';
import { ApiClientFactory, Utils, test, TrashcanApi, NodesApi, FavoritesApi, SharedLinksApi } from '@alfresco/aca-playwright-shared';
test.describe('Mark items as favorites', () => {
let trashcanApi: TrashcanApi;
let nodesApi: NodesApi;
let favoritesApi: FavoritesPageApi;
let favoritesApi: FavoritesApi;
let sharedApi: SharedLinksApi;
const username = `user-${Utils.random()}`;
@@ -65,7 +65,7 @@ test.describe('Mark items as favorites', () => {
await apiClientFactory.createUser({ username });
trashcanApi = await TrashcanApi.initialize(username, username);
nodesApi = await NodesApi.initialize(username, username);
favoritesApi = await FavoritesPageApi.initialize(username, username);
favoritesApi = await FavoritesApi.initialize(username, username);
sharedApi = await SharedLinksApi.initialize(username, username);
parentId = (await nodesApi.createFolder(parent)).entry.id;
@@ -28,7 +28,7 @@ import {
Utils,
test,
TrashcanApi,
FavoritesPageApi,
FavoritesApi,
NodesApi,
FileActionsApi,
SitesApi,
@@ -41,7 +41,7 @@ test.describe('Info Drawer - Comments', () => {
let nodesApi: NodesApi;
let trashcanApi: TrashcanApi;
let fileActionsApi: FileActionsApi;
let favoritesActions: FavoritesPageApi;
let favoritesActions: FavoritesApi;
const username = `user-e2e-${Utils.random()}`;
const commentText = `comment-e2e-${Utils.random()}`;
@@ -51,7 +51,7 @@ test.describe('Info Drawer - Comments', () => {
await apiClientFactory.createUser({ username });
nodesApi = await NodesApi.initialize(username, username);
trashcanApi = await TrashcanApi.initialize(username, username);
favoritesActions = await FavoritesPageApi.initialize(username, username);
favoritesActions = await FavoritesApi.initialize(username, username);
fileActionsApi = await FileActionsApi.initialize(username, username);
} catch (error) {
console.error(`beforeAll failed : ${error}`);
@@ -25,7 +25,7 @@
import {
ApiClientFactory,
cleanupRepositoryTestData,
FavoritesPageApi,
FavoritesApi,
NodesApi,
RepositoryTestData,
seedRepositoryTestData,
@@ -65,14 +65,14 @@ test.describe('Repository — Info drawer expand routing', () => {
test.describe('signed in as admin', () => {
let userNodesApi: NodesApi;
let trashcanApi: TrashcanApi;
let favoritesApi: FavoritesPageApi;
let favoritesApi: FavoritesApi;
let testData!: RepositoryTestData;
test.beforeAll(async () => {
try {
userNodesApi = await NodesApi.initialize('admin');
trashcanApi = await TrashcanApi.initialize('admin');
favoritesApi = await FavoritesPageApi.initialize('admin');
favoritesApi = await FavoritesApi.initialize('admin');
testData = await seedRepositoryTestData({ userNodesApi, adminNodesApi: userNodesApi });
await favoritesApi.addFavoriteById('file', testData.repoFile.id);
@@ -29,7 +29,7 @@ import {
test,
SitesApi,
TrashcanApi,
FavoritesPageApi,
FavoritesApi,
FavoritesLibrariesPage,
timeouts
} from '@alfresco/aca-playwright-shared';
@@ -58,7 +58,7 @@ test.describe('Library actions ', () => {
let adminSitesApi: SitesApi;
let user2SitesApi: SitesApi;
let user2FavoritesApi: FavoritesPageApi;
let user2FavoritesApi: FavoritesApi;
let user2TrashcanApi: TrashcanApi;
function getRoleCellValue(page: FavoritesLibrariesPage, libraryName: string, role: string): Locator {
@@ -73,7 +73,7 @@ test.describe('Library actions ', () => {
adminSitesApi = await SitesApi.initialize('admin');
user2SitesApi = await SitesApi.initialize(username2, username2);
user2FavoritesApi = await FavoritesPageApi.initialize(username2, username2);
user2FavoritesApi = await FavoritesApi.initialize(username2, username2);
user2TrashcanApi = await TrashcanApi.initialize(username2, username2);
} catch (error) {
const favoriteLibrariesActionsBeforeAllErrorMessage = `Favorite libraries actions beforeAll failed : ${JSON.stringify(error)}`;
@@ -23,7 +23,7 @@
*/
import { expect, Locator } from '@playwright/test';
import { Utils, ApiClientFactory, test, SitesApi, TrashcanApi, MyLibrariesPage, FavoritesPageApi, timeouts } from '@alfresco/aca-playwright-shared';
import { Utils, ApiClientFactory, test, SitesApi, TrashcanApi, MyLibrariesPage, FavoritesApi, timeouts } from '@alfresco/aca-playwright-shared';
import { Site } from '@alfresco/js-api';
test.describe('Library actions ', () => {
@@ -52,7 +52,7 @@ test.describe('Library actions ', () => {
let adminSitesApi: SitesApi;
let user1SitesApi: SitesApi;
let user2SitesApi: SitesApi;
let user2FavoritesApi: FavoritesPageApi;
let user2FavoritesApi: FavoritesApi;
let user2TrashcanApi: TrashcanApi;
function getRoleCellValue(page: MyLibrariesPage, libraryName: string, role = managerRole): Locator {
@@ -69,7 +69,7 @@ test.describe('Library actions ', () => {
adminSitesApi = await SitesApi.initialize('admin');
user1SitesApi = await SitesApi.initialize(username1, username1);
user2SitesApi = await SitesApi.initialize(username2, username2);
user2FavoritesApi = await FavoritesPageApi.initialize(username2, username2);
user2FavoritesApi = await FavoritesApi.initialize(username2, username2);
user2TrashcanApi = await TrashcanApi.initialize(username2, username2);
} catch (error) {
const myLibrariesActionsBeforeAllErrorMessage = `My libraries actions beforeAll failed : ${JSON.stringify(error)}`;
@@ -23,7 +23,7 @@
*/
import { expect, Locator } from '@playwright/test';
import { Utils, ApiClientFactory, test, SitesApi, TrashcanApi, FavoritesPageApi, SearchPage, timeouts } from '@alfresco/aca-playwright-shared';
import { Utils, ApiClientFactory, test, SitesApi, TrashcanApi, FavoritesApi, SearchPage, timeouts } from '@alfresco/aca-playwright-shared';
import { Site } from '@alfresco/js-api';
test.describe('Library actions ', () => {
@@ -192,7 +192,7 @@ test.describe('Library actions ', () => {
test.describe('[XAT-5144] Remove a library from favorites - from Search Results', () => {
test.beforeAll(async () => {
const user2FavoritesApi = await FavoritesPageApi.initialize(username2, username2);
const user2FavoritesApi = await FavoritesApi.initialize(username2, username2);
user2Lib5144Id = (await user2SitesApi.createSite(user2Lib5144)).entry.id;
await user2FavoritesApi.addFavoriteById('site', user2Lib5144Id);
});
@@ -23,14 +23,14 @@
*/
import { expect } from '@playwright/test';
import { ApiClientFactory, NodesApi, Utils, test, SitesApi, FavoritesPageApi, timeouts, TrashcanApi } from '@alfresco/aca-playwright-shared';
import { ApiClientFactory, NodesApi, Utils, test, SitesApi, FavoritesApi, timeouts, TrashcanApi } from '@alfresco/aca-playwright-shared';
import { Site } from '@alfresco/js-api';
test.describe('Favorites Files', () => {
let nodesApi: NodesApi;
let trashcanApi: TrashcanApi;
let siteActionsAdmin: SitesApi;
let favoritesActions: FavoritesPageApi;
let favoritesActions: FavoritesApi;
let nodesApiAdmin: NodesApi;
let apiClientFactory: ApiClientFactory;
let parentId: string;
@@ -53,7 +53,7 @@ test.describe('Favorites Files', () => {
trashcanApi = await TrashcanApi.initialize(username, username);
nodesApiAdmin = await NodesApi.initialize('admin');
siteActionsAdmin = await SitesApi.initialize('admin');
favoritesActions = await FavoritesPageApi.initialize(username, username);
favoritesActions = await FavoritesApi.initialize(username, username);
parentId = (await nodesApi.createFolder(parentFolder)).entry.id;
} catch (error) {
@@ -23,7 +23,7 @@
*/
import { expect } from '@playwright/test';
import { ApiClientFactory, FavoritesPageApi, SitesApi, Utils, test, timeouts } from '@alfresco/aca-playwright-shared';
import { ApiClientFactory, FavoritesApi, SitesApi, Utils, test, timeouts } from '@alfresco/aca-playwright-shared';
import { Site } from '@alfresco/js-api';
test.describe('File Libraries', () => {
@@ -53,7 +53,7 @@ test.describe('File Libraries', () => {
await apiClientFactory.createUser({ username });
siteActionsAdmin = await SitesApi.initialize('admin');
siteActionsUser = await SitesApi.initialize(username, username);
const favoritesActions = await FavoritesPageApi.initialize(username, username);
const favoritesActions = await FavoritesApi.initialize(username, username);
const siteDescription = 'my site description';
await siteActionsUser.createSite(userSitePublic, Site.VisibilityEnum.PUBLIC);
await siteActionsUser.createSite(userSiteModerated, Site.VisibilityEnum.MODERATED, siteDescription);
@@ -25,7 +25,7 @@
import { expect } from '@playwright/test';
import {
ApiClientFactory,
FavoritesPageApi,
FavoritesApi,
FileActionsApi,
LoginPage,
NodesApi,
@@ -60,7 +60,7 @@ test.describe('Special permissions', () => {
test.beforeAll(async () => {
test.setTimeout(timeouts.webServer);
const userFavoritesApi = await FavoritesPageApi.initialize(username, username);
const userFavoritesApi = await FavoritesApi.initialize(username, username);
const userFileActionApi = await FileActionsApi.initialize(username, username);
siteApiAdmin = await SitesApi.initialize('admin');
const nodeApiAdmin = await NodesApi.initialize('admin');
@@ -141,7 +141,7 @@ test.describe('Special permissions', () => {
test.beforeAll(async () => {
test.setTimeout(timeouts.webServer);
const userFavoritesApi = await FavoritesPageApi.initialize(username, username);
const userFavoritesApi = await FavoritesApi.initialize(username, username);
const userShareActionApi = await SharedLinksApi.initialize(username, username);
const userNodeActionApi = await NodesApi.initialize(username, username);
adminSiteApiActions = await SitesApi.initialize('admin');
@@ -25,7 +25,7 @@
import { expect } from '@playwright/test';
import {
ApiClientFactory,
FavoritesPageApi,
FavoritesApi,
FileActionsApi,
NodesApi,
PersonalFilesPage,
@@ -76,7 +76,7 @@ test.describe('Remember sorting', () => {
await apiClientFactory.createUser({ username: user2 });
const fileActionUser1 = await FileActionsApi.initialize(user1, user1);
const fileActionUser2 = await FileActionsApi.initialize(user2, user2);
const favoritesActions = await FavoritesPageApi.initialize(user1, user1);
const favoritesActions = await FavoritesApi.initialize(user1, user1);
nodeActionUser1 = await NodesApi.initialize(user1, user1);
const filesIdsUser1: { [key: string]: string } = {};
const filesIdsUser2: { [key: string]: string } = {};
@@ -25,7 +25,7 @@
import {
ApiClientFactory,
DataTableComponent,
FavoritesPageApi,
FavoritesApi,
NodesApi,
PaginationComponent,
SearchApi,
@@ -101,7 +101,7 @@ test.describe('Pagination on multiple pages : ', () => {
const username = `user-${random}`;
let nodesApi: NodesApi;
let trashcanApi: TrashcanApi;
let favoritesApi: FavoritesPageApi;
let favoritesApi: FavoritesApi;
let searchApi: SearchApi;
const parent = `parent-multi-${random}`;
@@ -116,7 +116,7 @@ test.describe('Pagination on multiple pages : ', () => {
await apiClientFactory.createUser({ username });
nodesApi = await NodesApi.initialize(username, username);
trashcanApi = await TrashcanApi.initialize(username, username);
favoritesApi = await FavoritesPageApi.initialize(username, username);
favoritesApi = await FavoritesApi.initialize(username, username);
searchApi = await SearchApi.initialize(username, username);
const files = Array(51)
@@ -24,7 +24,7 @@
import {
ApiClientFactory,
FavoritesPageApi,
FavoritesApi,
FolderActionsData,
PersonalFilesPage,
NodesApi,
@@ -64,7 +64,7 @@ test.describe('Folders - available actions : ', () => {
await apiClientFactory.setUpAcaBackend('admin');
await apiClientFactory.createUser({ username });
nodesApi = await NodesApi.initialize(username, username);
const favoritesActions = await FavoritesPageApi.initialize(username, username);
const favoritesActions = await FavoritesApi.initialize(username, username);
trashcanApi = await TrashcanApi.initialize(username, username);
parentId = (await nodesApi.createFolder(parentName)).entry.id;
await nodesApi.createFile(testData.file.name, parentId);
@@ -27,7 +27,7 @@ import { viewerTests } from './viewer';
import { collaboratorTests, filesLockedByCurrentUser, filesLockedByOtherUser } from './other-permissions';
import {
ApiClientFactory,
FavoritesPageApi,
FavoritesApi,
FileActionsApi,
TEST_FILES,
NodesApi,
@@ -65,7 +65,7 @@ test.describe('Special permissions : ', () => {
let managerSiteActions: SitesApi;
let managerFileActions: FileActionsApi;
let managerSearchActions: SearchApi;
let consumerFavoritesActions: FavoritesPageApi;
let consumerFavoritesActions: FavoritesApi;
let consumerShareActions: SharedLinksApi;
test.beforeAll(async () => {
@@ -78,7 +78,7 @@ test.describe('Special permissions : ', () => {
managerSiteActions = await SitesApi.initialize(userManager, userManager);
managerFileActions = await FileActionsApi.initialize(userManager, userManager);
managerSearchActions = await SearchApi.initialize(userManager, userManager);
consumerFavoritesActions = await FavoritesPageApi.initialize(userConsumer, userConsumer);
consumerFavoritesActions = await FavoritesApi.initialize(userConsumer, userConsumer);
consumerShareActions = await SharedLinksApi.initialize(userConsumer, userConsumer);
const consumerFavoritesTotalItems = await consumerFavoritesActions.getFavoritesTotalItems(userConsumer);
@@ -162,7 +162,7 @@ test.describe('Special permissions : ', () => {
let managerFileActions: FileActionsApi;
let managerSearchActions: SearchApi;
let managerShareActions: SharedLinksApi;
let collaboratorFavoritesActions: FavoritesPageApi;
let collaboratorFavoritesActions: FavoritesApi;
test.beforeAll(async () => {
test.setTimeout(timeouts.extendedLongTest);
@@ -175,7 +175,7 @@ test.describe('Special permissions : ', () => {
managerFileActions = await FileActionsApi.initialize(userManager, userManager);
managerSearchActions = await SearchApi.initialize(userManager, userManager);
managerShareActions = await SharedLinksApi.initialize(userManager, userManager);
collaboratorFavoritesActions = await FavoritesPageApi.initialize(userCollaborator, userCollaborator);
collaboratorFavoritesActions = await FavoritesApi.initialize(userCollaborator, userCollaborator);
const collaboratorFavoritesTotalItems = await collaboratorFavoritesActions.getFavoritesTotalItems(userCollaborator);
const managerSearchTotalItems = await managerSearchActions.getTotalItems(userManager);
@@ -218,7 +218,7 @@ test.describe('Special permissions : ', () => {
let managerSiteActions: SitesApi;
let managerSearchActions: SearchApi;
let demotedUserActions: NodesApi;
let demotedUserFavoritesActions: FavoritesPageApi;
let demotedUserFavoritesActions: FavoritesApi;
let demotedUserShareActions: SharedLinksApi;
test.beforeAll(async () => {
@@ -231,7 +231,7 @@ test.describe('Special permissions : ', () => {
managerSiteActions = await SitesApi.initialize(userManager, userManager);
managerSearchActions = await SearchApi.initialize(userManager, userManager);
demotedUserActions = await NodesApi.initialize(userDemoted, userDemoted);
demotedUserFavoritesActions = await FavoritesPageApi.initialize(userDemoted, userDemoted);
demotedUserFavoritesActions = await FavoritesApi.initialize(userDemoted, userDemoted);
demotedUserShareActions = await SharedLinksApi.initialize(userDemoted, userDemoted);
const demotedUserFavoritesTotalItems = await demotedUserFavoritesActions.getFavoritesTotalItems(userDemoted);
@@ -275,7 +275,7 @@ test.describe('Special permissions : ', () => {
let managerNodeActions: NodesApi;
let managerSiteActions: SitesApi;
let managerSearchActions: SearchApi;
let managerFavoritesActions: FavoritesPageApi;
let managerFavoritesActions: FavoritesApi;
let demotedUserActions: NodesApi;
let demotedUserShareActions: SharedLinksApi;
@@ -288,7 +288,7 @@ test.describe('Special permissions : ', () => {
managerNodeActions = await NodesApi.initialize(userManager, userManager);
managerSiteActions = await SitesApi.initialize(userManager, userManager);
managerSearchActions = await SearchApi.initialize(userManager, userManager);
managerFavoritesActions = await FavoritesPageApi.initialize(userManager, userManager);
managerFavoritesActions = await FavoritesApi.initialize(userManager, userManager);
demotedUserActions = await NodesApi.initialize(userDemoted, userDemoted);
demotedUserShareActions = await SharedLinksApi.initialize(userDemoted, userDemoted);
@@ -25,7 +25,7 @@
import { expect } from '@playwright/test';
import {
ApiClientFactory,
FavoritesPageApi,
FavoritesApi,
FileActionsApi,
NodesApi,
PersonalFilesPage,
@@ -465,7 +465,7 @@ test.describe('viewer action file', () => {
nodesApi = apis.nodesApi;
trashcanApi = apis.trashcanApi;
const { fileActionsApi } = apis;
const favoritesActions = await FavoritesPageApi.initialize(username, username);
const favoritesActions = await FavoritesApi.initialize(username, username);
folderId = (await nodesApi.createFolder(`viewer-action-5462-${Utils.random()}`)).entry.id;
const randomDocxNameFavoriteId = (await fileActionsApi.uploadFile(TEST_FILES.DOCX.path, randomDocxNameFavorite, folderId)).entry.id;
await favoritesActions.addFavoriteById('file', randomDocxNameFavoriteId);
@@ -32,7 +32,7 @@ import {
TEST_FILES,
FileActionsApi,
SharedLinksApi,
FavoritesPageApi,
FavoritesApi,
RecentFilesPage,
PersonalFilesPage,
FavoritesPage,
@@ -45,7 +45,7 @@ test.describe('Version actions', () => {
let nodesApi: NodesApi;
let fileActionsApi: FileActionsApi;
let sharedLinksApi: SharedLinksApi;
let favoritesApi: FavoritesPageApi;
let favoritesApi: FavoritesApi;
const random = Utils.random();
const filesToUpload = [TEST_FILES.PDF, TEST_FILES.JPG_FILE];
const filenameBeforeUpdate = `${filesToUpload[0].name}-1-${random}.pdf`;
@@ -83,7 +83,7 @@ test.describe('Version actions', () => {
trashcanApi = await TrashcanApi.initialize(username, username);
nodesApi = await NodesApi.initialize(username, username);
fileActionsApi = await FileActionsApi.initialize(username, username);
favoritesApi = await FavoritesPageApi.initialize(username, username);
favoritesApi = await FavoritesApi.initialize(username, username);
sharedLinksApi = await SharedLinksApi.initialize(username, username);
fileId = (await fileActionsApi.uploadFile(filesToUpload[0].path, filenameBeforeUpdate, '-my-')).entry.id;
@@ -25,7 +25,7 @@
import { expect } from '@playwright/test';
import {
ApiClientFactory,
FavoritesPageApi,
FavoritesApi,
FileActionsApi,
NodesApi,
SharedLinksApi,
@@ -75,7 +75,7 @@ test.describe('viewer zoom functionality and reset', () => {
trashcanApi = await TrashcanApi.initialize(username, username);
siteActionsUser = await SitesApi.initialize(username, username);
const shareActions = await SharedLinksApi.initialize(username, username);
const favoritesActions = await FavoritesPageApi.initialize(username, username);
const favoritesActions = await FavoritesApi.initialize(username, username);
const node = await nodesApi.createFolder(randomFolderName);
folderId = node.entry.id;
@@ -25,7 +25,7 @@
import { expect } from '@playwright/test';
import {
ApiClientFactory,
FavoritesPageApi,
FavoritesApi,
FileActionsApi,
NodesApi,
SharedLinksApi,
@@ -438,7 +438,7 @@ test.describe('viewer file', () => {
nodesApi = apis.nodesApi;
trashcanApi = apis.trashcanApi;
const { fileActionsApi } = apis;
const favoritesActions = await FavoritesPageApi.initialize(username, username);
const favoritesActions = await FavoritesApi.initialize(username, username);
const folderId = (await nodesApi.createFolder(`viewer-${Utils.random()}`)).entry.id;
const fileDocxId = (await fileActionsApi.uploadFile(TEST_FILES.DOCX.path, randomDocxName, folderId)).entry.id;
const consumerFavoritesTotalItems = await favoritesActions.getFavoritesTotalItems(username);
@@ -26,14 +26,14 @@ import { ApiClientFactory } from './api-client-factory';
import { FavoriteEntry, FavoritePaging } from '@alfresco/js-api';
import { logger, Utils } from '../utils';
export class FavoritesPageApi {
export class FavoritesApi {
private readonly apiService: ApiClientFactory;
constructor() {
this.apiService = new ApiClientFactory();
}
static async initialize(userName: string, password?: string): Promise<FavoritesPageApi> {
const classObj = new FavoritesPageApi();
static async initialize(userName: string, password?: string): Promise<FavoritesApi> {
const classObj = new FavoritesApi();
await classObj.apiService.setUpAcaBackend(userName, password);
return classObj;
}
@@ -35,7 +35,7 @@ import {
FavoritesPage,
TrashPage
} from '../page-objects';
import { FileActionsApi, SharedLinksApi, FavoritesPageApi, NodesApi, SitesApi } from '../api';
import { FileActionsApi, SharedLinksApi, FavoritesApi, NodesApi, SitesApi } from '../api';
import { users } from '../base-config';
interface Pages {
@@ -55,7 +55,7 @@ interface Pages {
interface Api {
fileAction: FileActionsApi;
shareAction: SharedLinksApi;
favoritesPageAction: FavoritesPageApi;
favoritesPageAction: FavoritesApi;
nodesApiAction: NodesApi;
sitesApiAction: SitesApi;
}
@@ -98,7 +98,7 @@ export const test = base.extend<Pages & Api>({
},
// eslint-disable-next-line no-empty-pattern
favoritesPageAction: async ({}, use) => {
await use(await FavoritesPageApi.initialize(users.hruser.username));
await use(await FavoritesApi.initialize(users.hruser.username));
},
// eslint-disable-next-line no-empty-pattern
nodesApiAction: async ({}, use) => {