inteligr8/alfresco-content-app
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-content-app.git synced 2025-05-12 17:04:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ACS-9372] [E2E] Fixed eslint errors (#4479)

Browse Source 
* [ACS-9372] Fixed eslint errors

* [ACS-9372] Review fixes 1
This commit is contained in:
Adam Świderski 2025-03-26 09:09:52 +01:00 committed by GitHub
parent 8c1d2f3cd7
commit d2b6e6d6b4
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
e2e/playwright/info-drawer/src/tests/comments.e2e.ts
View File

@ -83,8 +83,7 @@ test.describe('Info Drawer - Comments', () => {
await expect(favoritePage.infoDrawer.commentInputField).toBeVisible(); await expect(favoritePage.infoDrawer.commentInputField).toBeVisible();
await favoritePage.infoDrawer.addCommentToNode(commentText); await favoritePage.infoDrawer.addCommentToNode(commentText);
await expect(favoritePage.infoDrawer.addCommentButton).toBeDisabled(); await expect(favoritePage.infoDrawer.addCommentButton).toBeDisabled();
expect(await favoritePage.infoDrawer.checkCommentsHeaderCount()).toEqual(1); expect(await favoritePage.infoDrawer.getCommentsCountFromList()).toEqual(1);
expect(await favoritePage.infoDrawer.verifyCommentsCountFromList(1));
}); });
test('[XAT-5533] from Shared Files - Comments are displayed ordered by created date in descending order', async ({ sharedPage }) => { test('[XAT-5533] from Shared Files - Comments are displayed ordered by created date in descending order', async ({ sharedPage }) => {
@ -120,8 +119,7 @@ test.describe('Info Drawer - Comments', () => {
await expect(recentFilesPage.infoDrawer.commentInputField).toBeVisible(); await expect(recentFilesPage.infoDrawer.commentInputField).toBeVisible();
await recentFilesPage.infoDrawer.addCommentToNode(commentText); await recentFilesPage.infoDrawer.addCommentToNode(commentText);
await expect(recentFilesPage.infoDrawer.addCommentButton).toBeDisabled(); await expect(recentFilesPage.infoDrawer.addCommentButton).toBeDisabled();
expect(await recentFilesPage.infoDrawer.checkCommentsHeaderCount()).toEqual(1); expect(await recentFilesPage.infoDrawer.getCommentsCountFromList()).toEqual(1);
expect(await recentFilesPage.infoDrawer.verifyCommentsCountFromList(1));
}); });
test('[XAT-5540] Comment info display - File from Favorites', async ({ favoritePage }) => { test('[XAT-5540] Comment info display - File from Favorites', async ({ favoritePage }) => {

7
projects/aca-playwright-shared/src/page-objects/components/adf-info-drawer.component.ts
View File

@ -23,7 +23,7 @@
*/ */
import { BaseComponent } from './base.component'; import { BaseComponent } from './base.component';
import { Page, expect } from '@playwright/test'; import { Page } from '@playwright/test';
export class AdfInfoDrawerComponent extends BaseComponent { export class AdfInfoDrawerComponent extends BaseComponent {
private static rootElement = 'adf-info-drawer'; private static rootElement = 'adf-info-drawer';
@ -89,9 +89,8 @@ export class AdfInfoDrawerComponent extends BaseComponent {
return parseInt(commentsCountString, 10); return parseInt(commentsCountString, 10);
} }
async verifyCommentsCountFromList(expectedNumber: number): Promise<void> { async getCommentsCountFromList(): Promise<number> {
const commentsCountFromList = await this.commentsList.count(); return this.commentsList.count();
expect(commentsCountFromList).toEqual(expectedNumber);
} }
async waitForComments(): Promise<void> { async waitForComments(): Promise<void> {