From da05018744f98f29c4bd7c9f7300f66487030e89 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Adam=20=C5=9Awiderski?= Date: Wed, 16 Sep 2026 14:56:28 +0200 Subject: [PATCH] [ACS-12817] review fixes 1 --- e2e/playwright/copy-move-actions/src/tests/copy.e2e.ts | 4 ++-- e2e/playwright/edit-actions/src/tests/edit-offline.e2e.ts | 6 +++++- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/e2e/playwright/copy-move-actions/src/tests/copy.e2e.ts b/e2e/playwright/copy-move-actions/src/tests/copy.e2e.ts index 651f44736..f84b44d3e 100644 --- a/e2e/playwright/copy-move-actions/src/tests/copy.e2e.ts +++ b/e2e/playwright/copy-move-actions/src/tests/copy.e2e.ts @@ -53,7 +53,7 @@ test.describe('Copy actions', () => { }); test.beforeEach(async ({ personalFiles, page }) => { - const sourceFileRandom = `${Utils.random()}`; + const sourceFileRandom = Utils.random(); sourceFile = `source-file-${sourceFileRandom}`; sourceFileWorkingCopy = `source-file-${sourceFileRandom} (Working Copy)`; sourceFileInsideFolder = `source-file-inside-folder-${Utils.random()}.txt`; @@ -125,7 +125,7 @@ test.describe('Copy actions', () => { test('[XAT-4944] Copy a file with a name that already exists on the destination', async ({ personalFiles }) => { await nodesApi.createFile(sourceFile, destinationFolderId); - const expectedNameForCopiedFile = `${sourceFile + '-1'}`; + const expectedNameForCopiedFile = `${sourceFile}-1`; await Utils.reloadPageIfRowNotVisible(personalFiles, sourceFile); await copyContentInPersonalFiles(personalFiles, [sourceFile], destinationFolder); expect.soft(await personalFiles.dataTable.isItemPresent(sourceFile)).toBe(true); diff --git a/e2e/playwright/edit-actions/src/tests/edit-offline.e2e.ts b/e2e/playwright/edit-actions/src/tests/edit-offline.e2e.ts index 8149a2bfa..4bed29395 100644 --- a/e2e/playwright/edit-actions/src/tests/edit-offline.e2e.ts +++ b/e2e/playwright/edit-actions/src/tests/edit-offline.e2e.ts @@ -73,6 +73,7 @@ test.describe('Edit offline - on Personal Files', () => { personalFiles.matMenu.clickMenuItem('Edit Offline') ]); expect(download.suggestedFilename()).toBe(file5304); + expect(await fileActionsApi.isFileCheckedOutWithRetry(file5304Id, true), `${file5304} is not locked`).toBe(true); }); }); @@ -133,10 +134,12 @@ test.describe('Edit offline - on Personal Files', () => { test.describe('[XAT-20171] Cancel Editing option should not persists after uploading a new file version', () => { const file20171 = `file-20171-${Utils.random()}`; + let fileLocked20171Id: string; test.beforeAll(async () => { try { - await fileActionsApi.uploadFileWithRename(TEST_FILES.PNG_FILE.path, file20171); + fileLocked20171Id = (await fileActionsApi.uploadFileWithRename(TEST_FILES.PNG_FILE.path, file20171)).entry.id; + await nodesApi.checkoutNodes([fileLocked20171Id]); } catch (error) { console.error(`beforeAll failed : ${error}`); } @@ -160,6 +163,7 @@ test.describe('Edit offline - on Personal Files', () => { await personalFiles.dataTable.selectItems(TEST_FILES.PNG_FILE.name); await personalFiles.acaHeader.clickMoreActions(); await expect(personalFiles.matMenu.getButtonByText('Upload New Version')).toBeVisible(); + await expect(personalFiles.matMenu.getButtonByText('Cancel Editing')).toBeHidden(); }); }); });