mirror of
https://github.com/Alfresco/alfresco-content-app.git
synced 2025-07-31 17:38:28 +00:00
[ACS-4538] Make folder-rules secondary entry point of aca-content (#3181)
* [ACS-4538] Make folder-rules secondary entry point of aca-content * [ACA-4538] Fix folder rules imports * [ACS-4538] Fix folder-rules unit tests * [ACS-4538] Fix package.json after folder rules transition * [ACS-4538] Remove duplicated peerDependency * [ACS-4538] Import fix
This commit is contained in:
@@ -0,0 +1,163 @@
|
||||
/*!
|
||||
* Copyright © 2005-2023 Hyland Software, Inc. and its affiliates. All rights reserved.
|
||||
*
|
||||
* Alfresco Example Content Application
|
||||
*
|
||||
* This file is part of the Alfresco Example Content Application.
|
||||
* If the software was purchased under a paid Alfresco license, the terms of
|
||||
* the paid license agreement will prevail. Otherwise, the software is
|
||||
* provided under the following open source license terms:
|
||||
*
|
||||
* The Alfresco Example Content Application is free software: you can redistribute it and/or modify
|
||||
* it under the terms of the GNU Lesser General Public License as published by
|
||||
* the Free Software Foundation, either version 3 of the License, or
|
||||
* (at your option) any later version.
|
||||
*
|
||||
* The Alfresco Example Content Application is distributed in the hope that it will be useful,
|
||||
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||
* GNU Lesser General Public License for more details.
|
||||
*
|
||||
* You should have received a copy of the GNU Lesser General Public License
|
||||
* from Hyland Software. If not, see <http://www.gnu.org/licenses/>.
|
||||
*/
|
||||
|
||||
import { TestBed } from '@angular/core/testing';
|
||||
import { CoreTestingModule } from '@alfresco/adf-core';
|
||||
import { of } from 'rxjs';
|
||||
import { FolderRulesService } from './folder-rules.service';
|
||||
import {
|
||||
getMoreRulesResponseMock,
|
||||
getRulesResponseMock,
|
||||
manyRulesMock,
|
||||
moreRulesMock,
|
||||
ruleMock,
|
||||
ruleSettingsMock,
|
||||
rulesMock
|
||||
} from '../mock/rules.mock';
|
||||
import { ruleSetMock } from '../mock/rule-sets.mock';
|
||||
import { owningFolderIdMock } from '../mock/node.mock';
|
||||
import { take } from 'rxjs/operators';
|
||||
|
||||
describe('FolderRulesService', () => {
|
||||
let folderRulesService: FolderRulesService;
|
||||
|
||||
let callApiSpy: jasmine.Spy;
|
||||
|
||||
const nodeId = owningFolderIdMock;
|
||||
const ruleSetId = 'rule-set-id';
|
||||
const mockedRule = ruleMock('rule-mock');
|
||||
const { ...mockedRuleWithoutId } = mockedRule;
|
||||
const mockedRuleEntry = { entry: mockedRule };
|
||||
const ruleId = mockedRule.id;
|
||||
const mockedRuleSettingsEntry = { entry: ruleSettingsMock };
|
||||
const key = ruleSettingsMock.key;
|
||||
|
||||
beforeEach(() => {
|
||||
TestBed.configureTestingModule({
|
||||
imports: [CoreTestingModule],
|
||||
providers: [FolderRulesService]
|
||||
});
|
||||
|
||||
folderRulesService = TestBed.inject<FolderRulesService>(FolderRulesService);
|
||||
|
||||
callApiSpy = spyOn<any>(folderRulesService, 'callApi');
|
||||
});
|
||||
|
||||
it('should load some rules into a rule set', () => {
|
||||
const ruleSet = ruleSetMock();
|
||||
callApiSpy.and.returnValue(of(getRulesResponseMock));
|
||||
|
||||
expect(ruleSet.rules.length).toBe(0);
|
||||
expect(ruleSet.hasMoreRules).toBeTrue();
|
||||
expect(ruleSet.loadingRules).toBeFalse();
|
||||
|
||||
folderRulesService.loadRules(ruleSet);
|
||||
|
||||
expect(callApiSpy).toHaveBeenCalledWith(`/nodes/${ruleSet.owningFolder.id}/rule-sets/${ruleSet.id}/rules?skipCount=0&maxItems=100`, 'GET');
|
||||
expect(ruleSet.rules.length).toBe(2);
|
||||
expect(ruleSet.rules).toEqual(rulesMock);
|
||||
expect(ruleSet.hasMoreRules).toBeFalse();
|
||||
});
|
||||
|
||||
it('should load more rules if it still has some more to load', () => {
|
||||
const ruleSet = ruleSetMock(rulesMock);
|
||||
callApiSpy.and.returnValue(of(getMoreRulesResponseMock));
|
||||
|
||||
expect(ruleSet.rules.length).toBe(2);
|
||||
expect(ruleSet.hasMoreRules).toBeTrue();
|
||||
|
||||
folderRulesService.loadRules(ruleSet);
|
||||
|
||||
expect(callApiSpy).toHaveBeenCalledWith(`/nodes/${ruleSet.owningFolder.id}/rule-sets/${ruleSet.id}/rules?skipCount=2&maxItems=100`, 'GET');
|
||||
expect(ruleSet.rules.length).toBe(4);
|
||||
expect(ruleSet.rules).toEqual([...rulesMock, ...moreRulesMock]);
|
||||
expect(ruleSet.hasMoreRules).toBeFalse();
|
||||
});
|
||||
|
||||
it('should select the right rule rule after loading', () => {
|
||||
const ruleSet = ruleSetMock(rulesMock);
|
||||
spyOn(folderRulesService, 'getRules').and.returnValue(of({ rules: manyRulesMock, hasMoreRules: false }));
|
||||
const selectedRuleSourceSpy = spyOn(folderRulesService['selectedRuleSource'], 'next');
|
||||
|
||||
folderRulesService.loadRules(ruleSet, 0);
|
||||
expect(selectedRuleSourceSpy).not.toHaveBeenCalled();
|
||||
|
||||
folderRulesService.loadRules(ruleSet, 0, 'first');
|
||||
expect(selectedRuleSourceSpy).toHaveBeenCalledWith(ruleMock('rule1'));
|
||||
selectedRuleSourceSpy.calls.reset();
|
||||
|
||||
folderRulesService.loadRules(ruleSet, 0, 'last');
|
||||
expect(selectedRuleSourceSpy).toHaveBeenCalledWith(ruleMock('rule5'));
|
||||
selectedRuleSourceSpy.calls.reset();
|
||||
selectedRuleSourceSpy.calls.reset();
|
||||
|
||||
folderRulesService.loadRules(ruleSet, 0, ruleMock('rule3'));
|
||||
expect(selectedRuleSourceSpy).toHaveBeenCalledWith(ruleMock('rule3'));
|
||||
});
|
||||
|
||||
it('should delete a rule and return its id', async () => {
|
||||
callApiSpy.withArgs(`/nodes/${nodeId}/rule-sets/${ruleSetId}/rules/${ruleId}`, 'DELETE').and.returnValue(ruleId);
|
||||
const deletedRulePromise = folderRulesService.deletedRuleId$.pipe(take(2)).toPromise();
|
||||
|
||||
folderRulesService.deleteRule(nodeId, ruleId, ruleSetId);
|
||||
const deletedRule = await deletedRulePromise;
|
||||
|
||||
expect(deletedRule).toBeTruthy('rule has not been deleted');
|
||||
expect(deletedRule).toBe(ruleId, 'wrong id of deleted rule');
|
||||
expect(callApiSpy).toHaveBeenCalledTimes(1);
|
||||
expect(callApiSpy).toHaveBeenCalledWith(`/nodes/${nodeId}/rule-sets/${ruleSetId}/rules/${ruleId}`, 'DELETE');
|
||||
});
|
||||
|
||||
it('should send correct POST request and return created rule', async () => {
|
||||
callApiSpy
|
||||
.withArgs(`/nodes/${nodeId}/rule-sets/${ruleSetId}/rules`, 'POST', mockedRuleWithoutId)
|
||||
.and.returnValue(Promise.resolve(mockedRuleEntry));
|
||||
const result = await folderRulesService.createRule(nodeId, mockedRuleWithoutId, ruleSetId);
|
||||
|
||||
expect(result).toEqual(mockedRule);
|
||||
});
|
||||
|
||||
it('should send correct PUT request to update rule and return it', async () => {
|
||||
callApiSpy
|
||||
.withArgs(`/nodes/${nodeId}/rule-sets/${ruleSetId}/rules/${ruleId}`, 'PUT', mockedRule)
|
||||
.and.returnValue(Promise.resolve(mockedRuleEntry));
|
||||
|
||||
const result = await folderRulesService.updateRule(nodeId, ruleId, mockedRule, ruleSetId);
|
||||
expect(result).toEqual(mockedRule);
|
||||
});
|
||||
|
||||
it('should send correct GET request and return rule settings', async () => {
|
||||
callApiSpy.withArgs(`/nodes/${nodeId}/rule-settings/${key}`, 'GET').and.returnValue(Promise.resolve(mockedRuleSettingsEntry));
|
||||
|
||||
const result = await folderRulesService.getRuleSettings(nodeId, key);
|
||||
expect(result).toEqual(ruleSettingsMock);
|
||||
});
|
||||
|
||||
it('should send correct PUT request to update rule settings and return them', async () => {
|
||||
callApiSpy.withArgs(`/nodes/${nodeId}/rule-settings/${key}`, 'PUT', ruleSettingsMock).and.returnValue(Promise.resolve(mockedRuleSettingsEntry));
|
||||
|
||||
const result = await folderRulesService.updateRuleSettings(nodeId, key, ruleSettingsMock);
|
||||
expect(result).toEqual(ruleSettingsMock);
|
||||
});
|
||||
});
|
Reference in New Issue
Block a user