From eb299dedba84d76532369a6da1b0f8b14b52154d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Iulia=20Burc=C4=83?= Date: Mon, 1 Mar 2021 16:23:06 +0200 Subject: [PATCH] [ACA-4283] Change the issue of the excluded tests to ACS-1297 (#2004) * Reinclude tests excluded by ACA-4283 * Add click step in typeText method * move click step before sendKeys * browser sleep test * test run * Remove empty return string * reinclude tests affected by ACA-4253 * remove browser.sleep * reinclude one test * Change the issue of the excluded tests --- e2e/protractor.excludes.json | 8 ++++---- .../src/utilities/repo-client/apis/nodes/nodes-api.ts | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/e2e/protractor.excludes.json b/e2e/protractor.excludes.json index 229b4dd2a..d91b731ef 100644 --- a/e2e/protractor.excludes.json +++ b/e2e/protractor.excludes.json @@ -1,18 +1,18 @@ { "C306956": "https://alfresco.atlassian.net/browse/ACA-4196", "C325049": "https://alfresco.atlassian.net/browse/ACA-4219", - "C286326": "https://alfresco.atlassian.net/browse/ACA-4253", "C286656": "https://alfresco.atlassian.net/browse/ACA-4253", "C286689": "https://alfresco.atlassian.net/browse/ACA-4253", "C286691": "https://alfresco.atlassian.net/browse/ACA-4253", "C286686": "https://alfresco.atlassian.net/browse/ACA-4253", "C286697": "https://alfresco.atlassian.net/browse/ACA-4253", - "C325026": "https://alfresco.atlassian.net/browse/ACA-4253", "C306996": "https://alfresco.atlassian.net/browse/ACA-4253", "C286685": "https://alfresco.atlassian.net/browse/ACA-4253", "C286688": "https://alfresco.atlassian.net/browse/ACA-4253", "C286696": "https://alfresco.atlassian.net/browse/ACA-4253", "C286701": "https://alfresco.atlassian.net/browse/ACA-4253", - "C325161": "https://alfresco.atlassian.net/browse/ACA-4283", - "C325023": "https://alfresco.atlassian.net/browse/ACA-4283" + "C325161": "https://alfresco.atlassian.net/browse/ACS-1297", + "C325023": "https://alfresco.atlassian.net/browse/ACS-1297", + "C325026": "https://alfresco.atlassian.net/browse/ACS-1297", + "C286326": "https://alfresco.atlassian.net/browse/ACS-1297" } diff --git a/projects/aca-testing-shared/src/utilities/repo-client/apis/nodes/nodes-api.ts b/projects/aca-testing-shared/src/utilities/repo-client/apis/nodes/nodes-api.ts index 5a23c9b2e..f9b57f15b 100755 --- a/projects/aca-testing-shared/src/utilities/repo-client/apis/nodes/nodes-api.ts +++ b/projects/aca-testing-shared/src/utilities/repo-client/apis/nodes/nodes-api.ts @@ -69,7 +69,7 @@ export class NodesApi extends RepoApi { async getNodeDescription(name: string, parentId: string): Promise { try { const children = (await this.getNodeChildren(parentId)).list.entries; - return children.find((elem) => elem.entry.name === name).entry.properties['cm:description'] || ''; + return children.find((elem) => elem.entry.name === name).entry.properties['cm:description']; } catch (error) { this.handleError(`${this.constructor.name} ${this.getNodeDescription.name}`, error); return ''; @@ -79,7 +79,7 @@ export class NodesApi extends RepoApi { async getNodeTitle(name: string, parentId: string): Promise { try { const children = (await this.getNodeChildren(parentId)).list.entries; - return children.find((elem) => elem.entry.name === name).entry.properties['cm:title'] || ''; + return children.find((elem) => elem.entry.name === name).entry.properties['cm:title']; } catch (error) { this.handleError(`${this.constructor.name} ${this.getNodeTitle.name}`, error); return '';