inteligr8/alfresco-keycloak
1
0
Fork 0
mirror of https://github.com/bmlong137/alfresco-keycloak.git synced 2025-05-26 21:44:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix 500 error for keycloak NotFoundException

Browse Source 
Check for a NotFoundException in the KeycloakAuthenticationFilter and
return a 404 if one is thrown.
This commit is contained in:
Brian Long 2024-08-22 14:41:35 -04:00
parent 488723ace6
commit 7e268bc320
1 changed files with 23 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
repository/src/main/java/de/acosix/alfresco/keycloak/repo/authentication/KeycloakAuthenticationFilter.java
View File

@ -45,6 +45,7 @@ import org.alfresco.repo.webdav.auth.AuthenticationDriver;
import org.alfresco.repo.webdav.auth.BaseAuthenticationFilter; import org.alfresco.repo.webdav.auth.BaseAuthenticationFilter;
import org.alfresco.repo.webdav.auth.BaseSSOAuthenticationFilter; import org.alfresco.repo.webdav.auth.BaseSSOAuthenticationFilter;
import org.alfresco.rest.api.PublicApiTenantWebScriptServletRuntime; import org.alfresco.rest.api.PublicApiTenantWebScriptServletRuntime;
import org.alfresco.rest.framework.core.exceptions.NotFoundException;
import org.alfresco.util.PropertyCheck; import org.alfresco.util.PropertyCheck;
import org.apache.commons.codec.binary.Base64; import org.apache.commons.codec.binary.Base64;
import org.apache.commons.logging.Log; import org.apache.commons.logging.Log;
@ -310,6 +311,10 @@ public class KeycloakAuthenticationFilter extends BaseAuthenticationFilter
this.keycloakDeployment.getAuthServerBaseUrl()); this.keycloakDeployment.getAuthServerBaseUrl());
} }
// Wrap the call to checkForSkipCondition in a try-catch in order to catch any NotFoundExceptions
// and set the status on the response to a 404. This prevents the return of 500 errors which security
// scanning determines is a security finding.
try {
final boolean skip = !keycloakDeploymentReady || this.checkForSkipCondition(context, req, res); final boolean skip = !keycloakDeploymentReady || this.checkForSkipCondition(context, req, res);
if (skip) if (skip)
@ -327,6 +332,12 @@ public class KeycloakAuthenticationFilter extends BaseAuthenticationFilter
chain.doFilter(request, response); chain.doFilter(request, response);
} }
} }
} catch (NotFoundException nfex) {
LOGGER.debug("Not Found Exception was returned while handling KeyCloak auth!", nfex);
res.setStatus(HttpServletResponse.SC_NOT_FOUND);
}
} }
/** /**