From 00740eeb5f47aa925f742f33b72b8e3089a50860 Mon Sep 17 00:00:00 2001
From: Vito Albano <vito.albano@hyland.com>
Date: Fri, 24 Nov 2023 15:02:45 +0000
Subject: [PATCH] Fixed last unit tests

---
 lib/process-services-cloud/karma.conf.js             |  1 -
 .../lib/group/components/group-cloud.component.html  |  2 +-
 .../group/components/group-cloud.component.spec.ts   | 12 +++++++-----
 .../people/components/people-cloud.component.html    |  3 +--
 .../people/components/people-cloud.component.spec.ts |  2 +-
 package.json                                         |  2 +-
 6 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/lib/process-services-cloud/karma.conf.js b/lib/process-services-cloud/karma.conf.js
index 2c947d8695..f6b9daa61b 100644
--- a/lib/process-services-cloud/karma.conf.js
+++ b/lib/process-services-cloud/karma.conf.js
@@ -15,7 +15,6 @@ module.exports = function (config) {
                 included: true,
                 watched: false
             },
-            { pattern: 'node_modules/chart.js/dist/Chart.js', included: true, watched: false },
             { pattern: 'node_modules/raphael/raphael.min.js', included: true, watched: false },
             { pattern: 'lib/core/src/lib/i18n/**/en.json', included: false, served: true, watched: false },
             { pattern: 'lib/process-services-cloud/src/lib/i18n/*.json', included: false, served: true, watched: false },
diff --git a/lib/process-services-cloud/src/lib/group/components/group-cloud.component.html b/lib/process-services-cloud/src/lib/group/components/group-cloud.component.html
index 856cec96f2..376a4e26d9 100644
--- a/lib/process-services-cloud/src/lib/group/components/group-cloud.component.html
+++ b/lib/process-services-cloud/src/lib/group/components/group-cloud.component.html
@@ -16,7 +16,7 @@
                     cancel
                 </mat-icon>
             </mat-chip-row>
-            <input *ngIf="!isReadonly()" matInput
+            <input [disabled]="isReadonly()" matInput
                    [formControl]="searchGroupsControl"
                    [matAutocomplete]="auto"
                    [matChipInputFor]="groupChipList"
diff --git a/lib/process-services-cloud/src/lib/group/components/group-cloud.component.spec.ts b/lib/process-services-cloud/src/lib/group/components/group-cloud.component.spec.ts
index 0f924cc6c0..588bd6c8fa 100644
--- a/lib/process-services-cloud/src/lib/group/components/group-cloud.component.spec.ts
+++ b/lib/process-services-cloud/src/lib/group/components/group-cloud.component.spec.ts
@@ -18,21 +18,21 @@
 import { ComponentFixture, TestBed } from '@angular/core/testing';
 import { By } from '@angular/platform-browser';
 import { of } from 'rxjs';
-import { ProcessServiceCloudTestingModule } from './../../testing/process-service-cloud.testing.module';
 import { GroupCloudModule } from '../group-cloud.module';
 import { GroupCloudComponent } from './group-cloud.component';
-import { CoreTestingModule } from '@alfresco/adf-core';
 import { DebugElement, SimpleChange } from '@angular/core';
 import { TranslateModule } from '@ngx-translate/core';
 import { IdentityGroupService } from '../services/identity-group.service';
 import { mockFoodGroups, mockMeatChicken, mockVegetableAubergine } from '../mock/group-cloud.mock';
+import { TranslationMock, TranslationService } from '@alfresco/adf-core';
+import { NoopAnimationsModule } from '@angular/platform-browser/animations';
 
 describe('GroupCloudComponent', () => {
     let component: GroupCloudComponent;
     let fixture: ComponentFixture<GroupCloudComponent>;
     let element: HTMLElement;
     let identityGroupService: IdentityGroupService;
-    let findGroupsByNameSpy: jasmine.Spy;
+    let findGroupsByNameSpy;
 
     // eslint-disable-next-line prefer-arrow/prefer-arrow-functions
     /**
@@ -93,9 +93,11 @@ describe('GroupCloudComponent', () => {
         TestBed.configureTestingModule({
             imports: [
                 TranslateModule.forRoot(),
-                CoreTestingModule,
-                ProcessServiceCloudTestingModule,
+                NoopAnimationsModule,
                 GroupCloudModule
+            ],
+            providers: [
+                { provide: TranslationService, useClass: TranslationMock }
             ]
         });
         fixture = TestBed.createComponent(GroupCloudComponent);
diff --git a/lib/process-services-cloud/src/lib/people/components/people-cloud.component.html b/lib/process-services-cloud/src/lib/people/components/people-cloud.component.html
index a99efe782a..95ef489889 100644
--- a/lib/process-services-cloud/src/lib/people/components/people-cloud.component.html
+++ b/lib/process-services-cloud/src/lib/people/components/people-cloud.component.html
@@ -1,7 +1,6 @@
 <form>
     <mat-form-field [floatLabel]="'auto'" class="adf-people-cloud" [class.adf-invalid]="hasError() && isDirty()">
-        <mat-label *ngIf="!isReadonly()" id="adf-people-cloud-title-id" class="adf-people-cloud-title"
-            [ngClass]="{'adf-people-cloud-title--focus': isFocused}">>{{ title | translate }}</mat-label>
+        <mat-label *ngIf="!isReadonly()" id="adf-people-cloud-title-id">{{ title | translate }}</mat-label>
         <mat-chip-grid #userMultipleChipList [disabled]="isReadonly() || isValidationLoading()" data-automation-id="adf-cloud-people-chip-list">
             <mat-chip-row
                 *ngFor="let user of selectedUsers"
diff --git a/lib/process-services-cloud/src/lib/people/components/people-cloud.component.spec.ts b/lib/process-services-cloud/src/lib/people/components/people-cloud.component.spec.ts
index 35abd46e71..2bf517a80b 100644
--- a/lib/process-services-cloud/src/lib/people/components/people-cloud.component.spec.ts
+++ b/lib/process-services-cloud/src/lib/people/components/people-cloud.component.spec.ts
@@ -39,7 +39,7 @@ describe('PeopleCloudComponent', () => {
     let fixture: ComponentFixture<PeopleCloudComponent>;
     let element: HTMLElement;
     let identityUserService: IdentityUserServiceInterface;
-    let searchSpy: jasmine.Spy;
+    let searchSpy;
 
     // eslint-disable-next-line prefer-arrow/prefer-arrow-functions
     /**
diff --git a/package.json b/package.json
index 128eae4602..524c16dde4 100644
--- a/package.json
+++ b/package.json
@@ -71,7 +71,6 @@
     "@editorjs/editorjs": "^2.26.5",
     "@editorjs/header": "2.7.0",
     "@editorjs/list": "1.8.0",
-    "@editorjs/underline": "1.1.0",
     "@mat-datetimepicker/core": "11.0.3",
     "@ngx-translate/core": "^14.0.0",
     "@storybook/core-server": "^7.6.5",
@@ -109,6 +108,7 @@
     "@editorjs/code": "2.8.0",
     "@editorjs/inline-code": "1.4.0",
     "@editorjs/marker": "1.2.2",
+    "@editorjs/underline": "^1.1.0",
     "@nrwl/angular": "15.9.3",
     "@nrwl/cli": "15.9.3",
     "@nrwl/eslint-plugin-nx": "15.9.3",