Fixing unit test after last rebase + lint

2025-05-26 17:24:56 +00:00 · 2024-04-10 01:23:50 +01:00 · 2024-04-10 01:23:50 +01:00 · 028ecd5865
commit 028ecd5865
parent b4f86fe3af
8 changed files with 15275 additions and 20128 deletions
--- a/lib/process-services-cloud/src/lib/common/date-range-filter/date-range-filter.component.html
+++ b/lib/process-services-cloud/src/lib/common/date-range-filter/date-range-filter.component.html
@ -1,5 +1,6 @@

-<mat-form-field [floatLabel]="'auto'" [attr.data-automation-id]="processFilterProperty.key">
+<mat-form-field floatLabel="auto" [attr.data-automation-id]="processFilterProperty.key">
+    <mat-label>{{ processFilterProperty.label | translate }}</mat-label>
    <mat-select
        placeholder="{{ processFilterProperty.label | translate }}"
        [value]="type"
@ -12,7 +13,7 @@
 </mat-form-field>

 <ng-container *ngIf="isDateRangeType()">
-    <mat-form-field [floatLabel]="'auto'" class="adf-cloud-date-range-picker">
+    <mat-form-field floatLabel="auto" class="adf-cloud-date-range-picker">
        <mat-label>{{ 'ADF_CLOUD_EDIT_PROCESS_FILTER.LABEL.DATE_RANGE_TITLE' | translate }}</mat-label>
        <mat-date-range-input [formGroup]="dateRangeForm" [rangePicker]="picker">
          <input matStartDate formControlName="from" placeholder="{{ 'ADF_CLOUD_EDIT_PROCESS_FILTER.LABEL.START_DATE' | translate }}">
--- a/lib/process-services/src/lib/attachment/task-attachment-list/task-attachment-list.component.spec.ts
+++ b/lib/process-services/src/lib/attachment/task-attachment-list/task-attachment-list.component.spec.ts
@ -26,6 +26,12 @@ import { ProcessContentService } from '../../form/services/process-content.servi
 import { HarnessLoader } from '@angular/cdk/testing';
 import { TestbedHarnessEnvironment } from '@angular/cdk/testing/testbed';
 import { MatMenuItemHarness } from '@angular/material/menu/testing';
+import { HttpClientTestingModule } from '@angular/common/http/testing';
+import { MatMenuModule } from '@angular/material/menu';
+import { NoopAnimationsModule } from '@angular/platform-browser/animations';
+import { MatProgressSpinnerModule } from '@angular/material/progress-spinner';
+import { MatTooltipModule } from '@angular/material/tooltip';
+import { AlfrescoApiService, AlfrescoApiServiceMock } from '@alfresco/adf-core';

 describe('TaskAttachmentList', () => {
    let component: TaskAttachmentListComponent;
@ -42,15 +48,13 @@ describe('TaskAttachmentList', () => {
        TestBed.configureTestingModule({
            imports: [
                TranslateModule.forRoot(),
-                HttpClientModule,
+                HttpClientTestingModule,
                MatMenuModule,
                NoopAnimationsModule,
                MatProgressSpinnerModule,
                MatTooltipModule
            ],
-            providers: [
-                { provide: AlfrescoApiService, useClass: AlfrescoApiServiceMock }
-            ]
+            providers: [{ provide: AlfrescoApiService, useClass: AlfrescoApiServiceMock }]
        });
        fixture = TestBed.createComponent(TaskAttachmentListComponent);
        component = fixture.componentInstance;
@ -306,7 +310,7 @@ describe('Custom CustomEmptyTemplateComponent', () => {

    beforeEach(() => {
        TestBed.configureTestingModule({
-            imports: [ProcessTestingModule],
+            imports: [TranslateModule.forRoot(), ProcessTestingModule],
            declarations: [CustomEmptyTemplateComponent],
            schemas: [CUSTOM_ELEMENTS_SCHEMA]
        });
--- a/lib/process-services/src/lib/form/widgets/radio-buttons/radio-buttons.widget.spec.ts
+++ b/lib/process-services/src/lib/form/widgets/radio-buttons/radio-buttons.widget.spec.ts
@ -17,7 +17,21 @@

 import { ComponentFixture, fakeAsync, TestBed } from '@angular/core/testing';
 import { Observable, of } from 'rxjs';
-import { FormService, ContainerModel, FormFieldTypes, FormFieldOption, FormFieldModel, FormModel, CoreTestingModule } from '@alfresco/adf-core';
+import {
+    FormService,
+    ContainerModel,
+    FormFieldTypes,
+    FormFieldOption,
+    FormFieldModel,
+    FormModel,
+    ErrorWidgetComponent,
+    TranslationMock,
+    AlfrescoApiServiceMock,
+    AppConfigServiceMock,
+    AppConfigService,
+    AlfrescoApiService,
+    TranslationService
+} from '@alfresco/adf-core';
 import { RadioButtonsWidgetComponent } from './radio-buttons.widget';
 import { MatIconModule } from '@angular/material/icon';
 import { MatRadioModule } from '@angular/material/radio';
@ -29,6 +43,9 @@ import { HarnessLoader } from '@angular/cdk/testing';
 import { TestbedHarnessEnvironment } from '@angular/cdk/testing/testbed';
 import { MatRadioButtonHarness, MatRadioGroupHarness } from '@angular/material/radio/testing';
 import { MatTooltipHarness } from '@angular/material/tooltip/testing';
+import { MatTooltipModule } from '@angular/material/tooltip';
+import { MatButtonModule } from '@angular/material/button';
+import { HttpClientTestingModule } from '@angular/common/http/testing';

 describe('RadioButtonsWidgetComponent', () => {
    let formService: FormService;
@ -47,8 +64,8 @@ describe('RadioButtonsWidgetComponent', () => {
                HttpClientTestingModule,
                MatIconModule
            ],
-            declarations:[RadioButtonsWidgetComponent, ErrorWidgetComponent],
-            providers:[
+            declarations: [RadioButtonsWidgetComponent, ErrorWidgetComponent],
+            providers: [
                { provide: TranslationService, useClass: TranslationMock },
                { provide: AlfrescoApiService, useClass: AlfrescoApiServiceMock },
                { provide: AppConfigService, useClass: AppConfigServiceMock }
--- a/lib/process-services/src/lib/process-list/components/start-process/start-process.component.html
+++ b/lib/process-services/src/lib/process-list/components/start-process/start-process.component.html
@ -10,6 +10,7 @@
            <div class="content">
                <div class="adf-start-process-definition-container">
                    <mat-form-field *ngIf="showSelectApplicationDropdown" [floatLabel]="'always'" class="adf-start-process-app-list">
+                        <mat-label>{{ 'ADF_PROCESS_LIST.START_PROCESS.FORM.LABEL.SELECT_APPLICATION' | translate }}</mat-label>
                        <mat-select
                            placeholder="{{ 'ADF_PROCESS_LIST.START_PROCESS.FORM.LABEL.SELECT_APPLICATION' | translate }}"
                            (selectionChange)="onAppSelectionChange($event)"
--- a/lib/process-services/src/lib/process-list/components/start-process/start-process.component.spec.ts
+++ b/lib/process-services/src/lib/process-list/components/start-process/start-process.component.spec.ts
@ -38,7 +38,13 @@ import { HarnessLoader } from '@angular/cdk/testing';
 import { MatFormFieldHarness } from '@angular/material/form-field/testing';
 import { TestbedHarnessEnvironment } from '@angular/cdk/testing/testbed';
 import { MatAutocompleteHarness } from '@angular/material/autocomplete/testing';
-import { ProcessInstanceVariable } from '../models/process-instance-variable.model';
+import { FormModule } from '../../form';
+import { NoopAnimationsModule } from '@angular/platform-browser/animations';
+import { FormsModule, ReactiveFormsModule } from '@angular/forms';
+import { HttpClientTestingModule } from '@angular/common/http/testing';
+import { MatInputModule } from '@angular/material/input';
+import { MatIconModule } from '@angular/material/icon';
+import { MatAutocompleteModule } from '@angular/material/autocomplete';

 describe('StartProcessComponent', () => {
    let appConfig: AppConfigService;
@ -67,15 +73,18 @@ describe('StartProcessComponent', () => {
                MatInputModule,
                MatIconModule,
                MatSelectModule,
-                MatAutocompleteModule],
+                MatAutocompleteModule
+            ],
            declarations: [StartProcessInstanceComponent],
-            providers:[ ProcessNamePipe,
-                        LocalizedDatePipe,
-                        ActivitiContentService,
-                        ProcessService,
-                        AppsProcessService,
-                        { provide: AppConfigService, useClass: AppConfigServiceMock },
-                        { provide: TranslationService, useClass: TranslationMock } ]
+            providers: [
+                ProcessNamePipe,
+                LocalizedDatePipe,
+                ActivitiContentService,
+                ProcessService,
+                AppsProcessService,
+                { provide: AppConfigService, useClass: AppConfigServiceMock },
+                { provide: TranslationService, useClass: TranslationMock }
+            ]
        });
    });

--- a/lib/process-services/src/lib/task-list/components/task-list/task-list.component.spec.ts
+++ b/lib/process-services/src/lib/task-list/components/task-list/task-list.component.spec.ts
@ -18,7 +18,17 @@
 import { Component, SimpleChange, ViewChild, OnInit, Output, EventEmitter, SimpleChanges } from '@angular/core';
 import { ComponentFixture, TestBed } from '@angular/core/testing';
 import { By } from '@angular/platform-browser';
-import { AppConfigService, DataRowEvent, ObjectDataRow, DataCellEvent, ObjectDataColumn, DataTableModule, AppConfigServiceMock, AlfrescoApiServiceMock, AlfrescoApiService } from '@alfresco/adf-core';
+import {
+    AppConfigService,
+    DataRowEvent,
+    ObjectDataRow,
+    DataCellEvent,
+    ObjectDataColumn,
+    DataTableModule,
+    AppConfigServiceMock,
+    AlfrescoApiServiceMock,
+    AlfrescoApiService
+} from '@alfresco/adf-core';
 import { TaskListService } from '../services/tasklist.service';
 import { TaskListComponent } from './task-list.component';
 import { ProcessTestingModule } from '../../../testing/process.testing.module';
@ -29,6 +39,9 @@ import { TestbedHarnessEnvironment } from '@angular/cdk/testing/testbed';
 import { HarnessLoader } from '@angular/cdk/testing';
 import { MatCheckboxHarness } from '@angular/material/checkbox/testing';
 import { MatMenuItemHarness } from '@angular/material/menu/testing';
+import { MatProgressSpinnerModule } from '@angular/material/progress-spinner';
+import { NoopAnimationsModule } from '@angular/platform-browser/animations';
+import { HttpClientTestingModule } from '@angular/common/http/testing';

 declare let jasmine: any;

@ -93,16 +106,9 @@ describe('TaskListComponent', () => {

    beforeEach(() => {
        TestBed.configureTestingModule({
-            imports: [
-                TranslateModule.forRoot(),
-                DataTableModule,
-                NoopAnimationsModule,
-                MatProgressSpinnerModule,
-                HttpClientTestingModule,
-                TaskListComponent
-            ],
+            imports: [TranslateModule.forRoot(), DataTableModule, NoopAnimationsModule, MatProgressSpinnerModule, HttpClientTestingModule, TaskListComponent],
            declarations: [TaskListComponent],
-            providers:[
+            providers: [
                TaskListService,
                { provide: AlfrescoApiService, useClass: AlfrescoApiServiceMock },
                { provide: AppConfigService, useClass: AppConfigServiceMock }
@ -792,14 +798,8 @@ describe('TaskListContextMenuComponent', () => {

    beforeEach(() => {
        TestBed.configureTestingModule({
-            imports: [
-                TranslateModule.forRoot(),
-                MatProgressSpinnerModule,
-                ProcessTestingModule
-            ],
-            declarations: [
-                TaskListContextMenuComponent
-            ]
+            imports: [TranslateModule.forRoot(), MatProgressSpinnerModule, ProcessTestingModule],
+            declarations: [TaskListContextMenuComponent]
        });
        fixture = TestBed.createComponent(TaskListContextMenuComponent);
        customComponent = fixture.componentInstance;
--- a/package-lock.json
+++ b/package-lock.json
--- a/package.json
+++ b/package.json
@ -96,6 +96,7 @@
    "zone.js": "~0.11.4"
  },
  "devDependencies": {
+    "@alfresco/eslint-plugin-eslint-angular": "file:lib/eslint-angular",
    "@angular-devkit/architect": "^0.1502.10",
    "@angular-devkit/build-angular": "15.2.10",
    "@angular-devkit/core": "15.2.10",
@ -112,9 +113,6 @@
    "@editorjs/list": "1.9.0",
    "@editorjs/marker": "1.4.0",
    "@editorjs/underline": "1.1.0",
-    "editorjs-text-color-plugin": "2.0.4",
-    "editorjs-html": "3.4.3",
-    "editorjs-paragraph-with-alignment": "3.0.0",
    "@quanzo/change-font-size": "1.0.0",
    "@nrwl/angular": "15.9.3",
    "@nrwl/cli": "15.9.3",