inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2025-09-17 14:21:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

AAE-30882 Code formatting and unit tests

Browse Source
This commit is contained in:
Wojciech Duda
2025-02-18 13:57:12 +01:00
parent 9cea847d06
commit 02df98e461
2 changed files with 69 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/js-api/src/superagentHttpClient.ts
View File

@@ -283,7 +283,7 @@ export class SuperagentHttpClient implements HttpClient {
const newParams: { [key: string]: any } = {}; const newParams: { [key: string]: any } = {};
for (const key in params) { for (const key in params) {
if (Object.prototype.hasOwnProperty.call(params, key) && params[key] !== undefined && params[key] !== null) { if (Object.prototype.hasOwnProperty.call(params, key) && params[key] !== null) {
const value = params[key]; const value = params[key];
if (SuperagentHttpClient.isFileParam(value) || Array.isArray(value)) { if (SuperagentHttpClient.isFileParam(value) || Array.isArray(value)) {
newParams[key] = value; newParams[key] = value;

68
lib/js-api/test/superagentHttpClient.spec.ts
View File

@@ -55,7 +55,9 @@ describe('SuperagentHttpClient', () => {
json: () => Promise.resolve({ data: 'test' }) json: () => Promise.resolve({ data: 'test' })
} as unknown as FetchResponse<unknown>; } as unknown as FetchResponse<unknown>;
(ofetch as unknown as jest.Mock).mockResolvedValue(fakeResponse); (ofetch as unknown as jest.Mock).mockResolvedValue(fakeResponse);
const result = await client.request(url, options, securityOptions, emitters); const result = await client.request(url, options, securityOptions, emitters);
expect(result).toEqual({ data: 'test' }); expect(result).toEqual({ data: 'test' });
expect(emitters.eventEmitter.emit).toHaveBeenCalledWith('success', { data: 'test' }); expect(emitters.eventEmitter.emit).toHaveBeenCalledWith('success', { data: 'test' });
}); });
@@ -68,6 +70,7 @@ describe('SuperagentHttpClient', () => {
text: () => Promise.resolve('Bad Request') text: () => Promise.resolve('Bad Request')
} as unknown as FetchResponse<unknown>; } as unknown as FetchResponse<unknown>;
(ofetch as unknown as jest.Mock).mockResolvedValue(fakeResponse); (ofetch as unknown as jest.Mock).mockResolvedValue(fakeResponse);
await expect(client.request(url, options, securityOptions, emitters)).rejects.toMatchObject({ status: 400 }); await expect(client.request(url, options, securityOptions, emitters)).rejects.toMatchObject({ status: 400 });
expect(emitters.apiClientEmitter.emit).toHaveBeenCalledWith('error', fakeResponse); expect(emitters.apiClientEmitter.emit).toHaveBeenCalledWith('error', fakeResponse);
expect(emitters.eventEmitter.emit).toHaveBeenCalledWith('error', fakeResponse); expect(emitters.eventEmitter.emit).toHaveBeenCalledWith('error', fakeResponse);
@@ -81,10 +84,75 @@ describe('SuperagentHttpClient', () => {
text: () => Promise.resolve('Unauthorized') text: () => Promise.resolve('Unauthorized')
} as unknown as FetchResponse<unknown>; } as unknown as FetchResponse<unknown>;
(ofetch as unknown as jest.Mock).mockResolvedValue(fakeResponse); (ofetch as unknown as jest.Mock).mockResolvedValue(fakeResponse);
await expect(client.request(url, options, securityOptions, emitters)).rejects.toMatchObject({ status: 401 }); await expect(client.request(url, options, securityOptions, emitters)).rejects.toMatchObject({ status: 401 });
expect(emitters.apiClientEmitter.emit).toHaveBeenCalledWith('unauthorized'); expect(emitters.apiClientEmitter.emit).toHaveBeenCalledWith('unauthorized');
expect(emitters.eventEmitter.emit).toHaveBeenCalledWith('unauthorized'); expect(emitters.eventEmitter.emit).toHaveBeenCalledWith('unauthorized');
}); });
it('should reject with network error when fetch fails', async () => {
const networkError = new Error('Network failure');
(ofetch as unknown as jest.Mock).mockRejectedValue(networkError);
await expect(client.request(url, options, defaultSecurityOptions, emitters)).rejects.toEqual(networkError);
expect(emitters.apiClientEmitter.emit).toHaveBeenCalledWith('error', networkError);
expect(emitters.eventEmitter.emit).toHaveBeenCalledWith('error', networkError);
});
it('should parse text/html response correctly', async () => {
const htmlResponse = {
ok: true,
headers: new Map([['content-type', 'text/html']]),
json: () => Promise.reject(new Error('Not JSON')),
text: () => Promise.resolve('<html><body>HTML Content</body></html>')
} as unknown as FetchResponse<unknown>;
(ofetch as unknown as jest.Mock).mockResolvedValue(htmlResponse);
const result = await client.request('http://fake-api/test', defaultRequestOptions, defaultSecurityOptions, emitters);
expect(result).toEqual('<html><body>HTML Content</body></html>');
expect(emitters.eventEmitter.emit).toHaveBeenCalledWith('success', '<html><body>HTML Content</body></html>');
});
it('should include custom headers from headerParams', async () => {
const customOptions: RequestOptions = {
...defaultRequestOptions,
headerParams: { 'X-Custom-Header': 'customValue' }
};
// Return a successful JSON response
const fakeResponse = {
ok: true,
headers: new Map([['content-type', 'application/json']]),
json: () => Promise.resolve({ data: 'with-custom-header' })
} as unknown as FetchResponse<unknown>;
(ofetch as unknown as jest.Mock).mockResolvedValue(fakeResponse);
await client.request(url, customOptions, securityOptions, emitters);
const fetchCallArgs = (ofetch as unknown as jest.Mock).mock.calls[0];
const fetchOptions = fetchCallArgs[1];
expect(fetchOptions.headers['x-custom-header']).toEqual('customValue');
});
it('should include headers from securityOptions.defaultHeaders', async () => {
const securityOptionsWithDefault = {
...defaultSecurityOptions,
defaultHeaders: { 'X-Default-Header': 'defaultValue' }
};
const fakeResponse = {
ok: true,
headers: new Map([['content-type', 'application/json']]),
json: () => Promise.resolve({ data: 'with-default-header' })
} as unknown as FetchResponse<unknown>;
(ofetch as unknown as jest.Mock).mockResolvedValue(fakeResponse);
await client.request(url, defaultRequestOptions, securityOptionsWithDefault, emitters);
const fetchCallArgs = (ofetch as unknown as jest.Mock).mock.calls[0];
const fetchOptions = fetchCallArgs[1];
expect(fetchOptions.headers['x-default-header']).toEqual('defaultValue');
});
}); });
describe('buildRequest', () => { describe('buildRequest', () => {