[MIGRATION] - Migrating to NG18

lib/process-services/.eslintrc.json

@@ -4,7 +4,7 @@
   "overrides": [
     {
       "files": ["*.ts"],
-      "extends": ["plugin:@nrwl/nx/angular"],
+      "extends": ["plugin:@nx/angular"],
       "parserOptions": {
         "project": ["lib/process-services/tsconfig.lib.json", "lib/process-services/tsconfig.spec.json"],
         "createDefaultProgram": true
@@ -14,7 +14,12 @@
         "@typescript-eslint/naming-convention": "warn",
         "@typescript-eslint/consistent-type-assertions": "warn",
         "@typescript-eslint/prefer-for-of": "warn",
-        "no-underscore-dangle": ["error", { "allowAfterThis": true }],
+        "no-underscore-dangle": [
+          "error",
+          {
+            "allowAfterThis": true
+          }
+        ],
         "no-shadow": "warn",
         "quote-props": "warn",
         "object-shorthand": "warn",
@@ -22,7 +27,6 @@
         "arrow-body-style": "warn",
         "@angular-eslint/no-output-native": "off",
         "space-before-function-paren": "warn",
-
         "@angular-eslint/component-selector": [
           "error",
           {
@@ -75,7 +79,7 @@
     },
     {
       "files": ["*.html"],
-      "extends": ["plugin:@nrwl/nx/angular-template"],
+      "extends": ["plugin:@nx/angular-template"],
       "parserOptions": {
         "project": ["lib/process-services/tsconfig.lib.json", "lib/process-services/tsconfig.spec.json"],
         "createDefaultProgram": true

lib/process-services/src/lib/form/widgets/file-viewer/file-viewer.widget.spec.ts

@@ -28,8 +28,9 @@ import {
 } from '@alfresco/adf-core';
 import { TranslateModule } from '@ngx-translate/core';
 import { CUSTOM_ELEMENTS_SCHEMA } from '@angular/core';
-import { HttpClientTestingModule } from '@angular/common/http/testing';
+import { provideHttpClientTesting } from '@angular/common/http/testing';
 import { EMPTY, of } from 'rxjs';
+import { provideHttpClient, withInterceptorsFromDi } from '@angular/common/http';
 
 describe('FileViewerWidgetComponent', () => {
     const fakeForm = new FormModel();
@@ -54,15 +55,17 @@ describe('FileViewerWidgetComponent', () => {
 
     beforeEach(() => {
         TestBed.configureTestingModule({
-            imports: [TranslateModule.forRoot(), FileViewerWidgetComponent, HttpClientTestingModule],
-            providers: [
-                { provide: FormService, useValue: formServiceStub },
-                { provide: TranslationService, useClass: TranslationMock },
-                AuthenticationService,
-                { provide: RedirectAuthService, useValue: { onLogin: EMPTY, onTokenReceived: of() } }
-            ],
-            schemas: [CUSTOM_ELEMENTS_SCHEMA]
-        });
+    schemas: [CUSTOM_ELEMENTS_SCHEMA],
+    imports: [TranslateModule.forRoot(), FileViewerWidgetComponent],
+    providers: [
+        { provide: FormService, useValue: formServiceStub },
+        { provide: TranslationService, useClass: TranslationMock },
+        AuthenticationService,
+        { provide: RedirectAuthService, useValue: { onLogin: EMPTY, onTokenReceived: of() } },
+        provideHttpClient(withInterceptorsFromDi()),
+        provideHttpClientTesting()
+    ]
+});
 
         formServiceStub = TestBed.inject(FormService);
         fixture = TestBed.createComponent(FileViewerWidgetComponent);

lib/process-services/src/lib/form/widgets/radio-buttons/radio-buttons.widget.spec.ts

@@ -43,7 +43,7 @@ import { HarnessLoader } from '@angular/cdk/testing';
 import { TestbedHarnessEnvironment } from '@angular/cdk/testing/testbed';
 import { MatRadioButtonHarness, MatRadioGroupHarness } from '@angular/material/radio/testing';
 import { MatButtonModule } from '@angular/material/button';
-import { HttpClientTestingModule } from '@angular/common/http/testing';
+import {} from '@angular/common/http/testing';
 
 describe('RadioButtonsWidgetComponent', () => {
     let formService: FormService;

lib/process-services/src/lib/process-list/components/start-process/start-process.component.spec.ts

@@ -43,7 +43,7 @@ import { MatFormFieldHarness } from '@angular/material/form-field/testing';
 import { TestbedHarnessEnvironment } from '@angular/cdk/testing/testbed';
 import { MatAutocompleteHarness } from '@angular/material/autocomplete/testing';
 import { NoopAnimationsModule } from '@angular/platform-browser/animations';
-import { HttpClientTestingModule } from '@angular/common/http/testing';
+import {} from '@angular/common/http/testing';
 import { RestVariable } from '@alfresco/js-api';
 import { ActivitiContentService } from '../../../form/services/activiti-alfresco.service';
 import { AppsProcessService } from '../../../services/apps-process.service';

lib/process-services/src/lib/task-list/components/task-list/task-list.component.spec.ts

@@ -40,7 +40,8 @@ import { MatCheckboxHarness } from '@angular/material/checkbox/testing';
 import { MatMenuItemHarness } from '@angular/material/menu/testing';
 import { MatProgressSpinnerModule } from '@angular/material/progress-spinner';
 import { NoopAnimationsModule } from '@angular/platform-browser/animations';
-import { HttpClientTestingModule } from '@angular/common/http/testing';
+import { provideHttpClientTesting } from '@angular/common/http/testing';
+import { provideHttpClient, withInterceptorsFromDi } from '@angular/common/http';
 
 declare let jasmine: any;
 
@@ -105,13 +106,15 @@ describe('TaskListComponent', () => {
 
     beforeEach(() => {
         TestBed.configureTestingModule({
-            imports: [TranslateModule.forRoot(), NoopAnimationsModule, MatProgressSpinnerModule, HttpClientTestingModule, TaskListComponent],
-            providers: [
-                TaskListService,
-                { provide: AlfrescoApiService, useClass: AlfrescoApiServiceMock },
-                { provide: AppConfigService, useClass: AppConfigServiceMock }
-            ]
-        });
+    imports: [TranslateModule.forRoot(), NoopAnimationsModule, MatProgressSpinnerModule, TaskListComponent],
+    providers: [
+        TaskListService,
+        { provide: AlfrescoApiService, useClass: AlfrescoApiServiceMock },
+        { provide: AppConfigService, useClass: AppConfigServiceMock },
+        provideHttpClient(withInterceptorsFromDi()),
+        provideHttpClientTesting()
+    ]
+});
         appConfig = TestBed.inject(AppConfigService);
         appConfig.config.bpmHost = 'http://localhost:9876/bpm';
 

lib/process-services/src/lib/testing/process.testing.module.ts

@@ -32,25 +32,21 @@ import {
 import { TranslateModule } from '@ngx-translate/core';
 import { ProcessFormRenderingService } from '../form/process-form-rendering.service';
 import { RouterTestingModule } from '@angular/router/testing';
-import { HttpClientTestingModule } from '@angular/common/http/testing';
+import { provideHttpClientTesting } from '@angular/common/http/testing';
+import { provideHttpClient, withInterceptorsFromDi } from '@angular/common/http';
 
-@NgModule({
-    imports: [
-        AuthModule.forRoot({ useHash: true }),
+@NgModule({ exports: [NoopAnimationsModule, TranslateModule, CoreModule, ProcessModule], imports: [AuthModule.forRoot({ useHash: true }),
         NoopAnimationsModule,
-        HttpClientTestingModule,
         TranslateModule.forRoot(),
         CoreModule.forRoot(),
         ProcessModule.forRoot(),
-        RouterTestingModule
-    ],
-    providers: [
+        RouterTestingModule], providers: [
         { provide: AlfrescoApiService, useClass: AlfrescoApiServiceMock },
         { provide: AppConfigService, useClass: AppConfigServiceMock },
         { provide: TranslationService, useClass: TranslationMock },
         FormRenderingService,
-        { provide: FormRenderingService, useClass: ProcessFormRenderingService }
-    ],
-    exports: [NoopAnimationsModule, TranslateModule, CoreModule, ProcessModule]
-})
+        { provide: FormRenderingService, useClass: ProcessFormRenderingService },
+        provideHttpClient(withInterceptorsFromDi()),
+        provideHttpClientTesting()
+    ] })
 export class ProcessTestingModule {}