[ADF-2500] fix trashcan bug plus refactoring documentlist (#3136)

* [ADF-2500] The full content of Trashcan is not displayed.

fix pagination problem and add tests

* refactor code

* custom resources services

* move custom resources in separate service part 2

* move custom resources in separate service part 3

* move isCustomResources in custom resources

* move getCorrispondinNodeIds in custom services

* reorganize code

* add pagination interface

* remove permissions check document list and use the common cs method
remove the merge option and move it in the paginator

* make infinte scrolling always use the target

* restore loading infinite page

* fix license header

* fix type problems

* breadcrumb test service

* fix test

* export CustomResourcesService

* fix test pagination

* fix content ndoe test

* remove timeout content node selector test

* fix after rebase

* ripristinate observalbe in search service

* fix wrong type return stub document list test

* fix search service

* fix test document list

* move handle error in common method

* restore observable in search control

* Update search-control.component.spec.ts

* fix after rebase

* add import switchmap

* core import in karma conf

* missing commas

* fix mocks

* fix mock searchquerybody

* search test fix

lib/content-services/permission-manager/components/permission-list/permission-list.component.spec.ts

@@ -42,7 +42,7 @@ describe('PermissionDisplayComponent', () => {
             declarations: [
                 PermissionListComponent
             ],
-            providers: [NodesApiService, NodePermissionService]
+            providers: [NodePermissionService]
         }).compileComponents().then(() => {
             fixture = TestBed.createComponent(PermissionListComponent);
             component = fixture.componentInstance;
@@ -66,7 +66,7 @@ describe('PermissionDisplayComponent', () => {
     it('should show the node permissions', () => {
         component.nodeId = 'fake-node-id';
         spyOn(nodeService, 'getNode').and.returnValue(Observable.of(fakeNodeWithPermissions));
-        spyOn(searchApiService, 'searchByQueryBody').and.returnValue(Promise.resolve(fakeEmptyResponse));
+        spyOn(searchApiService, 'searchByQueryBody').and.returnValue(Observable.of(fakeEmptyResponse));
         fixture.detectChanges();
         expect(element.querySelector('#adf-permission-display-container')).not.toBeNull();
         expect(element.querySelectorAll('.adf-datatable-row').length).toBe(4);
@@ -75,7 +75,7 @@ describe('PermissionDisplayComponent', () => {
     it('should show inherited label for inherited permissions', () => {
         component.nodeId = 'fake-node-id';
         spyOn(nodeService, 'getNode').and.returnValue(Observable.of(fakeNodeInheritedOnly));
-        spyOn(searchApiService, 'searchByQueryBody').and.returnValue(Promise.resolve(fakeEmptyResponse));
+        spyOn(searchApiService, 'searchByQueryBody').and.returnValue(Observable.of(fakeEmptyResponse));
         fixture.detectChanges();
         expect(element.querySelector('#adf-permission-display-container')).not.toBeNull();
         expect(element.querySelector('#adf-permission-inherited-label')).toBeDefined();
@@ -88,7 +88,7 @@ describe('PermissionDisplayComponent', () => {
             component.nodeId = 'fake-node-id';
             spyOn(nodeService, 'getNode').and.returnValue(Observable.of(fakeNodeWithOnlyLocally));
             spyOn(nodePermissionService, 'getGroupMemeberByGroupName').and.returnValue(Observable.of(fakeSiteRoles));
-            spyOn(searchApiService, 'searchByQueryBody').and.returnValue(Promise.resolve(fakeSiteNodeResponse));
+            spyOn(searchApiService, 'searchByQueryBody').and.returnValue(Observable.of(fakeSiteNodeResponse));
             fixture.detectChanges();
             expect(element.querySelector('#adf-permission-display-container')).not.toBeNull();
             expect(element.querySelector('#adf-permission-locallyset-label')).toBeDefined();
@@ -99,7 +99,7 @@ describe('PermissionDisplayComponent', () => {
             component.nodeId = 'fake-node-id';
             spyOn(nodeService, 'getNode').and.returnValue(Observable.of(fakeNodeWithOnlyLocally));
             spyOn(nodePermissionService, 'getGroupMemeberByGroupName').and.returnValue(Observable.of(fakeSiteRoles));
-            spyOn(searchApiService, 'searchByQueryBody').and.returnValue(Promise.resolve(fakeSiteNodeResponse));
+            spyOn(searchApiService, 'searchByQueryBody').and.returnValue(Observable.of(fakeSiteNodeResponse));
             fixture.detectChanges();
             fixture.whenStable().then(() => {
                 fixture.detectChanges();
@@ -124,7 +124,7 @@ describe('PermissionDisplayComponent', () => {
         it('should show the settable roles if the node is not in any site',  async(() => {
             component.nodeId = 'fake-node-id';
             spyOn(nodeService, 'getNode').and.returnValue(Observable.of(fakeNodeWithOnlyLocally));
-            spyOn(searchApiService, 'searchByQueryBody').and.returnValue(Promise.resolve(fakeEmptyResponse));
+            spyOn(searchApiService, 'searchByQueryBody').and.returnValue(Observable.of(fakeEmptyResponse));
             fixture.detectChanges();
             fixture.whenStable().then(() => {
                 fixture.detectChanges();
@@ -151,7 +151,7 @@ describe('PermissionDisplayComponent', () => {
             component.nodeId = 'fake-node-id';
             spyOn(nodeService, 'getNode').and.returnValue(Observable.of(fakeNodeWithOnlyLocally));
             spyOn(nodeService, 'updateNode').and.returnValue(Observable.of({id: 'fake-updated-node'}));
-            spyOn(searchApiService, 'searchByQueryBody').and.returnValue(Promise.resolve(fakeEmptyResponse));
+            spyOn(searchApiService, 'searchByQueryBody').and.returnValue(Observable.of(fakeEmptyResponse));
             component.update.subscribe((updatedPermission) => {
                 expect(updatedPermission).not.toBeNull();
                 expect(updatedPermission.name).toBe('Editor');

lib/content-services/permission-manager/services/node-permission.service.spec.ts

@@ -17,7 +17,7 @@
 
 import { async, TestBed } from '@angular/core/testing';
 import { NodePermissionService } from './node-permission.service';
-import { AlfrescoApiService, SearchService, NodesApiService } from '@alfresco/adf-core';
+import { SearchService, NodesApiService } from '@alfresco/adf-core';
 import { MinimalNodeEntryEntity, PermissionElement } from 'alfresco-js-api';
 import { Observable } from 'rxjs/Observable';
 import { fakeEmptyResponse, fakeNodeWithOnlyLocally, fakeSiteRoles, fakeSiteNodeResponse } from '../../mock/permission-list.component.mock';
@@ -31,8 +31,7 @@ describe('NodePermissionService', () => {
     beforeEach(async(() => {
         TestBed.configureTestingModule({
             providers: [
-                AlfrescoApiService,
-                NodePermissionService, SearchService, NodesApiService
+                NodePermissionService
             ]
         }).compileComponents();
     }));
@@ -55,7 +54,7 @@ describe('NodePermissionService', () => {
     }
 
     it('should return a list of roles taken from the site groups', async(() => {
-        spyOn(searchApiService, 'searchByQueryBody').and.returnValue(Promise.resolve(fakeSiteNodeResponse));
+        spyOn(searchApiService, 'searchByQueryBody').and.returnValue(Observable.of(fakeSiteNodeResponse));
         spyOn(service, 'getGroupMemeberByGroupName').and.returnValue(Observable.of(fakeSiteRoles));
 
         service.getNodeRoles(fakeNodeWithOnlyLocally).subscribe((roleArray: string[]) => {
@@ -66,7 +65,7 @@ describe('NodePermissionService', () => {
     }));
 
     it('should return a list of settable if node has no site', async(() => {
-        spyOn(searchApiService, 'searchByQueryBody').and.returnValue(Promise.resolve(fakeEmptyResponse));
+        spyOn(searchApiService, 'searchByQueryBody').and.returnValue(Observable.of(fakeEmptyResponse));
 
         service.getNodeRoles(fakeNodeWithOnlyLocally).subscribe((roleArray: string[]) => {
             expect(roleArray).not.toBeNull();

lib/content-services/permission-manager/services/node-permission.service.ts

@@ -19,6 +19,7 @@ import { Injectable } from '@angular/core';
 import { Observable } from 'rxjs/Observable';
 import { AlfrescoApiService, SearchService, NodesApiService } from '@alfresco/adf-core';
 import { QueryBody, MinimalNodeEntryEntity, PathElement, GroupMemberEntry, GroupsPaging, GroupMemberPaging, PermissionElement } from 'alfresco-js-api';
+import 'rxjs/add/operator/switchMap';
 
 @Injectable()
 export class NodePermissionService {
@@ -30,7 +31,7 @@ export class NodePermissionService {
 
     getNodeRoles(node: MinimalNodeEntryEntity): Observable<string[]> {
         const retrieveSiteQueryBody: QueryBody = this.buildRetrieveSiteQueryBody(node.path.elements);
-        return Observable.fromPromise(this.searchApiService.searchByQueryBody(retrieveSiteQueryBody))
+        return this.searchApiService.searchByQueryBody(retrieveSiteQueryBody)
             .switchMap((siteNodeList: any) => {
                 if ( siteNodeList.list.entries.length > 0 ) {
                     let siteName = siteNodeList.list.entries[0].entry.name;