[ADF-2500] fix trashcan bug plus refactoring documentlist (#3136)

* [ADF-2500] The full content of Trashcan is not displayed.

fix pagination problem and add tests

* refactor code

* custom resources services

* move custom resources in separate service part 2

* move custom resources in separate service part 3

* move isCustomResources in custom resources

* move getCorrispondinNodeIds in custom services

* reorganize code

* add pagination interface

* remove permissions check document list and use the common cs method
remove the merge option and move it in the paginator

* make infinte scrolling always use the target

* restore loading infinite page

* fix license header

* fix type problems

* breadcrumb test service

* fix test

* export CustomResourcesService

* fix test pagination

* fix content ndoe test

* remove timeout content node selector test

* fix after rebase

* ripristinate observalbe in search service

* fix wrong type return stub document list test

* fix search service

* fix test document list

* move handle error in common method

* restore observable in search control

* Update search-control.component.spec.ts

* fix after rebase

* add import switchmap

* core import in karma conf

* missing commas

* fix mocks

* fix mock searchquerybody

* search test fix

lib/core/services/content.service.ts

@@ -17,7 +17,7 @@
 
 import { Injectable } from '@angular/core';
 import { DomSanitizer } from '@angular/platform-browser';
-import { ContentApi, MinimalNodeEntryEntity } from 'alfresco-js-api';
+import { ContentApi, MinimalNodeEntryEntity, Node } from 'alfresco-js-api';
 import { Observable } from 'rxjs/Observable';
 import { Subject } from 'rxjs/Subject';
 import { FolderCreatedEvent } from '../events/folder-created.event';
@@ -197,14 +197,14 @@ export class ContentService {
      * @param permission Create, delete, update, updatePermissions, !create, !delete, !update, !updatePermissions
      *
      */
-    hasPermission(node: any, permission: PermissionsEnum | string): boolean {
+    hasPermission(node: Node, permission: PermissionsEnum | string): boolean {
         let hasPermission = false;
 
         if (this.hasAllowableOperations(node)) {
             if (permission && permission.startsWith('!')) {
-                hasPermission = !~node.allowableOperations.indexOf(permission.replace('!', ''));
+                hasPermission = node.allowableOperations.find(currentPermission => currentPermission === permission.replace('!', '')) ? false : true;
             } else {
-                hasPermission = !!~node.allowableOperations.indexOf(permission);
+                hasPermission = node.allowableOperations.find(currentPermission => currentPermission === permission) ? true : false;
             }
 
         } else {

lib/core/services/search.service.spec.ts

@@ -57,7 +57,7 @@ describe('SearchService', () => {
     it('should call search API with no additional options', (done) => {
         let searchTerm = 'searchTerm63688';
         spyOn(searchMockApi.core.queriesApi, 'findNodes').and.returnValue(Promise.resolve(fakeSearch));
-        service.getNodeQueryResults(searchTerm).then(
+        service.getNodeQueryResults(searchTerm).subscribe(
             () => {
                 expect(searchMockApi.core.queriesApi.findNodes).toHaveBeenCalledWith(searchTerm, undefined);
                 done();
@@ -72,7 +72,7 @@ describe('SearchService', () => {
             nodeType: 'cm:content'
         };
         spyOn(searchMockApi.core.queriesApi, 'findNodes').and.returnValue(Promise.resolve(fakeSearch));
-        service.getNodeQueryResults(searchTerm, options).then(
+        service.getNodeQueryResults(searchTerm, options).subscribe(
             () => {
                 expect(searchMockApi.core.queriesApi.findNodes).toHaveBeenCalledWith(searchTerm, options);
                 done();
@@ -81,7 +81,7 @@ describe('SearchService', () => {
     });
 
     it('should return search results returned from the API', (done) => {
-        service.getNodeQueryResults('').then(
+        service.getNodeQueryResults('').subscribe(
             (res: any) => {
                 expect(res).toBeDefined();
                 expect(res).toEqual(fakeSearch);
@@ -92,7 +92,7 @@ describe('SearchService', () => {
 
     it('should notify errors returned from the API', (done) => {
         spyOn(searchMockApi.core.queriesApi, 'findNodes').and.returnValue(Promise.reject(mockError));
-        service.getNodeQueryResults('').then(
+        service.getNodeQueryResults('').subscribe(
             () => {},
             (res: any) => {
                 expect(res).toBeDefined();

lib/core/services/search.service.ts

@@ -17,11 +17,11 @@
 
 import { Injectable } from '@angular/core';
 import { NodePaging, QueryBody } from 'alfresco-js-api';
-import 'rxjs/add/observable/throw';
-import { Subject } from 'rxjs/Subject';
-
+import { Observable } from 'rxjs/Observable';
 import { AlfrescoApiService } from './alfresco-api.service';
+import 'rxjs/add/observable/throw';
 import { SearchConfigurationService } from './search-configuration.service';
+import { Subject } from 'rxjs/Subject';
 
 @Injectable()
 export class SearchService {
@@ -32,26 +32,45 @@ export class SearchService {
                 private searchConfigurationService: SearchConfigurationService) {
     }
 
-    async getNodeQueryResults(term: string, options?: SearchOptions): Promise<NodePaging> {
-        const data = await this.apiService.getInstance().core.queriesApi.findNodes(term, options);
+    getNodeQueryResults(term: string, options?: SearchOptions): Observable<NodePaging> {
+        const promise = this.apiService.getInstance().core.queriesApi.findNodes(term, options);
 
-        this.dataLoaded.next(data);
-        return data;
+        promise.then((data: any) => {
+            this.dataLoaded.next(data);
+        });
+
+        return Observable
+            .fromPromise(promise)
+            .catch(err => this.handleError(err));
     }
 
-    async search(searchTerm: string, maxResults: number, skipCount: number): Promise<NodePaging> {
-        const searchQuery = this.searchConfigurationService.generateQueryBody(searchTerm, maxResults, skipCount);
-        const data = await this.apiService.searchApi.search(searchQuery);
+    search(searchTerm: string, maxResults: number, skipCount: number): Observable<NodePaging> {
+        const searchQuery = Object.assign(this.searchConfigurationService.generateQueryBody(searchTerm, maxResults, skipCount));
+        const promise = this.apiService.getInstance().search.searchApi.search(searchQuery);
 
-        this.dataLoaded.next(data);
-        return data;
+        promise.then((data: any) => {
+            this.dataLoaded.next(data);
+        });
+
+        return Observable
+            .fromPromise(promise)
+            .catch(err => this.handleError(err));
     }
 
-    async searchByQueryBody(queryBody: QueryBody): Promise<NodePaging> {
-        const data = await this.apiService.searchApi.search(queryBody);
+    searchByQueryBody(queryBody: QueryBody): Observable<NodePaging> {
+        const promise = this.apiService.getInstance().search.searchApi.search(queryBody);
 
-        this.dataLoaded.next(data);
-        return data;
+        promise.then((data: any) => {
+            this.dataLoaded.next(data);
+        });
+
+        return Observable
+            .fromPromise(promise)
+            .catch(err => this.handleError(err));
+    }
+
+    private handleError(error: any): Observable<any> {
+        return Observable.throw(error || 'Server error');
     }
 }