remove console log error from version list and content node selector test stubbing necessary method

This commit is contained in:
Eugenio Romano
2018-05-30 11:22:03 +01:00
parent 9eae0fcc8f
commit 08165d6fd4
2 changed files with 10 additions and 4 deletions

View File

@@ -22,7 +22,7 @@ import { ComponentFixture, TestBed } from '@angular/core/testing';
import { ContentNodeSelectorComponent } from './content-node-selector.component'; import { ContentNodeSelectorComponent } from './content-node-selector.component';
import { MinimalNodeEntryEntity } from 'alfresco-js-api'; import { MinimalNodeEntryEntity } from 'alfresco-js-api';
import { By } from '@angular/platform-browser'; import { By } from '@angular/platform-browser';
import { setupTestBed } from '@alfresco/adf-core'; import { setupTestBed, SitesService } from '@alfresco/adf-core';
import { Observable } from 'rxjs/Observable'; import { Observable } from 'rxjs/Observable';
import { ContentTestingModule } from '../testing/content.testing.module'; import { ContentTestingModule } from '../testing/content.testing.module';
import { DocumentListService } from '../document-list/services/document-list.service'; import { DocumentListService } from '../document-list/services/document-list.service';
@@ -36,7 +36,8 @@ describe('ContentNodeSelectorDialogComponent', () => {
title: 'Move along citizen...', title: 'Move along citizen...',
actionName: 'move', actionName: 'move',
select: new EventEmitter<MinimalNodeEntryEntity>(), select: new EventEmitter<MinimalNodeEntryEntity>(),
rowFilter: () => {}, rowFilter: () => {
},
imageResolver: () => 'piccolo', imageResolver: () => 'piccolo',
currentFolderId: 'cat-girl-nuku-nuku' currentFolderId: 'cat-girl-nuku-nuku'
}; };
@@ -51,8 +52,10 @@ describe('ContentNodeSelectorDialogComponent', () => {
beforeEach(() => { beforeEach(() => {
const documentListService: DocumentListService = TestBed.get(DocumentListService); const documentListService: DocumentListService = TestBed.get(DocumentListService);
const sitesService: SitesService = TestBed.get(SitesService);
spyOn(documentListService, 'getFolder').and.returnValue(Observable.of({ list: [] })); spyOn(documentListService, 'getFolder').and.returnValue(Observable.of({ list: [] }));
spyOn(documentListService, 'getFolderNode').and.returnValue(Observable.of({})); spyOn(documentListService, 'getFolderNode').and.returnValue(Observable.of({}));
spyOn(sitesService, 'getSites').and.returnValue(Observable.of({ list: { entries: [] } }));
fixture = TestBed.createComponent(ContentNodeSelectorComponent); fixture = TestBed.createComponent(ContentNodeSelectorComponent);
component = fixture.componentInstance; component = fixture.componentInstance;
@@ -108,8 +111,10 @@ describe('ContentNodeSelectorDialogComponent', () => {
it('should complete the data stream when user click "CANCEL"', () => { it('should complete the data stream when user click "CANCEL"', () => {
let cancelButton; let cancelButton;
data.select.subscribe( data.select.subscribe(
() => { }, () => {
() => { }, },
() => {
},
() => { () => {
cancelButton = fixture.debugElement.query(By.css('[data-automation-id="content-node-selector-actions-cancel"]')); cancelButton = fixture.debugElement.query(By.css('[data-automation-id="content-node-selector-actions-cancel"]'));
expect(cancelButton).not.toBeNull(); expect(cancelButton).not.toBeNull();

View File

@@ -76,6 +76,7 @@ describe('VersionListComponent', () => {
}); });
it('should delete the version if user confirms', () => { it('should delete the version if user confirms', () => {
spyOn(alfrescoApiService.versionsApi, 'listVersionHistory').and.returnValue(Promise.resolve({ list: { entries: [] } }));
spyOn(dialog, 'open').and.returnValue({ spyOn(dialog, 'open').and.returnValue({
afterClosed() { afterClosed() {
return Observable.of(true); return Observable.of(true);