[no-issue] improve test part 1 PS (#3006)

* remove testbed service process services

* add appconfig in test log

* test import fix
This commit is contained in:
Eugenio Romano
2018-02-26 20:23:29 +00:00
committed by GitHub
parent 7e8e5f371f
commit 0a266bebdc
4 changed files with 14 additions and 38 deletions

View File

@@ -15,13 +15,12 @@
* limitations under the License. * limitations under the License.
*/ */
import { TestBed } from '@angular/core/testing';
import { async } from '@angular/core/testing'; import { async } from '@angular/core/testing';
import { AlfrescoApi } from 'alfresco-js-api'; import { AlfrescoApi } from 'alfresco-js-api';
import { AlfrescoApiService } from '@alfresco/adf-core';
import { mockError, fakeProcessFilters } from '../../mock'; import { mockError, fakeProcessFilters } from '../../mock';
import { FilterProcessRepresentationModel } from '../models/filter-process.model'; import { FilterProcessRepresentationModel } from '../models/filter-process.model';
import { ProcessFilterService } from './process-filter.service'; import { ProcessFilterService } from './process-filter.service';
import { AlfrescoApiService, AppConfigService, StorageService } from '@alfresco/adf-core';
declare let jasmine: any; declare let jasmine: any;
@@ -32,14 +31,8 @@ describe('Process filter', () => {
let alfrescoApi: AlfrescoApi; let alfrescoApi: AlfrescoApi;
beforeEach(() => { beforeEach(() => {
TestBed.configureTestingModule({ apiService = new AlfrescoApiService(new AppConfigService(null), new StorageService() );
service = new ProcessFilterService(apiService);
providers: [
ProcessFilterService
]
});
service = TestBed.get(ProcessFilterService);
apiService = TestBed.get(AlfrescoApiService);
alfrescoApi = apiService.getInstance(); alfrescoApi = apiService.getInstance();
}); });

View File

@@ -15,15 +15,14 @@
* limitations under the License. * limitations under the License.
*/ */
import { TestBed } from '@angular/core/testing';
import { async } from '@angular/core/testing'; import { async } from '@angular/core/testing';
import { AlfrescoApi } from 'alfresco-js-api'; import { AlfrescoApi } from 'alfresco-js-api';
import { AlfrescoApiService } from '@alfresco/adf-core';
import { exampleProcess, fakeProcessInstances } from '../../mock'; import { exampleProcess, fakeProcessInstances } from '../../mock';
import { mockError, fakeProcessDef, fakeTasksList } from '../../mock'; import { mockError, fakeProcessDef, fakeTasksList } from '../../mock';
import { ProcessFilterParamRepresentationModel } from '../models/filter-process.model'; import { ProcessFilterParamRepresentationModel } from '../models/filter-process.model';
import { ProcessInstanceVariable } from '../models/process-instance-variable.model'; import { ProcessInstanceVariable } from '../models/process-instance-variable.model';
import { ProcessService } from './process.service'; import { ProcessService } from './process.service';
import { AlfrescoApiService, AppConfigService, StorageService } from '@alfresco/adf-core';
declare let moment: any; declare let moment: any;
@@ -34,13 +33,8 @@ describe('ProcessService', () => {
let alfrescoApi: AlfrescoApi; let alfrescoApi: AlfrescoApi;
beforeEach(() => { beforeEach(() => {
TestBed.configureTestingModule({ apiService = new AlfrescoApiService(new AppConfigService(null), new StorageService() );
providers: [ service = new ProcessService(apiService);
ProcessService
]
});
service = TestBed.get(ProcessService);
apiService = TestBed.get(AlfrescoApiService);
alfrescoApi = apiService.getInstance(); alfrescoApi = apiService.getInstance();
}); });

View File

@@ -15,7 +15,7 @@
* limitations under the License. * limitations under the License.
*/ */
import { async, TestBed } from '@angular/core/testing'; import { async } from '@angular/core/testing';
import { import {
fakeAppFilter, fakeAppFilter,
fakeAppPromise, fakeAppPromise,
@@ -23,22 +23,16 @@ import {
} from '../../mock'; } from '../../mock';
import { FilterRepresentationModel } from '../models/filter.model'; import { FilterRepresentationModel } from '../models/filter.model';
import { TaskFilterService } from './task-filter.service'; import { TaskFilterService } from './task-filter.service';
import { AlfrescoApiService, LogService, AppConfigService, StorageService } from '@alfresco/adf-core';
declare let jasmine: any; declare let jasmine: any;
describe('Activiti Task filter Service', () => { describe('Activiti Task filter Service', () => {
let service: TaskFilterService; let service: TaskFilterService;
beforeEach(async(() => { beforeEach(async(() => {
TestBed.configureTestingModule({ service = new TaskFilterService(new AlfrescoApiService(new AppConfigService(null), new StorageService()), new LogService(new AppConfigService(null)));
providers: [ jasmine.Ajax.install();
TaskFilterService
]
}).compileComponents().then(() => {
service = TestBed.get(TaskFilterService);
jasmine.Ajax.install();
});
})); }));
afterEach(() => { afterEach(() => {

View File

@@ -15,7 +15,7 @@
* limitations under the License. * limitations under the License.
*/ */
import { async, TestBed } from '@angular/core/testing'; import { async } from '@angular/core/testing';
import { UserProcessModel } from '@alfresco/adf-core'; import { UserProcessModel } from '@alfresco/adf-core';
import { Observable } from 'rxjs/Observable'; import { Observable } from 'rxjs/Observable';
import { import {
@@ -37,6 +37,7 @@ import {
import { FilterRepresentationModel, TaskQueryRequestRepresentationModel } from '../models/filter.model'; import { FilterRepresentationModel, TaskQueryRequestRepresentationModel } from '../models/filter.model';
import { TaskDetailsModel } from '../models/task-details.model'; import { TaskDetailsModel } from '../models/task-details.model';
import { TaskListService } from './tasklist.service'; import { TaskListService } from './tasklist.service';
import { AlfrescoApiService, LogService, AppConfigService, StorageService } from '@alfresco/adf-core';
declare let jasmine: any; declare let jasmine: any;
@@ -45,14 +46,8 @@ describe('Activiti TaskList Service', () => {
let service: TaskListService; let service: TaskListService;
beforeEach(async(() => { beforeEach(async(() => {
TestBed.configureTestingModule({ service = new TaskListService(new AlfrescoApiService(new AppConfigService(null), new StorageService() ), new LogService(new AppConfigService(null)));
providers: [ jasmine.Ajax.install();
TaskListService
]
}).compileComponents().then(() => {
service = TestBed.get(TaskListService);
jasmine.Ajax.install();
});
})); }));
afterEach(() => { afterEach(() => {