From 0b2e218b88ce67279afdaaedefb050330f7f6cae Mon Sep 17 00:00:00 2001
From: Pablo Martinez Garcia <pmartinezga@gmail.com>
Date: Wed, 11 May 2022 11:18:38 +0200
Subject: [PATCH] Add eslint ban rule (#7611)

---
 .eslintrc.json                                      | 13 ++++++++++++-
 .../components/widgets/widget.component.spec.ts     |  2 +-
 package-lock.json                                   |  9 +++++++++
 package.json                                        |  1 +
 4 files changed, 23 insertions(+), 2 deletions(-)

diff --git a/.eslintrc.json b/.eslintrc.json
index 2562782a3d..063f09f3b1 100644
--- a/.eslintrc.json
+++ b/.eslintrc.json
@@ -22,9 +22,20 @@
       ],
       "plugins": [
         "eslint-plugin-unicorn",
-        "eslint-plugin-rxjs"
+        "eslint-plugin-rxjs",
+        "ban"
       ],
       "rules": {
+        "ban/ban": [
+          "error",
+          { "name": "eval", "message": "Calls to eval is not allowed." },
+          { "name": "fdescribe", "message": "Calls to fdescribe is not allowed" },
+          { "name": "fit", "message": "Calls to fit is not allowed" },
+          { "name": "xit", "message": "Calls to xit is not allowed" },
+          { "name": "xdescribe", "message": "Calls to xdescribe is not allowed" },
+          { "name": ["test", "only"], "message": "Calls to test.only is not allowed" },
+          { "name": ["describe", "only"], "message": "Calls to describe.only is not allowed" }
+        ],
         "@angular-eslint/component-selector": [
           "error",
           {
diff --git a/lib/core/form/components/widgets/widget.component.spec.ts b/lib/core/form/components/widgets/widget.component.spec.ts
index d2d660a9db..b1aac886b5 100644
--- a/lib/core/form/components/widgets/widget.component.spec.ts
+++ b/lib/core/form/components/widgets/widget.component.spec.ts
@@ -24,7 +24,7 @@ import { CoreTestingModule } from '../../../testing';
 import { TranslateModule } from '@ngx-translate/core';
 import { filter } from 'rxjs/operators';
 
-fdescribe('WidgetComponent', () => {
+describe('WidgetComponent', () => {
 
     let widget: WidgetComponent;
     let fixture: ComponentFixture<WidgetComponent>;
diff --git a/package-lock.json b/package-lock.json
index 2a35cc75a5..970d5669d7 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -31249,6 +31249,15 @@
         }
       }
     },
+    "eslint-plugin-ban": {
+      "version": "1.6.0",
+      "resolved": "https://registry.npmjs.org/eslint-plugin-ban/-/eslint-plugin-ban-1.6.0.tgz",
+      "integrity": "sha512-gZptoV+SFHOHO57/5lmPvizMvSXrjFatP9qlVQf3meL/WHo9TxSoERygrMlESl19CPh95U86asTxohT8OprwDw==",
+      "dev": true,
+      "requires": {
+        "requireindex": "~1.2.0"
+      }
+    },
     "eslint-plugin-import": {
       "version": "2.25.4",
       "resolved": "https://registry.npmjs.org/eslint-plugin-import/-/eslint-plugin-import-2.25.4.tgz",
diff --git a/package.json b/package.json
index e03d414961..fb0d9fb215 100644
--- a/package.json
+++ b/package.json
@@ -142,6 +142,7 @@
     "css-loader": "^5.2.6",
     "dotenv": "^8.2.0",
     "eslint": "^7.6.0",
+    "eslint-plugin-ban": "^1.6.0",
     "eslint-plugin-import": "2.25.4",
     "eslint-plugin-jsdoc": "30.7.6",
     "eslint-plugin-prefer-arrow": "1.2.2",