clean unit test (#4890)

* promote use setupTestbed

* fix comment using right spy and remove deprecated moment method usage

* restore md icon file

* remove error translation log

* restore extension test
This commit is contained in:
Eugenio Romano
2019-07-02 16:00:58 +01:00
committed by GitHub
parent 87b80235a7
commit 0d6140be77
17 changed files with 208 additions and 226 deletions

View File

@@ -15,7 +15,7 @@
* limitations under the License.
*/
import { ComponentFixture, TestBed, async } from '@angular/core/testing';
import { ComponentFixture, TestBed } from '@angular/core/testing';
import { HeaderLayoutComponent } from './header.component';
import { setupTestBed } from '../../../testing/setupTestBed';
import { CoreTestingModule } from '../../../testing/core.testing.module';
@@ -151,13 +151,10 @@ describe('HeaderLayoutComponent', () => {
})
class HeaderLayoutTesterComponent {}
beforeEach(async(() => {
TestBed.configureTestingModule({
declarations: [HeaderLayoutTesterComponent],
imports: [ CoreTestingModule, LayoutModule, MaterialModule, RouterTestingModule ]
})
.compileComponents();
}));
setupTestBed({
declarations: [HeaderLayoutTesterComponent],
imports: [ CoreTestingModule, LayoutModule, MaterialModule, RouterTestingModule ]
});
it('should project the provided nodes into the component', () => {
const hostFixture = TestBed.createComponent(HeaderLayoutTesterComponent);

View File

@@ -16,7 +16,7 @@
*/
import { Component } from '@angular/core';
import { async, ComponentFixture, TestBed } from '@angular/core/testing';
import { ComponentFixture, TestBed } from '@angular/core/testing';
import { MaterialModule } from '../../../material.module';
import { SidebarActionMenuComponent } from './sidebar-action-menu.component';
import { setupTestBed } from '../../../testing/setupTestBed';
@@ -57,23 +57,23 @@ describe('SidebarActionMenuComponent', () => {
@Component({
template: `
<adf-sidebar-action-menu [expanded]="expanded" [title]="title">
<mat-icon adf-sidebar-menu-title-icon>arrow_drop_down</mat-icon>
<div adf-sidebar-menu-expand-icon>
<mat-icon>queue</mat-icon>
</div>
<div adf-sidebar-menu-options>
<button mat-menu-item>
<mat-icon>assignment</mat-icon>
<span>Option1</span>
</button>
<button mat-menu-item>
<mat-icon>assignment</mat-icon>
<span>Option2</span>
</button>
</div>
</adf-sidebar-action-menu>
`
<adf-sidebar-action-menu [expanded]="expanded" [title]="title">
<mat-icon adf-sidebar-menu-title-icon>arrow_drop_down</mat-icon>
<div adf-sidebar-menu-expand-icon>
<mat-icon>queue</mat-icon>
</div>
<div adf-sidebar-menu-options>
<button mat-menu-item>
<mat-icon>assignment</mat-icon>
<span>Option1</span>
</button>
<button mat-menu-item>
<mat-icon>assignment</mat-icon>
<span>Option2</span>
</button>
</div>
</adf-sidebar-action-menu>
`
})
class CustomSidebarActionMenuComponent {
title: string = 'Fake title';
@@ -85,17 +85,15 @@ describe('Custom SidebarActionMenuComponent', () => {
let component: CustomSidebarActionMenuComponent;
let element: HTMLElement;
beforeEach(async(() => {
TestBed.configureTestingModule({
declarations: [
SidebarActionMenuComponent,
CustomSidebarActionMenuComponent
],
imports: [
MaterialModule
]
}).compileComponents();
}));
setupTestBed({
declarations: [
SidebarActionMenuComponent,
CustomSidebarActionMenuComponent
],
imports: [
MaterialModule
]
});
beforeEach(() => {
fixture = TestBed.createComponent(CustomSidebarActionMenuComponent);