inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2025-05-12 17:04:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

AAE-33340 Async Form Enrichment - Spinner doesnt hide on process completion (#10749)

Browse Source
This commit is contained in:
Bartosz Sekula 2025-03-27 14:59:09 +01:00 committed by GitHub
parent abaf7df9c6
commit 142c6ae754
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lib/process-services-cloud/src/lib/form/services/spinner/form-cloud-spinner.service.spec.ts
View File

@ -83,4 +83,16 @@ describe('FormCloudSpinnerService', () => {
hasSpinner = await rootLoader.hasHarness(MatProgressSpinnerHarness); hasSpinner = await rootLoader.hasHarness(MatProgressSpinnerHarness);
expect(hasSpinner).toBeFalse(); expect(hasSpinner).toBeFalse();
}); });
it('should show only one spinner at time', async () => {
spinnerService.initSpinnerHandling(destroyRef);
formService.toggleFormSpinner.next(showSpinnerEvent);
const otherShowSpinnerEvent = new FormSpinnerEvent('toggle-spinner', { showSpinner: true, message: 'ANOTHER' });
formService.toggleFormSpinner.next(otherShowSpinnerEvent);
fixture.detectChanges();
const spinners = await rootLoader.getAllHarnesses(MatProgressSpinnerHarness);
expect(spinners.length).toBe(1);
});
}); });

5
lib/process-services-cloud/src/lib/form/services/spinner/form-cloud-spinner.service.ts
View File

@ -27,11 +27,11 @@ export class FormCloudSpinnerService {
private formService = inject(FormService); private formService = inject(FormService);
private overlay = inject(Overlay); private overlay = inject(Overlay);
private overlayRef?: OverlayRef; private overlayRef?: OverlayRef = null;
initSpinnerHandling(destroyRef: DestroyRef): void { initSpinnerHandling(destroyRef: DestroyRef): void {
this.formService.toggleFormSpinner.pipe(takeUntilDestroyed(destroyRef)).subscribe((event: FormSpinnerEvent) => { this.formService.toggleFormSpinner.pipe(takeUntilDestroyed(destroyRef)).subscribe((event: FormSpinnerEvent) => {
if (event?.payload.showSpinner) { if (event?.payload.showSpinner && this.overlayRef === null) {
this.overlayRef = this.overlay.create({ this.overlayRef = this.overlay.create({
hasBackdrop: true hasBackdrop: true
}); });
@ -41,6 +41,7 @@ export class FormCloudSpinnerService {
componentRef.instance.message = event.payload.message; componentRef.instance.message = event.payload.message;
} else if (event?.payload.showSpinner === false) { } else if (event?.payload.showSpinner === false) {
this.overlayRef?.detach(); this.overlayRef?.detach();
this.overlayRef = null;
} }
}); });
} }