diff --git a/e2e/pages/adf/process-services/taskDetailsPage.ts b/e2e/pages/adf/process-services/taskDetailsPage.ts index eccd4ad02a..8a4afdb963 100644 --- a/e2e/pages/adf/process-services/taskDetailsPage.ts +++ b/e2e/pages/adf/process-services/taskDetailsPage.ts @@ -232,7 +232,7 @@ export class TaskDetailsPage { addComment(comment) { BrowserVisibility.waitUntilElementIsVisible(this.commentField); this.commentField.sendKeys(comment); - Util.waitUntilElementIsVisible(this.addCommentButton); + BrowserVisibility.waitUntilElementIsVisible(this.addCommentButton); this.addCommentButton.click(); return this; } diff --git a/lib/core/card-view/components/card-view-textitem/card-view-textitem.component.spec.ts b/lib/core/card-view/components/card-view-textitem/card-view-textitem.component.spec.ts index 94a51ee90b..399856ec56 100644 --- a/lib/core/card-view/components/card-view-textitem/card-view-textitem.component.spec.ts +++ b/lib/core/card-view/components/card-view-textitem/card-view-textitem.component.spec.ts @@ -185,7 +185,7 @@ describe('CardViewTextItemComponent', () => { }); fixture.detectChanges(); - let value = fixture.debugElement.query(By.css(`[data-automation-id="card-textitem-edit-icon-${component.property.icon}"]`)); + const value = fixture.debugElement.query(By.css(`[data-automation-id="card-textitem-edit-icon-${component.property.icon}"]`)); expect(value).toBeNull(); expect(value.nativeElement.innerText.trim()).toBe('FAKE-ICON'); }); @@ -325,7 +325,7 @@ describe('CardViewTextItemComponent', () => { })); it('should render the default as value if the value is empty, clickable is false and displayEmpty is true', (done) => { - let functionTestClick = () => { + const functionTestClick = () => { done(); }; diff --git a/lib/core/viewer/components/pdfViewer.component.spec.ts b/lib/core/viewer/components/pdfViewer.component.spec.ts index d8cb0e479f..47f8681232 100644 --- a/lib/core/viewer/components/pdfViewer.component.spec.ts +++ b/lib/core/viewer/components/pdfViewer.component.spec.ts @@ -98,7 +98,7 @@ class BlobTestComponent { } createFakeBlob(): Blob { - let pdfData = atob( + const pdfData = atob( 'JVBERi0xLjcKCjEgMCBvYmogICUgZW50cnkgcG9pbnQKPDwKICAvVHlwZSAvQ2F0YWxvZwog' + 'IC9QYWdlcyAyIDAgUgo+PgplbmRvYmoKCjIgMCBvYmoKPDwKICAvVHlwZSAvUGFnZXMKICAv' + 'TWVkaWFCb3ggWyAwIDAgMjAwIDIwMCBdCiAgL0NvdW50IDEKICAvS2lkcyBbIDMgMCBSIF0K' + @@ -357,7 +357,7 @@ describe('Test PdfViewer component', () => { }, 5000); it('should nextPage move to the next page', (done) => { - let nextPageButton: any = elementUrlTestComponent.querySelector('#viewer-next-page-button'); + const nextPageButton: any = elementUrlTestComponent.querySelector('#viewer-next-page-button'); nextPageButton.click(); fixtureUrlTestComponent.detectChanges(); @@ -398,8 +398,8 @@ describe('Test PdfViewer component', () => { }, 5000); it('should previous page move to the previous page', (done) => { - let previousPageButton: any = elementUrlTestComponent.querySelector('#viewer-previous-page-button'); - let nextPageButton: any = elementUrlTestComponent.querySelector('#viewer-next-page-button'); + const previousPageButton: any = elementUrlTestComponent.querySelector('#viewer-previous-page-button'); + const nextPageButton: any = elementUrlTestComponent.querySelector('#viewer-next-page-button'); nextPageButton.click(); nextPageButton.click(); @@ -438,28 +438,28 @@ describe('Test PdfViewer component', () => { spyOn(componentUrlTestComponent.pdfViewerComponent.pdfViewer, 'forceRendering').and.callFake(() => { }); - let zoomInButton: any = elementUrlTestComponent.querySelector('#viewer-zoom-in-button'); + const zoomInButton: any = elementUrlTestComponent.querySelector('#viewer-zoom-in-button'); tick(250); - let zoomBefore = componentUrlTestComponent.pdfViewerComponent.currentScale; + const zoomBefore = componentUrlTestComponent.pdfViewerComponent.currentScale; zoomInButton.click(); expect(componentUrlTestComponent.pdfViewerComponent.currentScaleMode).toBe('auto'); - let currentZoom = componentUrlTestComponent.pdfViewerComponent.currentScale; + const currentZoom = componentUrlTestComponent.pdfViewerComponent.currentScale; expect(zoomBefore < currentZoom).toBe(true); })); it('should zoom out decrement the scale value', fakeAsync(() => { spyOn(componentUrlTestComponent.pdfViewerComponent.pdfViewer, 'forceRendering').and.callFake(() => { }); - let zoomOutButton: any = elementUrlTestComponent.querySelector('#viewer-zoom-out-button'); + const zoomOutButton: any = elementUrlTestComponent.querySelector('#viewer-zoom-out-button'); tick(250); - let zoomBefore = componentUrlTestComponent.pdfViewerComponent.currentScale; + const zoomBefore = componentUrlTestComponent.pdfViewerComponent.currentScale; zoomOutButton.click(); expect(componentUrlTestComponent.pdfViewerComponent.currentScaleMode).toBe('auto'); - let currentZoom = componentUrlTestComponent.pdfViewerComponent.currentScale; + const currentZoom = componentUrlTestComponent.pdfViewerComponent.currentScale; expect(zoomBefore > currentZoom).toBe(true); })); @@ -467,7 +467,7 @@ describe('Test PdfViewer component', () => { spyOn(componentUrlTestComponent.pdfViewerComponent.pdfViewer, 'forceRendering').and.callFake(() => { }); - let itPage: any = elementUrlTestComponent.querySelector('#viewer-scale-page-button'); + const itPage: any = elementUrlTestComponent.querySelector('#viewer-scale-page-button'); tick(250); diff --git a/lib/tslint.json b/lib/tslint.json index 3d9dfdbd0d..f2a146e20a 100644 --- a/lib/tslint.json +++ b/lib/tslint.json @@ -7,5 +7,6 @@ "template-accessibility-label-for": true, "template-accessibility-tabindex-no-positive": true, "template-accessibility-table-scope": true, - "template-accessibility-valid-aria": true + "template-accessibility-valid-aria": true, + "template-no-autofocus": true } diff --git a/package-lock.json b/package-lock.json index 27b0a87c91..339e9db346 100644 --- a/package-lock.json +++ b/package-lock.json @@ -61,9 +61,9 @@ } }, "@alfresco/js-api": { - "version": "3.1.0-6eec5abc14bb31af3512cba5492f4ba43ffa2fac", - "resolved": "https://registry.npmjs.org/@alfresco/js-api/-/js-api-3.1.0-6eec5abc14bb31af3512cba5492f4ba43ffa2fac.tgz", - "integrity": "sha512-2Muuj1nPZFQK7u0CRRw0CWgoDd7lmHuiF+fpwHlh3CAArE2w7lvyZCKJkwQkXTwjSwAacytzCkysVdVINZvN9w==", + "version": "3.1.0", + "resolved": "https://registry.npmjs.org/@alfresco/js-api/-/js-api-3.1.0.tgz", + "integrity": "sha512-kjh2vmbZ2LImNVUOfmYz6kZPcv/8IoMFLtOOcL5IrBg6PdYxYlmjAw5Gs/5wlNHuqSnZe6nNfZCPlmYDxsL6aQ==", "requires": { "event-emitter": "0.3.4", "superagent": "3.8.2" @@ -2880,7 +2880,6 @@ "resolved": "https://registry.npmjs.org/boom/-/boom-2.10.1.tgz", "integrity": "sha1-OciRjO/1eZ+D+UkqhI9iWt0Mdm8=", "dev": true, - "optional": true, "requires": { "hoek": "2.x.x" } @@ -3544,8 +3543,7 @@ "version": "1.0.0", "resolved": "https://registry.npmjs.org/buffer-more-ints/-/buffer-more-ints-1.0.0.tgz", "integrity": "sha512-EMetuGFz5SLsT0QTnXzINh4Ksr+oo4i+UGTXEshiGCQWnsgSs7ZhJ8fzlwQ+OzEMs0MpDAMr1hxnblp5a4vcHg==", - "dev": true, - "optional": true + "dev": true }, "buffer-xor": { "version": "1.0.3", @@ -4091,9 +4089,9 @@ "dev": true }, "codelyzer": { - "version": "5.0.0-beta.2", - "resolved": "https://registry.npmjs.org/codelyzer/-/codelyzer-5.0.0-beta.2.tgz", - "integrity": "sha512-cH5vxszkzhAg92pvuKXFuoDgKIqX3a5hIPv545pfuPc2GKDXuiWACPteny29k3/FGaw9eub1iUlyLVkPpETtsg==", + "version": "5.0.0", + "resolved": "https://registry.npmjs.org/codelyzer/-/codelyzer-5.0.0.tgz", + "integrity": "sha512-Bif70XYt8NFf/Q9GPTxmC86OsBRfQZq1dBjdruJ5kZhJ8/jKhJL6MvCLKnYtSOG6Rhiv/44DU0cHk6GYthjy8Q==", "dev": true, "requires": { "app-root-path": "^2.1.0", @@ -6792,8 +6790,7 @@ "ansi-regex": { "version": "2.1.1", "bundled": true, - "dev": true, - "optional": true + "dev": true }, "aproba": { "version": "1.2.0", @@ -6814,14 +6811,12 @@ "balanced-match": { "version": "1.0.0", "bundled": true, - "dev": true, - "optional": true + "dev": true }, "brace-expansion": { "version": "1.1.11", "bundled": true, "dev": true, - "optional": true, "requires": { "balanced-match": "^1.0.0", "concat-map": "0.0.1" @@ -6836,20 +6831,17 @@ "code-point-at": { "version": "1.1.0", "bundled": true, - "dev": true, - "optional": true + "dev": true }, "concat-map": { "version": "0.0.1", "bundled": true, - "dev": true, - "optional": true + "dev": true }, "console-control-strings": { "version": "1.1.0", "bundled": true, - "dev": true, - "optional": true + "dev": true }, "core-util-is": { "version": "1.0.2", @@ -6966,8 +6958,7 @@ "inherits": { "version": "2.0.3", "bundled": true, - "dev": true, - "optional": true + "dev": true }, "ini": { "version": "1.3.5", @@ -6979,7 +6970,6 @@ "version": "1.0.0", "bundled": true, "dev": true, - "optional": true, "requires": { "number-is-nan": "^1.0.0" } @@ -6994,7 +6984,6 @@ "version": "3.0.4", "bundled": true, "dev": true, - "optional": true, "requires": { "brace-expansion": "^1.1.7" } @@ -7002,14 +6991,12 @@ "minimist": { "version": "0.0.8", "bundled": true, - "dev": true, - "optional": true + "dev": true }, "minipass": { "version": "2.3.5", "bundled": true, "dev": true, - "optional": true, "requires": { "safe-buffer": "^5.1.2", "yallist": "^3.0.0" @@ -7028,7 +7015,6 @@ "version": "0.5.1", "bundled": true, "dev": true, - "optional": true, "requires": { "minimist": "0.0.8" } @@ -7109,8 +7095,7 @@ "number-is-nan": { "version": "1.0.1", "bundled": true, - "dev": true, - "optional": true + "dev": true }, "object-assign": { "version": "4.1.1", @@ -7122,7 +7107,6 @@ "version": "1.4.0", "bundled": true, "dev": true, - "optional": true, "requires": { "wrappy": "1" } @@ -7208,8 +7192,7 @@ "safe-buffer": { "version": "5.1.2", "bundled": true, - "dev": true, - "optional": true + "dev": true }, "safer-buffer": { "version": "2.1.2", @@ -7245,7 +7228,6 @@ "version": "1.0.2", "bundled": true, "dev": true, - "optional": true, "requires": { "code-point-at": "^1.0.0", "is-fullwidth-code-point": "^1.0.0", @@ -7265,7 +7247,6 @@ "version": "3.0.1", "bundled": true, "dev": true, - "optional": true, "requires": { "ansi-regex": "^2.0.0" } @@ -7309,14 +7290,12 @@ "wrappy": { "version": "1.0.2", "bundled": true, - "dev": true, - "optional": true + "dev": true }, "yallist": { "version": "3.0.3", "bundled": true, - "dev": true, - "optional": true + "dev": true } } }, @@ -8083,8 +8062,7 @@ "version": "2.16.3", "resolved": "https://registry.npmjs.org/hoek/-/hoek-2.16.3.tgz", "integrity": "sha1-ILt0A9POo5jpHcRxCo/xuCdKJe0=", - "dev": true, - "optional": true + "dev": true }, "homedir-polyfill": { "version": "1.0.3", @@ -8247,7 +8225,6 @@ "resolved": "https://registry.npmjs.org/httpntlm/-/httpntlm-1.6.1.tgz", "integrity": "sha1-rQFScUOi6Hc8+uapb1hla7UqNLI=", "dev": true, - "optional": true, "requires": { "httpreq": ">=0.4.22", "underscore": "~1.7.0" @@ -8257,8 +8234,7 @@ "version": "0.4.24", "resolved": "https://registry.npmjs.org/httpreq/-/httpreq-0.4.24.tgz", "integrity": "sha1-QzX/2CzZaWaKOUZckprGHWOTYn8=", - "dev": true, - "optional": true + "dev": true }, "https-browserify": { "version": "1.0.0", @@ -9159,8 +9135,7 @@ "version": "1.0.2", "resolved": "https://registry.npmjs.org/is-property/-/is-property-1.0.2.tgz", "integrity": "sha1-V/4cTkhHTt1lsJkR8msc1Ald2oQ=", - "dev": true, - "optional": true + "dev": true }, "is-redirect": { "version": "1.0.0", @@ -10093,15 +10068,13 @@ "version": "0.1.0", "resolved": "https://registry.npmjs.org/libbase64/-/libbase64-0.1.0.tgz", "integrity": "sha1-YjUag5VjrF/1vSbxL2Dpgwu3UeY=", - "dev": true, - "optional": true + "dev": true }, "libmime": { "version": "3.0.0", "resolved": "https://registry.npmjs.org/libmime/-/libmime-3.0.0.tgz", "integrity": "sha1-UaGp50SOy9Ms2lRCFnW7IbwJPaY=", "dev": true, - "optional": true, "requires": { "iconv-lite": "0.4.15", "libbase64": "0.1.0", @@ -10112,8 +10085,7 @@ "version": "0.4.15", "resolved": "https://registry.npmjs.org/iconv-lite/-/iconv-lite-0.4.15.tgz", "integrity": "sha1-/iZaIYrGpXz+hUkn6dBMGYJe3es=", - "dev": true, - "optional": true + "dev": true } } }, @@ -10121,8 +10093,7 @@ "version": "1.1.0", "resolved": "https://registry.npmjs.org/libqp/-/libqp-1.1.0.tgz", "integrity": "sha1-9ebgatdLeU+1tbZpiL9yjvHe2+g=", - "dev": true, - "optional": true + "dev": true }, "license-checker": { "version": "25.0.1", @@ -12187,15 +12158,13 @@ "version": "1.6.0", "resolved": "https://registry.npmjs.org/nodemailer-fetch/-/nodemailer-fetch-1.6.0.tgz", "integrity": "sha1-ecSQihwPXzdbc/6IjamCj23JY6Q=", - "dev": true, - "optional": true + "dev": true }, "nodemailer-shared": { "version": "1.1.0", "resolved": "https://registry.npmjs.org/nodemailer-shared/-/nodemailer-shared-1.1.0.tgz", "integrity": "sha1-z1mU4v0mjQD1zw+nZ6CBae2wfsA=", "dev": true, - "optional": true, "requires": { "nodemailer-fetch": "1.6.0" } @@ -12228,8 +12197,7 @@ "version": "0.1.10", "resolved": "https://registry.npmjs.org/nodemailer-wellknown/-/nodemailer-wellknown-0.1.10.tgz", "integrity": "sha1-WG24EB2zDLRDjrVGc3pBqtDPE9U=", - "dev": true, - "optional": true + "dev": true }, "nopt": { "version": "3.0.6", @@ -14291,9 +14259,9 @@ "dev": true }, "qs": { - "version": "6.6.0", - "resolved": "https://registry.npmjs.org/qs/-/qs-6.6.0.tgz", - "integrity": "sha512-KIJqT9jQJDQx5h5uAVPimw6yVg2SekOKu959OCtktD3FjzbpvaPr8i4zzg07DOMz+igA4W/aNM7OV8H37pFYfA==" + "version": "6.7.0", + "resolved": "https://registry.npmjs.org/qs/-/qs-6.7.0.tgz", + "integrity": "sha512-VCdBRNFTX1fyE7Nb6FYoURo/SPe62QCaAyzJvUjwRaIsc+NePBEniHlvxFmmX56+HZphIGtV0XeCirBtpDrTyQ==" }, "querystring": { "version": "0.2.0", @@ -15820,7 +15788,6 @@ "resolved": "https://registry.npmjs.org/smtp-connection/-/smtp-connection-2.12.0.tgz", "integrity": "sha1-1275EnyyPCJZ7bHoNJwujV4tdME=", "dev": true, - "optional": true, "requires": { "httpntlm": "1.6.1", "nodemailer-shared": "1.1.0" @@ -17900,8 +17867,7 @@ "version": "1.7.0", "resolved": "https://registry.npmjs.org/underscore/-/underscore-1.7.0.tgz", "integrity": "sha1-a7rwh3UA02vjTsqlhODbn+8DUgk=", - "dev": true, - "optional": true + "dev": true }, "unherit": { "version": "1.1.1", diff --git a/package.json b/package.json index e6afc65b19..2000280fa5 100644 --- a/package.json +++ b/package.json @@ -114,7 +114,7 @@ "ajv-cli": "^3.0.0", "bundlesize": "^0.15.3", "chalk": "^2.3.2", - "codelyzer": "5.0.0-beta.2", + "codelyzer": "5.0.0", "commander": "^2.15.1", "concurrently": "^3.5.1", "cspell": "^3.1.3",