inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2025-07-24 17:32:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ADF-3746] Add style lint rules (#3975)

Browse Source 
* add stylelint

* fix style first part

*  fix style second part

*  fix style third part

*  fix style fourth part

* Fix e2e tests first part

* Fix e2e tests second part

* Rebase branch

*  fix style third part

*  fix style fourth part

* Fix list error

* fix insights

* fix style abotu component

* Fix e2e tests second part

* Rebase branch

*  fix style third part

*  fix style fourth part

* Fix list error

* Fix e2e tests second part

* Rebase branch

*  fix style third part

*  fix style fourth part

* Fix list error

* [ADF-3746] Rebase branch

* Fix e2e tests second part

* Rebase branch

*  fix style third part

*  fix style fourth part

* Fix list error

* Fix e2e tests second part

* Rebase branch

* Fix list error

* fix new style added

* tslint fix

* [ADF-3746] Fix scss errors on Process Filters Cloud component
This commit is contained in:
davidcanonieto
2018-11-28 14:43:18 +00:00
committed by Eugenio Romano
parent 5fc03cf26b
commit 1a21f234b6
234 changed files with 2328 additions and 1058 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
e2e/actions/APS/apps.actions.ts
View File

@@ -20,6 +20,7 @@ import fs = require('fs');
import TestConfig = require('../../test.config');
import AppPublish = require('../../models/APS/AppPublish');
import remote = require('selenium-webdriver/remote');
import { browser } from 'protractor';
export class AppsActions {

6
e2e/pages/adf/cardViewPageComponent.js
View File

@@ -19,7 +19,7 @@ var Util = require('../../util/util');
var CardViewComponentPage = function () {
const addButton = element(by.className('card-view__key-value-pairs__add-btn'));
const addButton = element(by.className('adf-card-view__key-value-pairs__add-btn'));
const keyValueRow = 'card-view__key-value-pairs__row';
const selectValue = 'mat-option';
const textField = element(by.css("input[data-automation-id='card-textitem-editinput-name']"));
@@ -27,8 +27,8 @@ var CardViewComponentPage = function () {
const floatField = element(by.css("input[data-automation-id='card-textitem-editinput-float']"));
const valueInputField = element(by.xpath("//*[contains(@id,'input') and @placeholder='Value']"));
const nameInputField = element(by.xpath("//*[contains(@id,'input') and @placeholder='Name']"));
const consoleLog = element(by.className('console'));
const deleteButton = element.all(by.className('card-view__key-value-pairs__remove-btn')).first();
const consoleLog = element(by.className('adf-console'));
const deleteButton = element.all(by.className('adf-card-view__key-value-pairs__remove-btn')).first();
const select = element(by.css('mat-select[data-automation-class="select-box"]'));
const checkbox = element(by.css("mat-checkbox[data-automation-id='card-boolean-boolean']"));
const resetButton = element(by.css("#adf-reset-card-log"));

24
e2e/pages/adf/contentServicesPage.ts
View File

@@ -31,10 +31,10 @@ export class ContentServicesPage {
uploadBorder = element(by.id('document-list-container'));
tableBody = element.all(by.css('adf-document-list div[class="adf-datatable-body"]')).first();
contentServices = element(by.css('a[data-automation-id="Content Services"]'));
currentFolder = element(by.css('div[class*="adf-breadcrumb-item active"] div'));
currentFolder = element(by.css('div[class*="adf-breadcrumb-item adf-active"] div'));
createFolderButton = element(by.cssContainingText('mat-icon', 'create_new_folder'));
activeBreadcrumb = element(by.css('div[class*="active"]'));
tooltip = by.css('div[class*="--text full-width"] span');
activeBreadcrumb = element(by.css('div[class*="adf-active"]'));
tooltip = by.css('div[class*="--text adf-full-width"] span');
uploadFileButton = element(by.css('input[data-automation-id="upload-single-file"]'));
uploadMultipleFileButton = element(by.css('input[data-automation-id="upload-multiple-files"]'));
uploadFolderButton = element(by.css('input[data-automation-id="uploadFolder"]'));
@@ -53,9 +53,9 @@ export class ContentServicesPage {
documentListSpinner = element(by.css('mat-progress-spinner'));
emptyFolder = element(by.css('.adf-empty-folder-this-space-is-empty'));
emptyFolderImage = element(by.css('.adf-empty-folder-image'));
emptyRecent = element(by.css('.adf-container-recent .empty-list__title'));
emptyRecent = element(by.css('.adf-container-recent .adf-empty-list__title'));
gridViewButton = element(by.css('button[data-automation-id="document-list-grid-view"]'));
cardViewContainer = element(by.css('div.document-list-container div.adf-data-table-card'));
cardViewContainer = element(by.css('div.adf-document-list-container div.adf-data-table-card'));
copyButton = element(by.css('button[data-automation-id="content-node-selector-actions-choose"]'));
searchInputElement = element(by.css('input[data-automation-id="content-node-selector-search-input"'));
shareNodeButton = element(by.cssContainingText('mat-icon', ' share '));
@@ -457,7 +457,7 @@ export class ContentServicesPage {
}
checkIconForRowIsDisplayed(fileName) {
let iconRow = element(by.css(`.document-list-container div.adf-data-table-cell[filename="${fileName}"] img`));
let iconRow = element(by.css(`.adf-document-list-container div.adf-data-table-cell[filename="${fileName}"] img`));
Util.waitUntilElementIsVisible(iconRow);
return iconRow;
}
@@ -482,22 +482,22 @@ export class ContentServicesPage {
getCardElementShowedInPage() {
this.checkCardViewContainerIsDisplayed();
let actualCards = $$('div.document-list-container div.adf-data-table-card div.cell-value img').count();
let actualCards = $$('div.adf-document-list-container div.adf-data-table-card div.adf-cell-value img').count();
return actualCards;
}
getDocumentCardIconForElement(elementName) {
let elementIcon = element(by.css(`.document-list-container div.adf-data-table-cell[filename="${elementName}"] img`));
let elementIcon = element(by.css(`.adf-document-list-container div.adf-data-table-cell[filename="${elementName}"] img`));
return elementIcon.getAttribute('src');
}
checkDocumentCardPropertyIsShowed(elementName, propertyName) {
let elementProperty = element(by.css(`.document-list-container div.adf-data-table-cell[filename="${elementName}"][title="${propertyName}"]`));
let elementProperty = element(by.css(`.adf-document-list-container div.adf-data-table-cell[filename="${elementName}"][title="${propertyName}"]`));
Util.waitUntilElementIsVisible(elementProperty);
}
getAttributeValueForElement(elementName, propertyName) {
let elementSize = element(by.css(`.document-list-container div.adf-data-table-cell[filename="${elementName}"][title="${propertyName}"] span`));
let elementSize = element(by.css(`.adf-document-list-container div.adf-data-table-cell[filename="${elementName}"][title="${propertyName}"] span`));
return elementSize.getText();
}
@@ -507,9 +507,9 @@ export class ContentServicesPage {
}
navigateToCardFolder(folderName) {
let folderCard = element(by.css(`.document-list-container div.image-table-cell.adf-data-table-cell[filename="${folderName}"]`));
let folderCard = element(by.css(`.adf-document-list-container div.adf-image-table-cell.adf-data-table-cell[filename="${folderName}"]`));
folderCard.click();
let folderSelected = element(by.css(`.adf-datatable-row.is-selected div[filename="${folderName}"].adf-data-table-cell--image`));
let folderSelected = element(by.css(`.adf-datatable-row.adf-is-selected div[filename="${folderName}"].adf-data-table-cell--image`));
Util.waitUntilElementIsVisible(folderSelected);
browser.actions().sendKeys(protractor.Key.ENTER).perform();
}

4
e2e/pages/adf/dialog/searchDialog.js
View File

@@ -122,9 +122,7 @@ var SearchDialog = function () {
this.clearText = function () {
Util.waitUntilElementIsVisible(searchBar);
var deferred = protractor.promise.defer();
searchBar.clear().then(function () {
searchBar.sendKeys(protractor.Key.ESCAPE);
});
searchBar.clear();
return deferred.promise;
};
};

3
e2e/pages/adf/dialog/shareDialog.ts
View File

@@ -17,7 +17,6 @@
import { element, by } from 'protractor';
import Util = require('../../../util/util');
import moment = require('moment');
import { FormControllersPage } from '../material/formControllersPage';
export class ShareDialog {
@@ -32,7 +31,7 @@ export class ShareDialog {
shareLink = element(by.css('[data-automation-id="adf-share-link"]'));
closeButton = element(by.css('button[data-automation-id="adf-share-dialog-close"]'));
snackBar = element(by.css('simple-snack-bar'));
copySharedLinkButton = element(by.css('.input-action'));
copySharedLinkButton = element(by.css('.adf-input-action'));
timeDatePickerButton = element(by.css('mat-datetimepicker-toggle button'));
dayPicker = element(by.css('mat-datetimepicker-month-view'));
clockPicker = element(by.css('mat-datetimepicker-clock'));

2
e2e/pages/adf/dialog/userInfoDialog.ts
View File

@@ -17,6 +17,7 @@
import Util = require('../../../util/util');
import { TabsPage } from '../material/tabsPage';
import { element, by, browser, protractor } from 'protractor';
export class UserInfoDialog {
@@ -62,6 +63,7 @@ export class UserInfoDialog {
}
getContentHeaderTitle() {
Util.waitUntilElementIsVisible(this.dialog);
Util.waitUntilElementIsVisible(this.userInfoEcmHeaderTitle);
return this.userInfoEcmHeaderTitle.getText();
}

2
e2e/pages/adf/documentListPage.js
View File

@@ -21,7 +21,7 @@ var Util = require('../../util/util');
var contentServices = element(by.css("a[data-automation-id='files'] span"));
var siteList = element(by.css("md-select[class*='dropdown-list']"));
var folderID = element(by.css('adf-files-component p'));
var folderText = element(by.css("md-input-container[class*='create-folder--name'] input"));
var folderText = element(by.css("md-input-container[class*='adf-create-folder--name'] input"));
var createButtonDialog = element(by.xpath("//span[contains(text(), 'Create')]/ancestor::button"));
var createFolderButton = element(by.xpath("//md-icon[contains(text(), 'create_new_folder')]"));
var currentFolder = element(by.xpath("//div[@class='adf-breadcrumb-container']/li[last()]/div"));

2
e2e/pages/adf/loginPage.ts
View File

@@ -32,7 +32,7 @@ export class LoginPage {
logoTxt = element(by.css('input[data-automation-id="adf-url-logo"]'));
usernameTooltip = element(by.css('span[data-automation-id="username-error"]'));
passwordTooltip = element(by.css('span[data-automation-id="password-required"]'));
loginTooltip = element(by.css('span[class="login-error-message"]'));
loginTooltip = element(by.css('span[class="adf-login-error-message"]'));
usernameInactive = element(by.css('input[id="username"][aria-invalid="false"]'));
passwordInactive = element(by.css('input[id="password"][aria-invalid="false"]'));
adfLogo = element(by.css('img[class="adf-img-logo ng-star-inserted"]'));

2
e2e/pages/adf/navigationBarPage.ts
View File

@@ -35,7 +35,7 @@ export class NavigationBarPage {
themeButton = element(by.css('button[data-automation-id="theme menu"]'));
themeMenuContent = element(by.css('div[class*="mat-menu-panel"]'));
logoutButton = element(by.css('a[adf-logout]'));
cardViewButton = element(by.cssContainingText('.sidenav-menu-label', 'CardView'));
cardViewButton = element(by.cssContainingText('.adf-sidenav-menu-label', 'CardView'));
languageMenuButton = element(by.css('button[data-automation-id="language-menu-button"]'));
appTitle = element(by.css('.adf-app-title'));
headerDataButton = element(by.css('a[data-automation-id="Header Data"]'));

6
e2e/pages/adf/notificationPage.ts
View File

@@ -66,12 +66,14 @@ export class NotificationPage {
enterMessageField(text) {
Util.waitUntilElementIsVisible(this.messageField);
this.messageField.clear().sendKeys(text);
this.messageField.clear();
this.messageField.sendKeys(text);
}
enterDurationField(time) {
Util.waitUntilElementIsVisible(this.durationField);
this.durationField.clear().sendKeys(time);
this.durationField.clear();
this.durationField.sendKeys(time);
}
selectHorizontalPosition(selectedItem) {

2
e2e/pages/adf/process_services/processDetailsPage.js
View File

@@ -45,7 +45,7 @@ var ProcessDetailsPage = function () {
//Tasks
var activeTask = element(by.css('div[data-automation-id="active-tasks"]'));
var completedTask = element(by.css('div[data-automation-id="completed-tasks"]'));
var taskTitle = element(by.css("h2[class='activiti-task-details__header']"));
var taskTitle = element(by.css("h2[class='adf-activiti-task-details__header']"));
this.checkDetailsAreDisplayed = function () {
Util.waitUntilElementIsVisible(processStatusField);

2
e2e/pages/adf/process_services/processFiltersPage.js
View File

@@ -87,7 +87,7 @@ var ProcessFiltersPage = function () {
};
this.checkFilterIsHighlighted = function (filterName) {
var processNameHighlighted = element(by.css("mat-list-item.active span[data-automation-id='" + filterName + "_filter']"));
var processNameHighlighted = element(by.css("mat-list-item.adf-active span[data-automation-id='" + filterName + "_filter']"));
Util.waitUntilElementIsVisible(processNameHighlighted);
};

8
e2e/pages/adf/process_services/taskDetailsPage.ts
View File

@@ -42,19 +42,19 @@ export class TaskDetailsPage {
involvePeopleButton = element(by.css('div[class*="add-people"]'));
addPeopleField = element(by.css('input[data-automation-id="adf-people-search-input"]'));
addInvolvedUserButton = element(by.css('button[id="add-people"] span'));
emailInvolvedUser = by.xpath('following-sibling::div[@class="people-email ng-star-inserted"]');
editActionInvolvedUser = by.xpath('following-sibling::div[@class="people-edit-label ng-star-inserted"]');
emailInvolvedUser = by.xpath('following-sibling::div[@class="adf-people-email ng-star-inserted"]');
editActionInvolvedUser = by.xpath('following-sibling::div[@class="adf-people-edit-label ng-star-inserted"]');
involvedUserPic = by.xpath('ancestor::div/ancestor::div/preceding-sibling::div//div[@class="adf-people-search-people-pic ng-star-inserted"]');
taskDetailsInfoDrawer = element(by.tagName('adf-info-drawer'));
taskDetailsSection = element(by.css('div[data-automation-id="adf-tasks-details"]'));
taskDetailsEmptySection = element(by.css('div[data-automation-id="adf-tasks-details--empty"]'));
completeTask = element(by.css('button[id="adf-no-form-complete-button"]'));
completeFormTask = element(by.css('button[id="adf-form-complete"]'));
taskDetailsTitle = element(by.css('h2[class="activiti-task-details__header"] span'));
taskDetailsTitle = element(by.css('h2[class="adf-activiti-task-details__header"] span'));
auditLogButton = element(by.css('button[adf-task-audit]'));
noPeopleInvolved = element(by.id('no-people-label'));
cancelInvolvePeopleButton = element(by.id('close-people-search'));
involvePeopleHeader = element(by.css('div[class="search-text-header"]'));
involvePeopleHeader = element(by.css('div[class="adf-search-text-header"]'));
removeInvolvedPeople = element(by.css('button[data-automation-id="Remove"]'));
peopleTitle = element(by.id('people-title'));
editFormButton = element.all(by.css('mat-icon[data-automation-id="card-textitem-edit-icon-create"]')).last();

2
e2e/pages/adf/process_services/tasksPage.ts
View File

@@ -32,7 +32,7 @@ export class TasksPage {
addChecklistButton = element(by.css('button[class*="adf-add-to-checklist-button"]'));
rowByRowName = by.xpath('ancestor::mat-chip');
checklistContainer = by.css('div[class*="checklist-menu"]');
taskTitle = 'h2[class="activiti-task-details__header"] span';
taskTitle = 'h2[class="adf-activiti-task-details__header"] span';
rows = by.css('div[class*="adf-datatable-body"] div[class*="adf-datatable-row"] div[class*="adf-data-table-cell"]');
completeButtonNoForm = element(by.id('adf-no-form-complete-button'));
checklistDialog = element(by.id('checklist-dialog'));

14
e2e/pages/adf/process_services/widgets/dateWidget.ts
View File

@@ -16,7 +16,7 @@
*/
import FormFields = require('../formFields');
import { element, by } from 'protractor';
import { element, by, protractor } from 'protractor';
import Util = require('../../../../util/util');
export class DateWidget {
@@ -38,6 +38,7 @@ export class DateWidget {
}
setDateInput(fieldId, value) {
this.removeFromDatetimeWidget(fieldId);
return this.formFields.setValueInInputById(fieldId, value);
}
@@ -58,4 +59,15 @@ export class DateWidget {
Util.waitUntilElementIsVisible(errorMessage);
return errorMessage.getText();
}
removeFromDatetimeWidget(fieldId) {
Util.waitUntilElementIsVisible(this.formFields.getWidget(fieldId));
let dateWidgetInput = element(by.id(fieldId));
dateWidgetInput.getAttribute('value').then((result) => {
for (let i = result.length; i >= 0; i--) {
dateWidgetInput.sendKeys(protractor.Key.BACK_SPACE);
}
});
}
}

6
e2e/pages/adf/process_services/widgets/radioButtonsWidget.ts
View File

@@ -21,12 +21,12 @@ import { by, element } from 'protractor';
export class RadioButtonsWidget {
selectedOption = by.css('mat-radio-button[ng-reflect-checked="false"]');
selectedOption = by.css('mat-radio-button[ng-pristine]');
formFields = new FormFields();
getSpecificOptionLabel(fieldId, optionNumber) {
let optionLocator = by.css('label[for*="radiobuttons-option_' + optionNumber + '"] div[class*="content"]');
let optionLocator = by.css('label[for*="radiobuttons-option_' + optionNumber + '"] div[class*="adf-content"]');
let option = this.formFields.getWidget(fieldId).element(optionLocator);
Util.waitUntilElementIsVisible(option);
@@ -34,7 +34,7 @@ export class RadioButtonsWidget {
}
selectOption(fieldId, optionNumber) {
let optionLocator = by.css(`label[for*="${fieldId}-option_${optionNumber}"] div[class*="content"]`);
let optionLocator = by.css(`label[for*="${fieldId}-option_${optionNumber}"] div[class*="adf-content"]`);
let option = this.formFields.getWidget(fieldId).element(optionLocator);
Util.waitUntilElementIsVisible(option);

2
e2e/pages/adf/viewerPage.ts
View File

@@ -156,7 +156,7 @@ export class ViewerPage {
}
checkCurrentThumbnailIsSelected() {
let selectedThumbnail = element(by.css('adf-pdf-thumb[class="pdf-thumbnails__thumb ng-star-inserted pdf-thumbnails__thumb--selected"] > img'));
let selectedThumbnail = element(by.css('adf-pdf-thumb[class="adf-pdf-thumbnails__thumb ng-star-inserted adf-pdf-thumbnails__thumb--selected"] > img'));
this.pageSelectorInput.getAttribute('value').then(function (pageNumber) {
browser.controlFlow().execute(async () => {
expect('Page ' + pageNumber).toEqual(await selectedThumbnail.getAttribute('title'));

1
e2e/process-services/Task_details_no_form.e2e.ts
View File

@@ -22,7 +22,6 @@ import { TasksPage } from '../pages/adf/process_services/tasksPage';
import CONSTANTS = require('../util/constants');
import Tenant = require('../models/APS/Tenant');
import Task = require('../models/APS/Task');
import TestConfig = require('../test.config');
import resources = require('../util/resources');

1
e2e/process-services/apps-section.e2e.ts
View File

@@ -41,7 +41,6 @@ describe('Modify applications', () => {
let apps = new AppsActions();
let modelActions = new ModelsActions();
let firstApp, appVersionToBeDeleted;
let model;
beforeAll(async (done) => {
let users = new UsersActions();

7
e2e/process-services/start_task_custom_app.e2e.ts
View File

@@ -23,18 +23,13 @@ import { AttachmentListPage } from '../pages/adf/process_services/attachmentList
import { AppNavigationBarPage } from '../pages/adf/process_services/appNavigationBarPage';
import { NavigationBarPage } from '../pages/adf/navigationBarPage';
import Task = require('../models/APS/Task');
import Tenant = require('../models/APS/Tenant');
import TaskModel = require('../models/APS/TaskModel');
import FileModel = require('../models/ACS/fileModel');
import FormModel = require('../models/APS/FormModel');
import TestConfig = require('../test.config');
import resources = require('../util/resources');
import dateFormat = require('dateformat');
import AlfrescoApi = require('alfresco-js-api-node');
import { AppsActions } from '../actions/APS/apps.actions';
import { UsersActions } from '../actions/users.actions';
@@ -43,8 +38,6 @@ import CONSTANTS = require('../util/constants');
describe('Start Task - Custom App', () => {
let TASK_DATA_FORMAT = 'mmm dd yyyy';
let loginPage = new LoginPage();
let navigationBarPage = new NavigationBarPage();
let attachmentListPage = new AttachmentListPage();

5
e2e/process-services/start_task_task_app.e2e.ts
View File

@@ -26,16 +26,11 @@ import { NavigationBarPage } from '../pages/adf/navigationBarPage';
import CONSTANTS = require('../util/constants');
import Tenant = require('../models/APS/Tenant');
import Task = require('../models/APS/Task');
import TaskModel = require('../models/APS/TaskModel');
import FormModel = require('../models/APS/FormModel');
import FileModel = require('../models/ACS/fileModel');
import TestConfig = require('../test.config');
import resources = require('../util/resources');
import dateFormat = require('dateformat');
import AlfrescoApi = require('alfresco-js-api-node');
import { UsersActions } from '../actions/users.actions';
import fs = require('fs');

3
e2e/process-services/task_details.e2e.ts
View File

@@ -32,6 +32,7 @@ import dateFormat = require('dateformat');
import { LoginPage } from '../pages/adf/loginPage';
import { NavigationBarPage } from '../pages/adf/navigationBarPage';
import { TasksPage } from '../pages/adf/process_services/tasksPage';
import { browser } from 'protractor';
describe('Task Details component', () => {
@@ -268,6 +269,7 @@ describe('Task Details component', () => {
});
let checklistTask = new TaskModel(allTasks.data[0]);
let taskModel = new TaskModel(allTasks.data[0]);
taskPage.tasksListPage().getDataTable().checkContentIsDisplayed(checklistTask.getName());
expect(taskPage.taskDetails().getCreated()).toEqual(dateFormat(checklistTask.getCreated(), TASK_DATA_FORMAT));
expect(taskPage.taskDetails().getId()).toEqual(checklistTask.getId());
@@ -311,6 +313,7 @@ describe('Task Details component', () => {
});
let checklistTask = new TaskModel(allTasks.data[0]);
let taskModel = new TaskModel(allTasks.data[0]);
taskPage.tasksListPage().getDataTable().checkContentIsDisplayed(checklistTask.getName());
expect(taskPage.taskDetails().getCreated()).toEqual(dateFormat(checklistTask.getCreated(), TASK_DATA_FORMAT));
expect(taskPage.taskDetails().getId()).toEqual(checklistTask.getId());