[ADF-4745] memory leak fixes (#4931)

* fix app-layout component

* fix card-view component

* fix cloud-layout service

* code fixes

* code fixes

* even more fixes

* even more fixes

* lint fixes

* test fixes

* fix code

* remove useless pipes

* fix code owners

* enable spellcheck for cloud components

* update test

* update test

lib/content-services/content-node-share/content-node-share.directive.ts

@@ -15,19 +15,20 @@
  * limitations under the License.
  */
 
-import { Directive, Input, HostListener, OnChanges, NgZone } from '@angular/core';
+import { Directive, Input, HostListener, OnChanges, NgZone, OnDestroy } from '@angular/core';
 import { MatDialog } from '@angular/material';
 import { NodeEntry, Node } from '@alfresco/js-api';
 
 import { ShareDialogComponent } from './content-node-share.dialog';
-import { Observable, from } from 'rxjs';
+import { Observable, from, Subject } from 'rxjs';
 import { AlfrescoApiService } from '@alfresco/adf-core';
+import { takeUntil } from 'rxjs/operators';
 
 @Directive({
     selector: '[adf-share]',
     exportAs: 'adfShare'
 })
-export class NodeSharedDirective implements OnChanges {
+export class NodeSharedDirective implements OnChanges, OnDestroy {
 
     isFile: boolean = false;
     isShared: boolean = false;
@@ -41,12 +42,7 @@ export class NodeSharedDirective implements OnChanges {
     @Input()
     baseShareUrl: string;
 
-    @HostListener('click')
-    onClick() {
-        if (this.node) {
-            this.shareNode(this.node);
-        }
-    }
+    private onDestroy$ = new Subject<boolean>();
 
     constructor(
         private dialog: MatDialog,
@@ -54,6 +50,11 @@ export class NodeSharedDirective implements OnChanges {
         private alfrescoApiService: AlfrescoApiService) {
     }
 
+    ngOnDestroy() {
+        this.onDestroy$.next(true);
+        this.onDestroy$.complete();
+    }
+
     shareNode(nodeEntry: NodeEntry) {
         if (nodeEntry && nodeEntry.entry && nodeEntry.entry.isFile) {
             // shared and favorite
@@ -89,11 +90,20 @@ export class NodeSharedDirective implements OnChanges {
     }
 
     ngOnChanges() {
-        this.zone.onStable.subscribe(() => {
-            if (this.node && this.node.entry) {
-                this.isFile = this.node.entry.isFile;
-                this.isShared = this.node.entry.properties ? this.node.entry.properties['qshare:sharedId'] : false;
-            }
-        });
+        this.zone.onStable
+            .pipe(takeUntil(this.onDestroy$))
+            .subscribe(() => {
+                if (this.node && this.node.entry) {
+                    this.isFile = this.node.entry.isFile;
+                    this.isShared = this.node.entry.properties ? this.node.entry.properties['qshare:sharedId'] : false;
+                }
+            });
+    }
+
+    @HostListener('click')
+    onClick() {
+        if (this.node) {
+            this.shareNode(this.node);
+        }
     }
 }