[ADF-4745] memory leak fixes (#4931)

* fix app-layout component * fix card-view component * fix cloud-layout service * code fixes * code fixes * even more fixes * even more fixes * lint fixes * test fixes * fix code * remove useless pipes * fix code owners * enable spellcheck for cloud components * update test * update test
2025-07-31 17:38:48 +00:00 · 2019-07-16 15:56:00 +01:00
parent e2311ab045
commit 1abb9bfc89
98 changed files with 1581 additions and 1066 deletions
--- a/lib/content-services/document-list/components/document-list.component.ts
+++ b/lib/content-services/document-list/components/document-list.component.ts
@@ -47,7 +47,7 @@ import {
 } from '@alfresco/adf-core';

 import { Node, NodeEntry, NodePaging, Pagination } from '@alfresco/js-api';
-import { Subject, BehaviorSubject, Subscription, of } from 'rxjs';
+import { Subject, BehaviorSubject, of } from 'rxjs';
 import { ShareDataRow } from './../data/share-data-row.model';
 import { ShareDataTableAdapter } from './../data/share-datatable-adapter';
 import { presetsDefaultModel } from '../models/preset.model';
@@ -58,6 +58,7 @@ import { NavigableComponentInterface } from '../../breadcrumb/navigable-componen
 import { RowFilter } from '../data/row-filter.model';
 import { DocumentListService } from '../services/document-list.service';
 import { DocumentLoaderNode } from '../models/document-folder.model';
+import { takeUntil } from 'rxjs/operators';

@Component({
    selector: 'adf-document-list',
@@ -314,9 +315,9 @@ export class DocumentListComponent implements OnInit, OnChanges, OnDestroy, Afte
    pagination: BehaviorSubject<PaginationModel> = new BehaviorSubject<PaginationModel>(this.DEFAULT_PAGINATION);

    private layoutPresets = {};
-    private subscriptions: Subscription[] = [];
    private rowMenuCache: { [key: string]: ContentActionModel[] } = {};
    private loadingTimeout;
+    private onDestroy$ = new Subject<boolean>();

    constructor(private documentListService: DocumentListService,
                private ngZone: NgZone,
@@ -327,10 +328,6 @@ export class DocumentListComponent implements OnInit, OnChanges, OnDestroy, Afte
                private thumbnailService: ThumbnailService,
                private alfrescoApiService: AlfrescoApiService,
                private lockService: LockService) {
-
-        this.userPreferencesService.select(UserPreferenceValues.PaginationSize).subscribe((pagSize) => {
-            this.maxItems = this._pagination.maxItems = pagSize;
-        });
    }

    getContextActions(node: NodeEntry) {
@@ -375,6 +372,13 @@ export class DocumentListComponent implements OnInit, OnChanges, OnDestroy, Afte
    }

    ngOnInit() {
+        this.userPreferencesService
+            .select(UserPreferenceValues.PaginationSize)
+            .pipe(takeUntil(this.onDestroy$))
+            .subscribe(pagSize => {
+                this.maxItems = this._pagination.maxItems = pagSize;
+            });
+
        this.rowMenuCache = {};
        this.loadLayoutPresets();
        this.data = new ShareDataTableAdapter(this.thumbnailService, this.contentService, null, this.getDefaultSorting(), this.sortingMode);
@@ -389,20 +393,18 @@ export class DocumentListComponent implements OnInit, OnChanges, OnDestroy, Afte
            this.data.setImageResolver(this.imageResolver);
        }

-        this.subscriptions.push(
-            this.contextActionHandler.subscribe((val) => this.contextActionCallback(val))
-        );
+        this.contextActionHandler
+            .pipe(takeUntil(this.onDestroy$))
+            .subscribe(val => this.contextActionCallback(val));

        this.enforceSingleClickNavigationForMobile();
    }

    ngAfterContentInit() {
        if (this.columnList) {
-            this.subscriptions.push(
-                this.columnList.columns.changes.subscribe(() => {
-                    this.setTableSchema();
-                })
-            );
+            this.columnList.columns.changes
+                .pipe(takeUntil(this.onDestroy$))
+                .subscribe(() => this.setTableSchema());
        }
        this.setTableSchema();
    }
@@ -598,9 +600,9 @@ export class DocumentListComponent implements OnInit, OnChanges, OnDestroy, Afte
            }

            if (typeof action.execute === 'function' && handlerSub) {
-                handlerSub.subscribe(() => {
-                    action.execute(node);
-                });
+                handlerSub
+                    .pipe(takeUntil(this.onDestroy$))
+                    .subscribe(() => action.execute(node));
            }
        }
    }
@@ -834,8 +836,8 @@ export class DocumentListComponent implements OnInit, OnChanges, OnDestroy, Afte
    }

    ngOnDestroy() {
-        this.subscriptions.forEach((s) => s.unsubscribe());
-        this.subscriptions = [];
+        this.onDestroy$.next(true);
+        this.onDestroy$.complete();
    }

    private handleError(err: any) {
--- a/lib/content-services/document-list/components/library-name-column/library-name-column.component.ts
+++ b/lib/content-services/document-list/components/library-name-column/library-name-column.component.ts
@@ -24,10 +24,11 @@ import {
    ElementRef,
    OnDestroy
 } from '@angular/core';
-import { NodeEntry, Node, Site } from '@alfresco/js-api';
+import { NodeEntry, Site } from '@alfresco/js-api';
 import { ShareDataRow } from '../../data/share-data-row.model';
 import { AlfrescoApiService } from '@alfresco/adf-core';
-import { BehaviorSubject, Subscription } from 'rxjs';
+import { BehaviorSubject, Subject } from 'rxjs';
+import { takeUntil } from 'rxjs/operators';

@Component({
    selector: 'adf-library-name-column',
@@ -50,7 +51,7 @@ export class LibraryNameColumnComponent implements OnInit, OnDestroy {
    displayText$ = new BehaviorSubject<string>('');
    node: NodeEntry;

-    private sub: Subscription;
+    private onDestroy$ = new Subject<boolean>();

    constructor(
        private element: ElementRef,
@@ -60,8 +61,9 @@ export class LibraryNameColumnComponent implements OnInit, OnDestroy {
    ngOnInit() {
        this.updateValue();

-        this.sub = this.alfrescoApiService.nodeUpdated.subscribe(
-            (node: Node) => {
+        this.alfrescoApiService.nodeUpdated
+            .pipe(takeUntil(this.onDestroy$))
+            .subscribe(node => {
                const row: ShareDataRow = this.context.row;
                if (row) {
                    const { entry } = row.node;
@@ -71,8 +73,7 @@ export class LibraryNameColumnComponent implements OnInit, OnDestroy {
                        this.updateValue();
                    }
                }
-            }
-        );
+            });
    }

    protected updateValue() {
@@ -119,9 +120,7 @@ export class LibraryNameColumnComponent implements OnInit, OnDestroy {
    }

    ngOnDestroy() {
-        if (this.sub) {
-            this.sub.unsubscribe();
-            this.sub = null;
-        }
+        this.onDestroy$.next(true);
+        this.onDestroy$.complete();
    }
 }
--- a/lib/content-services/document-list/components/library-role-column/library-role-column.component.ts
+++ b/lib/content-services/document-list/components/library-role-column/library-role-column.component.ts
@@ -23,10 +23,11 @@ import {
    ViewEncapsulation,
    OnDestroy
 } from '@angular/core';
-import { Subscription, BehaviorSubject } from 'rxjs';
+import { BehaviorSubject, Subject } from 'rxjs';
 import { AlfrescoApiService } from '@alfresco/adf-core';
-import { Node, SiteEntry, Site } from '@alfresco/js-api';
+import { SiteEntry, Site } from '@alfresco/js-api';
 import { ShareDataRow } from '../../data/share-data-row.model';
+import { takeUntil } from 'rxjs/operators';

@Component({
    selector: 'adf-library-role-column',
@@ -45,24 +46,26 @@ export class LibraryRoleColumnComponent implements OnInit, OnDestroy {

    displayText$ = new BehaviorSubject<string>('');

-    private sub: Subscription;
+    private onDestroy$ = new Subject<boolean>();

    constructor(private api: AlfrescoApiService) {}

    ngOnInit() {
        this.updateValue();

-        this.sub = this.api.nodeUpdated.subscribe((node: Node) => {
-            const row: ShareDataRow = this.context.row;
-            if (row) {
-                const { entry } = row.node;
+        this.api.nodeUpdated
+            .pipe(takeUntil(this.onDestroy$))
+            .subscribe(node => {
+                const row: ShareDataRow = this.context.row;
+                if (row) {
+                    const { entry } = row.node;

-                if (entry === node) {
-                    row.node = { entry };
-                    this.updateValue();
+                    if (entry === node) {
+                        row.node = { entry };
+                        this.updateValue();
+                    }
                }
-            }
-        });
+            });
    }

    protected updateValue() {
@@ -90,9 +93,7 @@ export class LibraryRoleColumnComponent implements OnInit, OnDestroy {
    }

    ngOnDestroy() {
-        if (this.sub) {
-            this.sub.unsubscribe();
-            this.sub = null;
-        }
+        this.onDestroy$.next(true);
+        this.onDestroy$.complete();
    }
 }
--- a/lib/content-services/document-list/components/library-status-column/library-status-column.component.ts
+++ b/lib/content-services/document-list/components/library-status-column/library-status-column.component.ts
@@ -17,9 +17,10 @@

 import { Component, Input, OnInit, OnDestroy } from '@angular/core';
 import { AlfrescoApiService } from '@alfresco/adf-core';
-import { Subscription, BehaviorSubject } from 'rxjs';
-import { Node, Site, SiteEntry } from '@alfresco/js-api';
+import { BehaviorSubject, Subject } from 'rxjs';
+import { Site, SiteEntry } from '@alfresco/js-api';
 import { ShareDataRow } from '../../data/share-data-row.model';
+import { takeUntil } from 'rxjs/operators';

@Component({
    selector: 'adf-library-status-column',
@@ -36,24 +37,26 @@ export class LibraryStatusColumnComponent implements OnInit, OnDestroy {

    displayText$ = new BehaviorSubject<string>('');

-    private sub: Subscription;
+    private onDestroy$ = new Subject<boolean>();

    constructor(private api: AlfrescoApiService) {}

    ngOnInit() {
        this.updateValue();

-        this.sub = this.api.nodeUpdated.subscribe((node: Node) => {
-            const row: ShareDataRow = this.context.row;
-            if (row) {
-                const { entry } = row.node;
+        this.api.nodeUpdated
+            .pipe(takeUntil(this.onDestroy$))
+            .subscribe(node => {
+                const row: ShareDataRow = this.context.row;
+                if (row) {
+                    const { entry } = row.node;

-                if (entry === node) {
-                    row.node = { entry };
-                    this.updateValue();
+                    if (entry === node) {
+                        row.node = { entry };
+                        this.updateValue();
+                    }
                }
-            }
-        });
+            });
    }

    protected updateValue() {
@@ -79,9 +82,7 @@ export class LibraryStatusColumnComponent implements OnInit, OnDestroy {
    }

    ngOnDestroy() {
-        if (this.sub) {
-            this.sub.unsubscribe();
-            this.sub = null;
-        }
+        this.onDestroy$.next(true);
+        this.onDestroy$.complete();
    }
 }
--- a/lib/content-services/document-list/components/name-column/name-column.component.ts
+++ b/lib/content-services/document-list/components/name-column/name-column.component.ts
@@ -25,10 +25,10 @@ import {
    OnDestroy
 } from '@angular/core';
 import { NodeEntry } from '@alfresco/js-api';
-import { BehaviorSubject, Subscription } from 'rxjs';
+import { BehaviorSubject, Subject } from 'rxjs';
 import { AlfrescoApiService } from '@alfresco/adf-core';
-import { Node } from '@alfresco/js-api';
 import { ShareDataRow } from '../../data/share-data-row.model';
+import { takeUntil } from 'rxjs/operators';

@Component({
    selector: 'adf-name-column',
@@ -48,24 +48,26 @@ export class NameColumnComponent implements OnInit, OnDestroy {
    displayText$ = new BehaviorSubject<string>('');
    node: NodeEntry;

-    private sub: Subscription;
+    private onDestroy$ = new Subject<boolean>();

    constructor(private element: ElementRef, private alfrescoApiService: AlfrescoApiService) {}

    ngOnInit() {
        this.updateValue();

-        this.sub = this.alfrescoApiService.nodeUpdated.subscribe((node: Node) => {
-            const row: ShareDataRow = this.context.row;
-            if (row) {
-                const { entry } = row.node;
+        this.alfrescoApiService.nodeUpdated
+            .pipe(takeUntil(this.onDestroy$))
+            .subscribe(node => {
+                const row: ShareDataRow = this.context.row;
+                if (row) {
+                    const { entry } = row.node;

-                if (entry === node) {
-                    row.node = { entry };
-                    this.updateValue();
+                    if (entry === node) {
+                        row.node = { entry };
+                        this.updateValue();
+                    }
                }
-            }
-        });
+            });
    }

    protected updateValue() {
@@ -88,9 +90,7 @@ export class NameColumnComponent implements OnInit, OnDestroy {
    }

    ngOnDestroy() {
-        if (this.sub) {
-            this.sub.unsubscribe();
-            this.sub = null;
-        }
+        this.onDestroy$.next(true);
+        this.onDestroy$.complete();
    }
 }