[ADF-4745] memory leak fixes (#4931)

* fix app-layout component

* fix card-view component

* fix cloud-layout service

* code fixes

* code fixes

* even more fixes

* even more fixes

* lint fixes

* test fixes

* fix code

* remove useless pipes

* fix code owners

* enable spellcheck for cloud components

* update test

* update test

lib/content-services/search/components/search.component.ts

@@ -27,11 +27,12 @@ import {
     Output,
     TemplateRef,
     ViewChild,
-    ViewEncapsulation
+    ViewEncapsulation,
+    OnDestroy
 } from '@angular/core';
 import { NodePaging } from '@alfresco/js-api';
 import { Subject } from 'rxjs';
-import { debounceTime } from 'rxjs/operators';
+import { debounceTime, takeUntil } from 'rxjs/operators';
 
 @Component({
     selector: 'adf-search',
@@ -44,7 +45,7 @@ import { debounceTime } from 'rxjs/operators';
         'class': 'adf-search'
     }
 })
-export class SearchComponent implements AfterContentInit, OnChanges {
+export class SearchComponent implements AfterContentInit, OnChanges, OnDestroy {
 
     @ViewChild('panel')
     panel: ElementRef;
@@ -99,25 +100,27 @@ export class SearchComponent implements AfterContentInit, OnChanges {
     }
 
     _isOpen: boolean = false;
-
-    keyPressedStream: Subject<string> = new Subject();
-
+    keyPressedStream = new Subject<string>();
     _classList: { [key: string]: boolean } = {};
+    private onDestroy$ = new Subject<boolean>();
 
     constructor(private searchService: SearchService,
                 private _elementRef: ElementRef) {
-        this.keyPressedStream.asObservable()
+        this.keyPressedStream
             .pipe(
-                debounceTime(200)
+                debounceTime(200),
+                takeUntil(this.onDestroy$)
             )
-            .subscribe((searchedWord: string) => {
+            .subscribe(searchedWord => {
                 this.loadSearchResults(searchedWord);
             });
 
-        searchService.dataLoaded.subscribe(
-            (nodePaging: NodePaging) => this.onSearchDataLoaded(nodePaging),
-            (error) => this.onSearchDataError(error)
-        );
+        searchService.dataLoaded
+            .pipe(takeUntil(this.onDestroy$))
+            .subscribe(
+                nodePaging => this.onSearchDataLoaded(nodePaging),
+                error => this.onSearchDataError(error)
+            );
     }
 
     ngAfterContentInit() {
@@ -130,6 +133,11 @@ export class SearchComponent implements AfterContentInit, OnChanges {
         }
     }
 
+    ngOnDestroy() {
+        this.onDestroy$.next(true);
+        this.onDestroy$.complete();
+    }
+
     resetResults() {
         this.cleanResults();
         this.setVisibility();