[ADF-4745] memory leak fixes (#4931)

* fix app-layout component

* fix card-view component

* fix cloud-layout service

* code fixes

* code fixes

* even more fixes

* even more fixes

* lint fixes

* test fixes

* fix code

* remove useless pipes

* fix code owners

* enable spellcheck for cloud components

* update test

* update test

lib/core/pipes/localized-date.pipe.ts

@@ -16,15 +16,17 @@
  */
 
 import { DatePipe } from '@angular/common';
-import { Pipe, PipeTransform } from '@angular/core';
+import { Pipe, PipeTransform, OnDestroy } from '@angular/core';
 import { AppConfigService } from '../app-config/app-config.service';
 import { UserPreferencesService, UserPreferenceValues } from '../services/user-preferences.service';
+import { Subject } from 'rxjs';
+import { takeUntil } from 'rxjs/operators';
 
 @Pipe({
     name: 'adfLocalizedDate',
     pure: false
 })
-export class LocalizedDatePipe implements PipeTransform {
+export class LocalizedDatePipe implements PipeTransform, OnDestroy {
 
     static DEFAULT_LOCALE = 'en-US';
     static DEFAULT_DATE_FORMAT = 'mediumDate';
@@ -32,15 +34,20 @@ export class LocalizedDatePipe implements PipeTransform {
     defaultLocale: string = LocalizedDatePipe.DEFAULT_LOCALE;
     defaultFormat: string = LocalizedDatePipe.DEFAULT_DATE_FORMAT;
 
+    private onDestroy$ = new Subject<boolean>();
+
     constructor(public userPreferenceService?: UserPreferencesService,
                 public appConfig?: AppConfigService) {
 
         if (this.userPreferenceService) {
-            this.userPreferenceService.select(UserPreferenceValues.Locale).subscribe((locale) => {
-                if (locale) {
-                    this.defaultLocale = locale;
-                }
-            });
+            this.userPreferenceService
+                .select(UserPreferenceValues.Locale)
+                .pipe(takeUntil(this.onDestroy$))
+                .subscribe(locale => {
+                    if (locale) {
+                        this.defaultLocale = locale;
+                    }
+                });
         }
 
         if (this.appConfig) {
@@ -55,4 +62,9 @@ export class LocalizedDatePipe implements PipeTransform {
         return datePipe.transform(value, actualFormat);
     }
 
+    ngOnDestroy() {
+        this.onDestroy$.next(true);
+        this.onDestroy$.complete();
+    }
+
 }