[ADF-4745] memory leak fixes (#4931)

* fix app-layout component

* fix card-view component

* fix cloud-layout service

* code fixes

* code fixes

* even more fixes

* even more fixes

* lint fixes

* test fixes

* fix code

* remove useless pipes

* fix code owners

* enable spellcheck for cloud components

* update test

* update test

lib/insights/analytics-process/components/analytics-report-parameters.component.ts

@@ -37,6 +37,8 @@ import { ReportParameterDetailsModel } from '../../diagram/models/report/reportP
 import { ReportParametersModel } from '../../diagram/models/report/reportParameters.model';
 import { ReportQuery } from '../../diagram/models/report/reportQuery.model';
 import { AnalyticsService } from '../services/analytics.service';
+import { Subject } from 'rxjs';
+import { takeUntil } from 'rxjs/operators';
 
 @Component({
     selector: 'adf-analytics-report-parameters',
@@ -80,7 +82,7 @@ export class AnalyticsReportParametersComponent implements OnInit, OnChanges, On
 
     onDropdownChanged = new EventEmitter();
 
-    successReportParams = new EventEmitter();
+    successReportParams = new EventEmitter<ReportParametersModel>();
 
     successParamOpt = new EventEmitter();
 
@@ -94,12 +96,10 @@ export class AnalyticsReportParametersComponent implements OnInit, OnChanges, On
 
     reportName: string;
 
-    private dropDownSub;
-    private reportParamsSub;
-    private paramOpts;
     reportParamQuery: ReportQuery;
     private hideParameters: boolean = true;
     formValidState: boolean = false;
+    private onDestroy$ = new Subject<boolean>();
 
     constructor(private analyticsService: AnalyticsService,
                 private formBuilder: FormBuilder,
@@ -110,19 +110,27 @@ export class AnalyticsReportParametersComponent implements OnInit, OnChanges, On
     }
 
     ngOnInit() {
-        this.dropDownSub = this.onDropdownChanged.subscribe((field) => {
-            const paramDependOn: ReportParameterDetailsModel = this.reportParameters.definition.parameters.find((p) => p.dependsOn === field.id);
-            if (paramDependOn) {
-                this.retrieveParameterOptions(this.reportParameters.definition.parameters, this.appId, this.reportId, field.value);
-            }
-        });
+        this.onDropdownChanged
+            .pipe(takeUntil(this.onDestroy$))
+            .subscribe((field: any) => {
+                const paramDependOn = this.reportParameters.definition.parameters.find(
+                    (param) => param.dependsOn === field.id
+                );
+                if (paramDependOn) {
+                    this.retrieveParameterOptions(
+                        this.reportParameters.definition.parameters, this.appId, this.reportId, field.value
+                    );
+                }
+            });
 
-        this.paramOpts = this.successReportParams.subscribe((report: ReportParametersModel) => {
-            if (report.hasParameters()) {
-                this.retrieveParameterOptions(report.definition.parameters, this.appId);
-                this.generateFormGroupFromParameter(report.definition.parameters);
-            }
-        });
+        this.successReportParams
+            .pipe(takeUntil(this.onDestroy$))
+            .subscribe(report => {
+                if (report.hasParameters()) {
+                    this.retrieveParameterOptions(report.definition.parameters, this.appId);
+                    this.generateFormGroupFromParameter(report.definition.parameters);
+                }
+            });
     }
 
     ngOnChanges(changes: SimpleChanges) {
@@ -195,7 +203,7 @@ export class AnalyticsReportParametersComponent implements OnInit, OnChanges, On
     }
 
     public getReportParams(reportId: string) {
-        this.reportParamsSub = this.analyticsService.getReportParams(reportId).subscribe(
+        this.analyticsService.getReportParams(reportId).subscribe(
             (res: ReportParametersModel) => {
                 this.reportParameters = res;
                 if (this.reportParameters.hasParameters()) {
@@ -293,11 +301,8 @@ export class AnalyticsReportParametersComponent implements OnInit, OnChanges, On
     }
 
     ngOnDestroy() {
-        this.dropDownSub.unsubscribe();
-        this.paramOpts.unsubscribe();
-        if (this.reportParamsSub) {
-            this.reportParamsSub.unsubscribe();
-        }
+        this.onDestroy$.next(true);
+        this.onDestroy$.complete();
     }
 
     public editEnable() {
@@ -309,15 +314,17 @@ export class AnalyticsReportParametersComponent implements OnInit, OnChanges, On
     }
 
     public editTitle() {
-        this.reportParamsSub = this.analyticsService.updateReport(this.reportParameters.id, this.reportParameters.name).subscribe(
-            (res: ReportParametersModel) => {
-                this.editDisable();
-                this.edit.emit(this.reportParameters.name);
-            },
-            (err: any) => {
-                this.error.emit(err);
-            }
-        );
+        this.analyticsService
+            .updateReport(this.reportParameters.id, this.reportParameters.name)
+            .subscribe(
+                () => {
+                    this.editDisable();
+                    this.edit.emit(this.reportParameters.name);
+                },
+                err => {
+                    this.error.emit(err);
+                }
+            );
     }
 
     public showDialog(event: string) {

lib/insights/analytics-process/components/widgets/date-range/date-range.widget.ts

@@ -18,11 +18,13 @@
 /* tslint:disable:no-input-rename  */
 
 import { MOMENT_DATE_FORMATS, MomentDateAdapter, UserPreferencesService, UserPreferenceValues } from '@alfresco/adf-core';
-import { Component, EventEmitter, Input, OnInit, Output, ViewEncapsulation } from '@angular/core';
+import { Component, EventEmitter, Input, OnInit, Output, ViewEncapsulation, OnDestroy } from '@angular/core';
 import { AbstractControl, FormControl, FormGroup, Validators } from '@angular/forms';
 import { DateAdapter, MAT_DATE_FORMATS } from '@angular/material';
 import moment from 'moment-es6';
 import { Moment } from 'moment';
+import { Subject } from 'rxjs';
+import { takeUntil } from 'rxjs/operators';
 
 @Component({
     selector: 'adf-date-range-widget',
@@ -33,7 +35,7 @@ import { Moment } from 'moment';
     styleUrls: ['./date-range.widget.scss'],
     encapsulation: ViewEncapsulation.None
 })
-export class DateRangeWidgetComponent implements OnInit {
+export class DateRangeWidgetComponent implements OnInit, OnDestroy {
 
     public FORMAT_DATE_ACTIVITI: string = 'YYYY-MM-DD';
     public SHOW_FORMAT: string = 'DD/MM/YYYY';
@@ -52,15 +54,18 @@ export class DateRangeWidgetComponent implements OnInit {
     startDatePicker: Moment = moment();
     endDatePicker: Moment = moment();
 
+    private onDestroy$ = new Subject<boolean>();
+
     constructor(
         private dateAdapter: DateAdapter<Moment>,
         private userPreferencesService: UserPreferencesService) {
     }
 
     ngOnInit() {
-        this.userPreferencesService.select(UserPreferenceValues.Locale).subscribe((locale) => {
-            this.dateAdapter.setLocale(locale);
-        });
+        this.userPreferencesService
+            .select(UserPreferenceValues.Locale)
+            .pipe(takeUntil(this.onDestroy$))
+            .subscribe(locale => this.dateAdapter.setLocale(locale));
 
         const momentDateAdapter = <MomentDateAdapter> this.dateAdapter;
         momentDateAdapter.overrideDisplayFormat = this.SHOW_FORMAT;
@@ -87,6 +92,11 @@ export class DateRangeWidgetComponent implements OnInit {
         this.dateRange.valueChanges.subscribe(() => this.onGroupValueChanged());
     }
 
+    ngOnDestroy() {
+        this.onDestroy$.next(true);
+        this.onDestroy$.complete();
+    }
+
     onGroupValueChanged() {
         if (this.dateRange.valid) {
             const dateStart = this.convertToMomentDateWithTime(this.dateRange.controls.startDate.value);