Fix unit tests

This commit is contained in:
Denys Vuika
2016-10-11 12:07:37 +01:00
parent 3042ae8060
commit 1b3b9f24c0
2 changed files with 16 additions and 5 deletions

View File

@@ -18,6 +18,7 @@
import { HyperlinkWidget } from './hyperlink.widget'; import { HyperlinkWidget } from './hyperlink.widget';
import { FormModel } from './../core/form.model'; import { FormModel } from './../core/form.model';
import { FormFieldModel } from './../core/form-field.model'; import { FormFieldModel } from './../core/form-field.model';
import { WidgetComponent } from './../widget.component';
describe('HyperlinkWidget', () => { describe('HyperlinkWidget', () => {
@@ -33,6 +34,7 @@ describe('HyperlinkWidget', () => {
widget.field = new FormFieldModel(new FormModel(), { widget.field = new FormFieldModel(new FormModel(), {
displayText: text displayText: text
}); });
widget.ngOnInit();
expect(widget.linkText).toBe(text); expect(widget.linkText).toBe(text);
}); });
@@ -44,12 +46,15 @@ describe('HyperlinkWidget', () => {
displayText: null, displayText: null,
hyperlinkUrl: url hyperlinkUrl: url
}); });
widget.ngOnInit();
expect(widget.linkText).toBe(url); expect(widget.linkText).toBe(url);
}); });
it('should require field to get link text', () => { it('should require field to get link text', () => {
widget.field = null; widget.field = null;
widget.ngOnInit();
expect(widget.linkText).toBeNull(); expect(widget.linkText).toBeNull();
}); });
@@ -58,21 +63,25 @@ describe('HyperlinkWidget', () => {
displayText: null, displayText: null,
hyperlinkUrl: null hyperlinkUrl: null
}); });
widget.ngOnInit();
expect(widget.linkText).toBeNull(); expect(widget.linkText).toBeNull();
}); });
it('should return default url for missing field', () => { it('should return default url for missing field', () => {
widget.field = null; widget.field = null;
expect(widget.linkUrl).toBe(HyperlinkWidget.DEFAULT_HYPERLINK_URL); widget.ngOnInit();
expect(widget.linkUrl).toBe(WidgetComponent.DEFAULT_HYPERLINK_URL);
}); });
it('should return default url for missing field property', () => { it('should return default url for missing field property', () => {
widget.field = new FormFieldModel(new FormModel(), { widget.field = new FormFieldModel(new FormModel(), {
hyperlinkUrl: null hyperlinkUrl: null
}); });
widget.ngOnInit();
expect(widget.linkUrl).toBe(HyperlinkWidget.DEFAULT_HYPERLINK_URL); expect(widget.linkUrl).toBe(WidgetComponent.DEFAULT_HYPERLINK_URL);
}); });
it('should prepend url with scheme', () => { it('should prepend url with scheme', () => {
@@ -80,8 +89,9 @@ describe('HyperlinkWidget', () => {
widget.field = new FormFieldModel(new FormModel(), { widget.field = new FormFieldModel(new FormModel(), {
hyperlinkUrl: url hyperlinkUrl: url
}); });
widget.ngOnInit();
expect(widget.linkUrl).toBe(`${HyperlinkWidget.DEFAULT_HYPERLINK_SCHEME}${url}`); expect(widget.linkUrl).toBe(`${WidgetComponent.DEFAULT_HYPERLINK_SCHEME}${url}`);
}); });
it('should not prepend url with scheme', () => { it('should not prepend url with scheme', () => {
@@ -89,6 +99,7 @@ describe('HyperlinkWidget', () => {
widget.field = new FormFieldModel(new FormModel(), { widget.field = new FormFieldModel(new FormModel(), {
hyperlinkUrl: url hyperlinkUrl: url
}); });
widget.ngOnInit();
expect(widget.linkUrl).toBe(url); expect(widget.linkUrl).toBe(url);
}); });

View File

@@ -26,8 +26,8 @@ import { WidgetComponent } from './../widget.component';
}) })
export class HyperlinkWidget extends WidgetComponent implements OnInit { export class HyperlinkWidget extends WidgetComponent implements OnInit {
linkUrl: string; linkUrl: string = WidgetComponent.DEFAULT_HYPERLINK_URL;
linkText: string; linkText: string = null;
ngOnInit() { ngOnInit() {
if (this.field) { if (this.field) {