From 257614bfc0c70e23474ad73fc18bee037fcc78d9 Mon Sep 17 00:00:00 2001 From: Vito Date: Thu, 15 Apr 2021 09:55:51 +0100 Subject: [PATCH] [ADF-5372] - fixed wrong result pipe (#6925) * [ADF-5372] - fixed wrong result pipe * [ADF-5372] - fixed missing radix on parseInt --- lib/core/pipes/file-size.pipe.spec.ts | 1 + lib/core/pipes/file-size.pipe.ts | 9 +++++++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/lib/core/pipes/file-size.pipe.spec.ts b/lib/core/pipes/file-size.pipe.spec.ts index ef8e4ddbf9..0c06687ab3 100644 --- a/lib/core/pipes/file-size.pipe.spec.ts +++ b/lib/core/pipes/file-size.pipe.spec.ts @@ -44,6 +44,7 @@ describe('FileSizePipe', () => { it('returns empty string with invalid input', () => { expect(pipe.transform(null)).toBe(''); expect(pipe.transform(undefined)).toBe(''); + expect(pipe.transform(NaN)).toBe(''); }); it('should convert value to Bytes', () => { diff --git a/lib/core/pipes/file-size.pipe.ts b/lib/core/pipes/file-size.pipe.ts index 2586ad350d..38351d8f0c 100644 --- a/lib/core/pipes/file-size.pipe.ts +++ b/lib/core/pipes/file-size.pipe.ts @@ -27,8 +27,13 @@ export class FileSizePipe implements PipeTransform { constructor(private translation: TranslationService) { } - transform(bytes: number, decimals: number = 2): string { - if (bytes == null) { + transform(paramByte: any, decimals: number = 2): string { + if (paramByte == null) { + return ''; + } + + const bytes = parseInt(paramByte, 10); + if (isNaN(bytes)) { return ''; }