inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2026-09-09 18:03:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ACS-10296] Upload new version button made accessible with keyboard (#11242)

Browse Source
This commit is contained in:
MichalKinas
2025-10-03 14:52:33 +02:00
committed by GitHub
parent 3356dab434
commit 25ecfcf5e1
2 changed files with 14 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/content-services/src/lib/upload/components/upload-button.component.html
+1 -1
View File
@@ -15,7 +15,7 @@
[title]="tooltip" [title]="tooltip"
(change)="onFilesAdded($event)" (change)="onFilesAdded($event)"
(click)="onClickUploadButton()"/> (click)="onClickUploadButton()"/>
<label for="upload-single-file" class="adf-upload-button-label"> <label tabindex="0" (keydown.enter)="onClickUploadButton()" for="upload-single-file" class="adf-upload-button-label">
<mat-icon class="adf-upload-button-icon">file_upload</mat-icon> <mat-icon class="adf-upload-button-icon">file_upload</mat-icon>
<span id="upload-single-file-label" *ngIf="!staticTitle"> <span id="upload-single-file-label" *ngIf="!staticTitle">
{{ 'FILE_UPLOAD.BUTTON.UPLOAD_FILE' | translate }}</span> {{ 'FILE_UPLOAD.BUTTON.UPLOAD_FILE' | translate }}</span>
lib/content-services/src/lib/upload/components/upload-button.component.spec.ts
+13
View File
@@ -25,6 +25,7 @@ import { mockUploadErrorPromise } from '../../mock/upload.service.mock';
import { UploadService } from '../../common/services/upload.service'; import { UploadService } from '../../common/services/upload.service';
import { NodesApiService } from '../../common/services/nodes-api.service'; import { NodesApiService } from '../../common/services/nodes-api.service';
import { FileUploadErrorEvent } from '../../common/events/file.event'; import { FileUploadErrorEvent } from '../../common/events/file.event';
import { UnitTestingUtils } from '@alfresco/adf-core';
describe('UploadButtonComponent', () => { describe('UploadButtonComponent', () => {
const file = { name: 'fake-name-1', size: 10, webkitRelativePath: 'fake-folder1/fake-name-1.json' }; const file = { name: 'fake-name-1', size: 10, webkitRelativePath: 'fake-folder1/fake-name-1.json' };
@@ -43,6 +44,7 @@ describe('UploadButtonComponent', () => {
let fixture: ComponentFixture<UploadButtonComponent>; let fixture: ComponentFixture<UploadButtonComponent>;
let uploadService: UploadService; let uploadService: UploadService;
let nodesApiService: NodesApiService; let nodesApiService: NodesApiService;
let unitTestingUtils: UnitTestingUtils;
beforeEach(() => { beforeEach(() => {
TestBed.configureTestingModule({ TestBed.configureTestingModule({
@@ -53,6 +55,7 @@ describe('UploadButtonComponent', () => {
nodesApiService = TestBed.inject(NodesApiService); nodesApiService = TestBed.inject(NodesApiService);
component = fixture.componentInstance; component = fixture.componentInstance;
unitTestingUtils = new UnitTestingUtils(fixture.debugElement);
fixture.detectChanges(); fixture.detectChanges();
}); });
@@ -200,6 +203,16 @@ describe('UploadButtonComponent', () => {
expect(compiled.querySelector('#uploadFolder-label-static').textContent.trim()).toEqual('test-text'); expect(compiled.querySelector('#uploadFolder-label-static').textContent.trim()).toEqual('test-text');
}); });
it('should call onClickUploadButton when label for single file receives enter key', () => {
component.uploadFolders = false;
component.multipleFiles = false;
spyOn(component, 'onClickUploadButton');
unitTestingUtils.keyBoardEventByCSS('.adf-upload-button-label', 'keydown', 'Enter', 'Enter');
expect(component.onClickUploadButton).toHaveBeenCalled();
});
describe('fileSize', () => { describe('fileSize', () => {
const files: File[] = [{ name: 'bigFile.png', size: 1000 } as File, { name: 'smallFile.png', size: 10 } as File]; const files: File[] = [{ name: 'bigFile.png', size: 1000 } as File, { name: 'smallFile.png', size: 10 } as File];