[ADF-2032] viewer reopening fixes (#2739)

* viewer reopening fixes

* docs update
This commit is contained in:
Denys Vuika
2017-11-27 22:41:10 +00:00
committed by Eugenio Romano
parent 82dca30d7f
commit 2746b29984
8 changed files with 99 additions and 21 deletions

View File

@@ -18,7 +18,7 @@
import { Location } from '@angular/common';
import {
Component, ContentChild, EventEmitter, HostListener,
Input, OnChanges, OnDestroy, Output, TemplateRef, ViewEncapsulation
Input, OnChanges, Output, SimpleChanges, TemplateRef, ViewEncapsulation
} from '@angular/core';
import { MinimalNodeEntryEntity } from 'alfresco-js-api';
import { BaseEvent } from '../../events';
@@ -37,7 +37,7 @@ import { ViewerToolbarComponent } from './viewer-toolbar.component';
host: { 'class': 'adf-viewer' },
encapsulation: ViewEncapsulation.None
})
export class ViewerComponent implements OnDestroy, OnChanges {
export class ViewerComponent implements OnChanges {
@ContentChild(ViewerToolbarComponent)
toolbar: ViewerToolbarComponent;
@@ -146,7 +146,7 @@ export class ViewerComponent implements OnDestroy, OnChanges {
private renditionService: RenditionsService) {
}
ngOnChanges(changes) {
ngOnChanges(changes: SimpleChanges) {
if (this.showViewer) {
if (!this.urlFile && !this.blobFile && !this.fileNodeId) {
throw new Error('Attribute urlFile or fileNodeId or blobFile is required');
@@ -308,26 +308,10 @@ export class ViewerComponent implements OnDestroy, OnChanges {
if (this.otherMenu) {
this.otherMenu.hidden = false;
}
this.cleanup();
this.showViewer = false;
this.showViewerChange.emit(this.showViewer);
}
/**
* cleanup before the close
*/
cleanup() {
this.urlFileContent = '';
this.displayName = '';
this.fileNodeId = null;
this.extension = null;
this.mimeType = null;
}
ngOnDestroy() {
this.cleanup();
}
/**
* get File name from url
*