[ADF-4273] Remove description property from Process Instance Cloud Model (#4568)

* [ADF-4273] Remove description property from Process Instance Cloud Model

* [ADF-4273] Remove from e2e tests

docs/process-services-cloud/components/process-header-cloud.component.md

@@ -36,7 +36,7 @@ The component populates an internal array of
 
 By default all properties are displayed:
 
-**_id_**, **_name_**, **_description_**, **_status_**, **_initiator_**, **_startDate_**, **_lastModified_**, **_parentId_**, **_businessKey_**.
+**_id_**, **_name_**, **_status_**, **_initiator_**, **_startDate_**, **_lastModified_**, **_parentId_**, **_businessKey_**.
 
 However, you can also choose which properties to show using a configuration in `app.config.json`:
 

e2e/process-services-cloud/processList-cloud-component.e2e.ts

@@ -87,7 +87,6 @@ describe('Process list cloud', () => {
             processCloudDemoPage.processListCloudComponent().getDataTable().checkColumnIsDisplayed('startDate');
             processCloudDemoPage.processListCloudComponent().getDataTable().checkColumnIsDisplayed('appName');
             processCloudDemoPage.processListCloudComponent().getDataTable().checkColumnIsDisplayed('businessKey');
-            processCloudDemoPage.processListCloudComponent().getDataTable().checkColumnIsDisplayed('description');
             processCloudDemoPage.processListCloudComponent().getDataTable().checkColumnIsDisplayed('initiator');
             processCloudDemoPage.processListCloudComponent().getDataTable().checkColumnIsDisplayed('lastModified');
             processCloudDemoPage.processListCloudComponent().getDataTable().checkColumnIsDisplayed('processName');

e2e/process-services-cloud/processListCloud.config.ts

@@ -58,12 +58,6 @@ export class ProcessListCloudConfiguration {
                         'title': 'ADF_CLOUD_PROCESS_LIST.PROPERTIES.BUSINESS_KEY',
                         'sortable': true
                     },
-                    {
-                        'key': 'entry.description',
-                        'type': 'text',
-                        'title': 'ADF_CLOUD_PROCESS_LIST.PROPERTIES.DESCRIPTION',
-                        'sortable': true
-                    },
                     {
                         'key': 'entry.initiator',
                         'type': 'text',

lib/process-services-cloud/src/lib/process/process-header/components/process-header-cloud.component.spec.ts

@@ -27,7 +27,6 @@ import { ProcessHeaderCloudService } from '../services/process-header-cloud.serv
 const processInstanceDetailsCloudMock = {
     appName: 'app-form-mau',
     businessKey: 'MyBusinessKey',
-    description: 'new desc',
     id: '00fcc4ab-4290-11e9-b133-0a586460016a',
     initiator: 'devopsuser',
     lastModified: 1552152187081,
@@ -91,16 +90,6 @@ describe('ProcessHeaderCloudComponent', () => {
         });
     }));
 
-    it('should display description', async(() => {
-        component.ngOnChanges();
-        fixture.detectChanges();
-
-        fixture.whenStable().then(() => {
-            const formNameEl = fixture.debugElement.query(By.css('[data-automation-id="card-textitem-value-description"] span'));
-            expect(formNameEl.nativeElement.innerText).toBe('new desc');
-        });
-    }));
-
     it('should display placeholder if no name is available', async(() => {
         processInstanceDetailsCloudMock.name = null;
         component.ngOnChanges();
@@ -113,18 +102,6 @@ describe('ProcessHeaderCloudComponent', () => {
 
     }));
 
-    it('should display placeholder if no description is available', async(() => {
-        processInstanceDetailsCloudMock.description = null;
-        component.ngOnChanges();
-        fixture.detectChanges();
-
-        fixture.whenStable().then(() => {
-            const valueEl = fixture.debugElement.query(By.css('[data-automation-id="card-textitem-value-description"] span'));
-            expect(valueEl.nativeElement.innerText).toBe('ADF_CLOUD_PROCESS_HEADER.PROPERTIES.DESCRIPTION_DEFAULT');
-        });
-
-    }));
-
     it('should display status', async(() => {
         component.ngOnChanges();
         fixture.detectChanges();

lib/process-services-cloud/src/lib/process/process-header/components/process-header-cloud.component.ts

@@ -86,13 +86,6 @@ export class ProcessHeaderCloudComponent implements OnChanges {
                     key: 'name',
                     default: this.translationService.instant('ADF_CLOUD_PROCESS_HEADER.PROPERTIES.NAME_DEFAULT')
                 }),
-            new CardViewTextItemModel(
-                {
-                    label: 'ADF_CLOUD_PROCESS_HEADER.PROPERTIES.DESCRIPTION',
-                    value: this.processInstanceDetails.description,
-                    key: 'description',
-                    default: this.translationService.instant('ADF_CLOUD_PROCESS_HEADER.PROPERTIES.DESCRIPTION_DEFAULT')
-                }),
             new CardViewTextItemModel(
                 {
                     label: 'ADF_CLOUD_PROCESS_HEADER.PROPERTIES.STATUS',

lib/process-services-cloud/src/lib/process/process-list/components/process-list-cloud.component.spec.ts

@@ -133,7 +133,6 @@ describe('ProcessListCloudComponent', () => {
             expect(component.rows[0].entry['appVersion']).toBe('');
             expect(component.rows[0].entry['id']).toBe('69eddfa7-d781-11e8-ae24-0a58646001fa');
             expect(component.rows[0].entry['name']).toEqual('starring');
-            expect(component.rows[0].entry['description']).toBeNull();
             expect(component.rows[0].entry['processDefinitionId']).toBe('BasicProcess:1:d05062f1-c6fb-11e8-ae24-0a58646001fa');
             expect(component.rows[0].entry['processDefinitionKey']).toBe('BasicProcess');
             expect(component.rows[0].entry['initiator']).toBe('devopsuser');

lib/process-services-cloud/src/lib/process/process-list/mock/process-list-service.mock.ts

@@ -26,7 +26,6 @@ export const fakeProcessCloudList = {
                     appVersion: '',
                     id: '69eddfa7-d781-11e8-ae24-0a58646001fa',
                     name: 'starring',
-                    description: null,
                     processDefinitionId: 'BasicProcess:1:d05062f1-c6fb-11e8-ae24-0a58646001fa',
                     processDefinitionKey: 'BasicProcess',
                     initiator: 'devopsuser',
@@ -44,7 +43,6 @@ export const fakeProcessCloudList = {
                     appVersion: '',
                     id: '8b3f625f-d781-11e8-ae24-0a58646001fa',
                     name: null,
-                    description: null,
                     processDefinitionId: 'BasicProcess:1:d05062f1-c6fb-11e8-ae24-0a58646001fa',
                     processDefinitionKey: 'BasicProcess',
                     initiator: 'devopsuser',
@@ -62,7 +60,6 @@ export const fakeProcessCloudList = {
                     appVersion: '',
                     id: '87c12637-d783-11e8-ae24-0a58646001fa',
                     name: null,
-                    description: null,
                     processDefinitionId: 'BasicProcess:1:d05062f1-c6fb-11e8-ae24-0a58646001fa',
                     processDefinitionKey: 'BasicProcess',
                     initiator: 'superadminuser',

lib/process-services-cloud/src/lib/process/process-list/models/process-cloud-query-request.model.ts

@@ -19,7 +19,6 @@ import { ProcessListCloudSortingModel } from './process-list-sorting.model';
 
 export class ProcessQueryCloudRequestModel {
    appName: string;
-   description?: string;
    initiator?: null;
    id?: string;
    name?: string;
@@ -37,7 +36,6 @@ export class ProcessQueryCloudRequestModel {
     constructor(obj?: any) {
        if (obj) {
            this.appName = obj.appName;
-           this.description = obj.description;
            this.initiator = obj.initiator;
            this.id = obj.id;
            this.name = obj.name;

lib/process-services-cloud/src/lib/process/start-process/models/process-instance-cloud.model.ts

@@ -19,7 +19,6 @@ export class ProcessInstanceCloud {
     appName: string;
     id: string;
     name: string;
-    description: string;
     startDate: Date;
     initiator: string;
     status: string;
@@ -33,7 +32,6 @@ export class ProcessInstanceCloud {
         this.appName = obj && obj.appName || null;
         this.id = obj && obj.id || null;
         this.name = obj && obj.name || null;
-        this.description = obj && obj.description || null;
         this.startDate = obj && obj.startDate || null;
         this.initiator = obj && obj.initiator || null;
         this.status = obj && obj.status || null;