From 29f28c7c8238f27193fdf31f0b972cd951ab04b8 Mon Sep 17 00:00:00 2001
From: Maurizio Vitale <maurizio.vitale@alfresco.com>
Date: Tue, 9 Oct 2018 12:26:04 +0100
Subject: [PATCH] [ADF-3670] Checklist - fix failing unit test (#3873)

* fix unit test on checklist

* Fix relative path import
---
 demo-shell/src/custom-style-dev.scss          |  8 +++---
 .../components/checklist.component.html       |  4 +--
 .../components/checklist.component.spec.ts    | 25 ++++++++++---------
 3 files changed, 19 insertions(+), 18 deletions(-)

diff --git a/demo-shell/src/custom-style-dev.scss b/demo-shell/src/custom-style-dev.scss
index 7f25c6ca5d..fa99852120 100644
--- a/demo-shell/src/custom-style-dev.scss
+++ b/demo-shell/src/custom-style-dev.scss
@@ -4,10 +4,10 @@
 @import './app/components/process-service/process-service.component.scss';
 
 
-@import 'content-services/styles/index';
-@import 'process-services/styles/index';
-@import 'insights/styles/index';
-@import 'core/styles/index';
+@import '../../lib/content-services/styles/index';
+@import '../../lib/process-services/styles/index';
+@import '../../lib/insights/styles/index';
+@import '../../lib/core/styles/index';
 
 @import '~@angular/material/theming';
 
diff --git a/lib/process-services/task-list/components/checklist.component.html b/lib/process-services/task-list/components/checklist.component.html
index 7a56607fb2..413dec984d 100644
--- a/lib/process-services/task-list/components/checklist.component.html
+++ b/lib/process-services/task-list/components/checklist.component.html
@@ -14,8 +14,8 @@
     <mat-chip-list class="mat-chip-list-stacked">
         <mat-chip id="check-{{check.id}}" class="adf-checklist-chip" *ngFor="let check of checklist">
             <span>{{check.name}}</span>
-            <button  *ngIf="!readOnly && !check.endDate" mat-icon-button type="button" class="adf-checklist-cancel-button" (click)="delete(check.id)">
-                <mat-icon id="remove-{{check.id}}" matChipRemove>cancel</mat-icon>
+            <button  *ngIf="!readOnly && !check.endDate" id="remove-{{check.id}}" mat-icon-button type="button" class="adf-checklist-cancel-button" (click)="delete(check.id)">
+                <mat-icon matChipRemove>cancel</mat-icon>
             </button>
         </mat-chip>
     </mat-chip-list>
diff --git a/lib/process-services/task-list/components/checklist.component.spec.ts b/lib/process-services/task-list/components/checklist.component.spec.ts
index 4548051a5e..44f84023b8 100644
--- a/lib/process-services/task-list/components/checklist.component.spec.ts
+++ b/lib/process-services/task-list/components/checklist.component.spec.ts
@@ -205,25 +205,26 @@ describe('ChecklistComponent', () => {
             });
         }));
 
-        it('should send an event when the checklist is deleted', (done) => {
+        it('should send an event when the checklist is deleted', async(() => {
             spyOn(service, 'deleteTask').and.returnValue(of(''));
-            let disposableDelete = checklistComponent.checklistTaskDeleted.subscribe(() => {
-                expect(element.querySelector('#fake-check-id')).toBeNull();
-                disposableDelete.unsubscribe();
-                done();
-            });
-
             checklistComponent.taskId = 'new-fake-task-id';
             checklistComponent.checklist.push(new TaskDetailsModel({
                 id: 'fake-check-id',
                 name: 'fake-check-name'
             }));
+
             fixture.detectChanges();
-            let checklistElementRemove = <HTMLElement> element.querySelector('#remove-fake-check-id');
-            expect(checklistElementRemove).toBeDefined();
-            expect(checklistElementRemove).not.toBeNull();
-            checklistElementRemove.click();
-        });
+            fixture.whenStable().then(() => {
+                fixture.detectChanges();
+                expect(checklistComponent.checklist.length).toBe(1);
+                let checklistElementRemove = <HTMLElement> element.querySelector('#remove-fake-check-id');
+                expect(checklistElementRemove).toBeDefined();
+                expect(checklistElementRemove).not.toBeNull();
+                checklistElementRemove.click();
+
+                expect(checklistComponent.checklist.length).toBe(0);
+            });
+        }));
 
         it('should show load task checklist on change', async(() => {