From 2a76b0846d64b26b1936593433a04f252bf5d768 Mon Sep 17 00:00:00 2001
From: davidcanonieto <david.cano.nieto@gmail.com>
Date: Fri, 8 Nov 2019 14:06:22 +0000
Subject: [PATCH] [AAE-485] Fix card view int item validator when value is
 empty (#5205)

* [AAE-485] Fix card view int item validator when value is empty

* Avoid creating a function every time we validate number

* Add return type to method
---
 .../card-view-textitem/card-view-textitem.component.html | 1 -
 .../validators/card-view-item-float.validator.ts         | 4 +++-
 .../card-view/validators/card-view-item-int.validator.ts | 9 ++++++++-
 3 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/lib/core/card-view/components/card-view-textitem/card-view-textitem.component.html b/lib/core/card-view/components/card-view-textitem/card-view-textitem.component.html
index 6fd3de9e5c..5ec01abea2 100644
--- a/lib/core/card-view/components/card-view-textitem/card-view-textitem.component.html
+++ b/lib/core/card-view/components/card-view-textitem/card-view-textitem.component.html
@@ -59,7 +59,6 @@
                 <button mat-icon-button class="adf-textitem-action" (click)="update()"
                     [attr.aria-label]="'CORE.METADATA.ACTIONS.SAVE' | translate"
                     [attr.title]="'CORE.METADATA.ACTIONS.SAVE' | translate"
-                    [disabled]="hasErrors()"
                     [attr.data-automation-id]="'card-textitem-update-' + property.key">
 
                     <mat-icon class="adf-textitem-icon">done</mat-icon>
diff --git a/lib/core/card-view/validators/card-view-item-float.validator.ts b/lib/core/card-view/validators/card-view-item-float.validator.ts
index 386c4f0862..ef4baada25 100644
--- a/lib/core/card-view/validators/card-view-item-float.validator.ts
+++ b/lib/core/card-view/validators/card-view-item-float.validator.ts
@@ -22,6 +22,8 @@ export class CardViewItemFloatValidator implements CardViewItemValidator {
     message = 'CORE.CARDVIEW.VALIDATORS.FLOAT_VALIDATION_ERROR';
 
     isValid(value: any): boolean {
-        return !isNaN(parseFloat(value)) && isFinite(value);
+        return value === ''
+            || !isNaN(parseFloat(value))
+            && isFinite(value);
     }
 }
diff --git a/lib/core/card-view/validators/card-view-item-int.validator.ts b/lib/core/card-view/validators/card-view-item-int.validator.ts
index 1b69e9abc4..392c4d4471 100644
--- a/lib/core/card-view/validators/card-view-item-int.validator.ts
+++ b/lib/core/card-view/validators/card-view-item-int.validator.ts
@@ -22,6 +22,13 @@ export class CardViewItemIntValidator implements CardViewItemValidator {
     message = 'CORE.CARDVIEW.VALIDATORS.INT_VALIDATION_ERROR';
 
     isValid(value: any): boolean {
-        return !isNaN(value) && (function(x) { return (x | 0) === x; })(parseFloat(value));
+        return value === ''
+            || !isNaN(value)
+            && this.isIntegerNumber(value);
+    }
+
+    isIntegerNumber(value: any): boolean {
+        const parsedNumber = parseFloat(value);
+        return (parsedNumber | 0) === parsedNumber;
     }
 }