[AAE-1178] ADF - deleted un-necessary steps (#5335)

* [AAE-1178] e2e/pages/adf - deleted un-necessary steps waitUntilElementIsVisble & waitUntilElementIsClickable before click() action & clearSendKeys()

* [AAE-1178] lib & cloud - deleted un-necessary steps waitUntilElementIsVisble & waitUntilElementIsClickable before click() action & clearSendKeys()

e2e/pages/adf/cardViewComponentPage.ts

@@ -67,7 +67,6 @@ export class CardViewComponentPage {
     }
 
     async enterTextField(text: string): Promise<void> {
-        await BrowserVisibility.waitUntilElementIsVisible(this.textField);
         await BrowserActions.clearSendKeys(this.textField, text);
     }
 
@@ -88,7 +87,6 @@ export class CardViewComponentPage {
     }
 
     async enterIntField(text): Promise<void> {
-        await BrowserVisibility.waitUntilElementIsVisible(this.intField);
         await BrowserActions.clearSendKeys(this.intField, text);
     }
 

e2e/pages/adf/demo-shell/process-services/peopleGroupCloudComponentPage.ts

@@ -77,17 +77,14 @@ export class PeopleGroupCloudComponentPage {
     }
 
     async enterPeopleRoles(roles): Promise<void> {
-        await BrowserVisibility.waitUntilElementIsVisible(this.peopleRoleInput);
         await BrowserActions.clearSendKeys(this.peopleRoleInput, roles);
     }
 
     async enterPeoplePreselect(preselect): Promise<void> {
-        await BrowserVisibility.waitUntilElementIsVisible(this.peoplePreselect);
         await BrowserActions.clearSendKeys(this.peoplePreselect, preselect);
     }
 
     async clearField(locator): Promise<void> {
-        await BrowserVisibility.waitUntilElementIsVisible(locator);
         await BrowserActions.clearSendKeys(locator, '');
     }
 
@@ -100,7 +97,6 @@ export class PeopleGroupCloudComponentPage {
     }
 
     async enterGroupRoles(roles): Promise<void> {
-        await BrowserVisibility.waitUntilElementIsVisible(this.groupRoleInput);
         await BrowserActions.clearSendKeys(this.groupRoleInput, roles);
     }
 
@@ -122,12 +118,10 @@ export class PeopleGroupCloudComponentPage {
     }
 
     async enterPeopleAppName(appName): Promise<void> {
-        await BrowserVisibility.waitUntilElementIsVisible(this.peopleAppInput);
         await BrowserActions.clearSendKeys(this.peopleAppInput, appName);
     }
 
     async enterGroupAppName(appName): Promise<void> {
-        await BrowserVisibility.waitUntilElementIsVisible(this.groupAppInput);
         await BrowserActions.clearSendKeys(this.groupAppInput, appName);
     }
 

e2e/pages/adf/demo-shell/process-services/processListDemoPage.ts

@@ -55,7 +55,6 @@ export class ProcessListDemoPage {
 
     async clickResetButton(): Promise<void> {
         await BrowserActions.click(this.resetButton);
-
     }
 
     async checkErrorMessageIsDisplayed(error): Promise<void> {
@@ -92,12 +91,10 @@ export class ProcessListDemoPage {
     }
 
     async addProcessDefinitionId(procDefinitionId): Promise<void> {
-        await BrowserActions.click(this.processDefinitionInput);
         await BrowserActions.clearSendKeys(this.processDefinitionInput, procDefinitionId);
     }
 
     async addProcessInstanceId(procInstanceId): Promise<void> {
-        await BrowserActions.click(this.processInstanceInput);
         await BrowserActions.clearSendKeys(this.processInstanceInput, procInstanceId);
     }
 }

e2e/pages/adf/demo-shell/process-services/taskListDemoPage.ts

@@ -46,7 +46,6 @@ export class TaskListDemoPage {
     }
 
     async typeAppId(input): Promise<void> {
-        await BrowserVisibility.waitUntilElementIsVisible(this.appId);
         await BrowserActions.clearSendKeys(this.appId, input);
     }
 
@@ -60,7 +59,6 @@ export class TaskListDemoPage {
     }
 
     async typeTaskId(input): Promise<void> {
-        await BrowserVisibility.waitUntilElementIsVisible(this.taskId);
         await BrowserActions.clearSendKeys(this.taskId, input);
     }
 
@@ -70,7 +68,6 @@ export class TaskListDemoPage {
     }
 
     async typeTaskName(input): Promise<void> {
-        await BrowserVisibility.waitUntilElementIsVisible(this.taskName);
         await BrowserActions.clearSendKeys(this.taskName, input);
     }
 
@@ -80,12 +77,10 @@ export class TaskListDemoPage {
     }
 
     async typeItemsPerPage(input): Promise<void> {
-        await BrowserVisibility.waitUntilElementIsVisible(this.itemsPerPage);
         await BrowserActions.clearSendKeys(this.itemsPerPage, input);
     }
 
     async typeProcessDefinitionId(input): Promise<void> {
-        await BrowserVisibility.waitUntilElementIsVisible(this.processDefinitionId);
         await BrowserActions.clearSendKeys(this.processDefinitionId, input);
     }
 
@@ -95,7 +90,6 @@ export class TaskListDemoPage {
     }
 
     async typeProcessInstanceId(input): Promise<void> {
-        await BrowserVisibility.waitUntilElementIsVisible(this.processInstanceId);
         await BrowserActions.clearSendKeys(this.processInstanceId, input);
     }
 
@@ -111,7 +105,6 @@ export class TaskListDemoPage {
     }
 
     async typePage(input): Promise<void> {
-        await BrowserVisibility.waitUntilElementIsVisible(this.page);
         await BrowserActions.clearSendKeys(this.page, input);
     }
 
@@ -127,12 +120,10 @@ export class TaskListDemoPage {
     }
 
     async typeDueAfter(input): Promise<void> {
-        await BrowserVisibility.waitUntilElementIsVisible(this.dueAfter);
         await BrowserActions.clearSendKeys(this.dueAfter, input);
     }
 
     async typeDueBefore(input): Promise<void> {
-        await BrowserVisibility.waitUntilElementIsVisible(this.dueBefore);
         await BrowserActions.clearSendKeys(this.dueBefore, input);
     }
 

e2e/pages/adf/dialog/folderDialog.ts

@@ -52,12 +52,10 @@ export class FolderDialog {
     }
 
     async addFolderName(folderName): Promise<void> {
-        await BrowserVisibility.waitUntilElementIsVisible(this.folderNameField);
         await BrowserActions.clearSendKeys(this.folderNameField, folderName);
     }
 
     async addFolderDescription(folderDescription): Promise<void> {
-        await BrowserVisibility.waitUntilElementIsVisible(this.folderDescriptionField);
         await BrowserActions.clearSendKeys(this.folderDescriptionField, folderDescription);
     }
 

e2e/pages/adf/dialog/shareDialog.ts

@@ -97,7 +97,6 @@ export class ShareDialog {
         await BrowserVisibility.waitUntilElementIsVisible(this.dayPicker);
 
         const tomorrow = moment().add(1, 'days').format('LL');
-        await BrowserVisibility.waitUntilElementIsClickable(this.dayPicker.element(by.css(`td[aria-label="${tomorrow}"]`)));
         await BrowserActions.click(this.dayPicker.element(by.css(`td[aria-label="${tomorrow}"]`)));
 
     }
@@ -105,13 +104,11 @@ export class ShareDialog {
     async setDefaultHour(): Promise<void> {
         const selector = '.mat-datetimepicker-clock-cell:not(.mat-datetimepicker-clock-cell-disabled)';
         await BrowserVisibility.waitUntilElementIsVisible(this.clockPicker);
-        await BrowserVisibility.waitUntilElementIsVisible(this.hoursPicker);
         await BrowserActions.click(this.hoursPicker.all(by.css(selector)).first());
     }
 
     async setDefaultMinutes() {
         const selector = '.mat-datetimepicker-clock-cell:not(.mat-datetimepicker-clock-cell-disabled)';
-        await BrowserVisibility.waitUntilElementIsVisible(this.minutePicker);
         await BrowserActions.click(this.minutePicker.all(by.css(selector)).first());
     }
 

e2e/pages/adf/dialog/uploadToggles.ts

@@ -104,7 +104,6 @@ export class UploadToggles {
     }
 
     async clearText(): Promise<void> {
-        await BrowserVisibility.waitUntilElementIsVisible(this.maxSizeField);
         await BrowserActions.clearSendKeys(this.maxSizeField, '');
     }
 

e2e/pages/adf/metadataViewPage.ts

@@ -157,13 +157,11 @@ export class MetadataViewPage {
 
     async enterPropertyText(propertyName: string, text: string | number): Promise<void> {
         const textField: ElementFinder = element(by.css('input[data-automation-id="card-textitem-editinput-' + propertyName + '"]'));
-        await BrowserVisibility.waitUntilElementIsClickable(textField);
         await BrowserActions.clearSendKeys(textField, text.toString());
     }
 
     async enterPresetText(text: string): Promise<void> {
         const presetField: ElementFinder = element(by.css('input[data-automation-id="adf-text-custom-preset"]'));
-        await BrowserVisibility.waitUntilElementIsVisible(presetField);
         await BrowserActions.clearSendKeys(presetField, text);
         const applyButton: ElementFinder = element(by.css('button[id="adf-metadata-aplly"]'));
         await BrowserActions.click(applyButton);
@@ -171,7 +169,6 @@ export class MetadataViewPage {
 
     async enterDescriptionText(text: string): Promise<void> {
         const textField: ElementFinder = element(by.css('textarea[data-automation-id="card-textitem-edittextarea-properties.cm:description"]'));
-        await BrowserVisibility.waitUntilElementIsVisible(textField);
         await BrowserActions.clearSendKeys(textField, text);
     }
 
@@ -244,7 +241,6 @@ export class MetadataViewPage {
     }
 
     async typeAspectName(aspectName): Promise<void> {
-        await BrowserVisibility.waitUntilElementIsVisible(this.displayAspect);
         await BrowserActions.clearSendKeys(this.displayAspect, aspectName);
     }
 

e2e/pages/adf/notificationPage.ts

@@ -58,12 +58,10 @@ export class NotificationPage {
     }
 
     async enterMessageField(text): Promise<void> {
-        await BrowserVisibility.waitUntilElementIsVisible(this.messageField);
         await BrowserActions.clearSendKeys(this.messageField, text);
     }
 
     async enterDurationField(time): Promise<void> {
-        await BrowserVisibility.waitUntilElementIsVisible(this.durationField);
         await BrowserActions.clearSendKeys(this.durationField, time);
     }
 
@@ -106,7 +104,6 @@ export class NotificationPage {
     }
 
     async clearMessage(): Promise<void> {
-        await BrowserVisibility.waitUntilElementIsVisible(this.messageField);
         await BrowserActions.clearSendKeys(this.messageField, '');
     }
 }

e2e/pages/adf/process-services/analyticsPage.ts

@@ -39,7 +39,6 @@ export class AnalyticsPage {
     }
 
     async clearReportTitle(): Promise<void> {
-        await BrowserVisibility.waitUntilElementIsVisible(this.toolbarTitleInput);
         await BrowserActions.clearSendKeys(this.toolbarTitleInput, '');
         await BrowserVisibility.waitUntilElementIsVisible(this.toolbarTitleInput);
     }

e2e/pages/adf/process-services/attachFormPage.ts

@@ -62,7 +62,6 @@ export class AttachFormPage {
     }
 
     async selectAttachFormOption(option): Promise<void> {
-        await BrowserVisibility.waitUntilElementIsClickable(element(by.cssContainingText("mat-option[role='option']", option)));
         await BrowserActions.click(element(by.cssContainingText("mat-option[role='option']", option)));
     }
 

e2e/pages/adf/process-services/dialog/createChecklistDialog.ts

@@ -26,7 +26,6 @@ export class ChecklistDialog {
     dialogTitle: ElementFinder = element(by.id('add-checklist-title'));
 
     async addName(name): Promise<void> {
-        await BrowserVisibility.waitUntilElementIsClickable(this.nameField);
         await BrowserActions.clearSendKeys(this.nameField, name);
     }
 

e2e/pages/adf/process-services/startProcessPage.ts

@@ -54,7 +54,6 @@ export class StartProcessPage {
     }
 
     async enterProcessName(name): Promise<void> {
-        await BrowserVisibility.waitUntilElementIsVisible(this.processNameInput);
         await BrowserActions.clearSendKeys(this.processNameInput, name);
     }
 
@@ -84,8 +83,6 @@ export class StartProcessPage {
     }
 
     async typeProcessDefinition(name): Promise<void> {
-        await BrowserVisibility.waitUntilElementIsVisible(this.processDefinition);
-        await BrowserVisibility.waitUntilElementIsClickable(this.processDefinition);
         await BrowserActions.clearSendKeys(this.processDefinition, name);
     }
 
@@ -99,7 +96,6 @@ export class StartProcessPage {
     }
 
     async clickFormStartProcessButton(): Promise<void> {
-        await BrowserVisibility.waitUntilElementIsClickable(this.formStartProcessButton);
         await BrowserActions.click(this.formStartProcessButton);
     }
 

e2e/pages/adf/tagPage.ts

@@ -51,7 +51,6 @@ export class TagPage {
     }
 
     async addNewTagInput(tag) {
-        await BrowserVisibility.waitUntilElementIsVisible(this.newTagInput);
         await BrowserActions.clearSendKeys(this.newTagInput, tag);
     }
 

lib/testing/src/lib/content-services/pages/search/date-range-filter.page.ts

@@ -101,7 +101,6 @@ export class DateRangeFilterPage {
     }
 
     async clickToField(): Promise<void> {
-        await BrowserVisibility.waitUntilElementIsClickable(this.filter.element(this.toField));
         await BrowserActions.click(this.filter.element(this.toField));
     }
 

lib/testing/src/lib/core/pages/form/widgets/dropdownWidget.ts

@@ -36,7 +36,6 @@ export class DropdownWidget {
     async openDropdown(locator: string = '#dropdown'): Promise<void> {
         await this.checkDropdownIsDisplayed(locator);
         const dropdown = locator ? element(by.css(`${locator}`)) : element(by.css(`#dropdown`));
-        await BrowserVisibility.waitUntilElementIsClickable(dropdown);
         await BrowserActions.click(dropdown);
     }
 

lib/testing/src/lib/core/pages/settings.page.ts

@@ -175,7 +175,6 @@ export class SettingsPage {
     }
 
     async setProcessServicesURL(processServiceURL) {
-        await BrowserVisibility.waitUntilElementIsVisible(this.bpmText);
         await BrowserActions.clearSendKeys(this.bpmText, processServiceURL);
     }
 
@@ -192,17 +191,14 @@ export class SettingsPage {
     }
 
     async clearProcessServicesURL() {
-        await BrowserVisibility.waitUntilElementIsVisible(this.bpmText);
         await BrowserActions.clearWithBackSpace(this.bpmText);
     }
 
     async setAuthHost(authHostURL) {
-        await BrowserVisibility.waitUntilElementIsVisible(this.authHostText);
         await BrowserActions.clearSendKeys(this.authHostText, authHostURL);
     }
 
     async setIdentityHost(identityHost) {
-        await BrowserVisibility.waitUntilElementIsVisible(this.identityHostText);
         await BrowserActions.clearSendKeys(this.identityHostText, identityHost);
     }
 

lib/testing/src/lib/core/pages/viewerPage.ts

@@ -113,7 +113,6 @@ export class ViewerPage {
     }
 
     async clearPageNumber(): Promise<void> {
-        await BrowserVisibility.waitUntilElementIsVisible(this.pageSelectorInput);
         await BrowserActions.clearSendKeys(this.pageSelectorInput, protractor.Key.ENTER);
     }
 
@@ -140,7 +139,6 @@ export class ViewerPage {
     }
 
     async enterPassword(password): Promise<void> {
-        await BrowserVisibility.waitUntilElementIsVisible(this.passwordInput);
         await BrowserActions.clearSendKeys(this.passwordInput, password);
     }
 
@@ -590,7 +588,7 @@ export class ViewerPage {
 
     async enterCustomName(text: string): Promise<void> {
         const textField: ElementFinder = element(by.css('input[data-automation-id="adf-text-custom-name"]'));
-        await BrowserVisibility.waitUntilElementIsVisible(textField);
+        // await BrowserVisibility.waitUntilElementIsVisible(textField);
         await BrowserActions.clearSendKeys(textField, text);
     }
 

lib/testing/src/lib/process-services-cloud/pages/group-cloud-component.page.ts

@@ -30,7 +30,6 @@ export class GroupCloudComponentPage {
     }
 
     async searchGroupsToExisting(name) {
-        await BrowserVisibility.waitUntilElementIsVisible(this.groupCloudSearch);
         await BrowserActions.clearSendKeys(this.groupCloudSearch, name);
     }
 

lib/testing/src/lib/process-services-cloud/pages/people-cloud-component.page.ts

@@ -30,7 +30,6 @@ export class PeopleCloudComponentPage {
     }
 
     async searchAssigneeAndSelect(name: string): Promise<void> {
-        await BrowserVisibility.waitUntilElementIsVisible(this.peopleCloudSearch);
         await BrowserActions.clearSendKeys(this.peopleCloudSearch, name);
         await this.selectAssigneeFromList(name);
     }
@@ -43,7 +42,6 @@ export class PeopleCloudComponentPage {
     }
 
     async searchAssigneeToExisting(name: string): Promise<void> {
-        await BrowserVisibility.waitUntilElementIsVisible(this.peopleCloudSearch);
         await BrowserActions.clearSendKeys(this.peopleCloudSearch, name);
     }
 

lib/testing/src/lib/process-services-cloud/pages/start-tasks-cloud-component.page.ts

@@ -69,8 +69,6 @@ export class StartTasksCloudPage {
     }
 
     async blur(locator: ElementFinder): Promise<void> {
-        await BrowserVisibility.waitUntilElementIsVisible(locator);
-        await BrowserVisibility.waitUntilElementIsClickable(locator);
         await BrowserActions.click(locator);
         await locator.sendKeys(Key.TAB);
     }